[edk2] [PATCH 13/13] ShellPkg: UefiShellBcfgCommandLib: print optional data with DumpHex()

The DumpHex() function produces very friendly output (known from DMPSTORE, for example); let's use it with "BCFG -v" as well. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek

[edk2] [PATCH 03/13] ShellPkg: UefiShellBcfgCommandLib: hoist NULL-init of DevPath[String]

It will help with error handling if we move these initializations near the top of the loop body. This patch is not supposed to change behavior. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 05/13] ShellPkg: UefiShellBcfgCommandLib: enforce minimum size for Boot#### and co.

"3.1.1 Boot Manager Programming" in the UEFI 2.5 spec mandates that Boot and similar options contain EFI_LOAD_OPTION structures. The EFI_LOAD_OPTION structure encodes the fixed initial part of the payload, and we can (and should) use it to enforce a minimum size for variable contents. This

[edk2] [PATCH 04/13] ShellPkg: UefiShellBcfgCommandLib: accumulate errors

Don't exit the command immediately when a variable access fails; continue processing after printing the error message. Let the final return status reflect any encountered errors. This patch is intended as a functional improvement. Cc: Jaben Carsey Cc: Ryan Harkin

Re: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

On 01/21/16 02:29, Carsey, Jaben wrote: > All 3 modified libraries need their version information modified. I think > that the minor version of all 3 libraries debug, BCFG, and ShellCommandLib > need to be incremented. > > Otherwise I think this looks good. Thank you for the super quick

Re: [edk2] [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries

Reviewed-by：Dandan Bi -Original Message- From: Kinney, Michael D Sent: Thursday, January 21, 2016 9:31 AM To: edk2-devel@lists.01.org Cc: Steele, Kelly; Bi, Dandan Subject: [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries Rename the Ui

Re: [edk2] [PATCH 11/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Infineon I2C TPM

Reviewed by: Kelly Steele -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Yao, Jiewen Subject: [PATCH 11/12] QuarkPlatformPkg: Add

Re: [edk2] [PATCH 10/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Atmel I2C TPM

Reviewed by: Kelly Steele -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Yao, Jiewen Subject: [PATCH 10/12] QuarkPlatformPkg: Add

Re: [edk2] [PATCH 12/12] QuarkPlatformPkg: Add MEASURED_BOOT_ENABLE feature

Reviewed by: Kelly Steele -Original Message- From: Kinney, Michael D Sent: January 20, 2016 18:10 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Yao, Jiewen Subject: [PATCH 12/12] QuarkPlatformPkg: Add

Re: [edk2] [PATCH 04/12] SecurityPkg/TrEEConfig: Remove use of IoLib

Mike The patch 1-12 are good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Kinney, Michael D Sent: Thursday, January 21, 2016 1:24 PM To: Zhang, Chao B; edk2-devel@lists.01.org; Kinney, Michael D Cc: Yao, Jiewen

[edk2] [PATCH 10/13] ShellPkg: UefiShellBcfgCommandLib: fix reporting of OptionalData

In this cleaned up form of BcfgDisplayDump(), it is easier to see that the OptionalDataOffset <= BufferSize expression, used to report whether optional data are *absent*, is incorrect. For any well-formed EFI_LOAD_OPTION, this inequality always holds. Optional data are present exactly if

[edk2] [PATCH 12/13] ShellPkg: elevate DumpHex() from Debug1-internal to generic-internal

The UEFI Shell specification classifies shell commands into various shell levels / profiles. Currently the DumpHex() internal function is only used by commands that belong to the Debug1 profile exclusively (i.e., they are not required to be present in other than Debug1 profiles): - SMBIOSVIEW -

[edk2] [PATCH 06/13] ShellPkg: UefiShellBcfgCommandLib: address FilePathListLength by name

The Buffer variable points at the beginning of an EFI_LOAD_OPTION structure. We might as well address the "FilePathListLength" member by name, rather than with *(UINT16*)(Buffer+4). This patch is not supposed to change behavior. Cc: Jaben Carsey Cc: Ryan Harkin

[edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin

[edk2] [PATCH 09/13] ShellPkg: UefiShellBcfgCommandLib: calculate OptionalDataOffset explicitly

Eliminate some more repeated pointer arithmetic. This patch too is only refactoring. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 11/13] ShellPkg: UefiShellBcfgCommandLib: fix ShellPrintEx() call site

This is likely a copy & paste error from the preceding ShellPrintHiiEx() function call. ShellPrintEx() takes no Language parameter, so remove the NULL argument, which is currently misinterpreted as a format string. This bug prevents the hexdump of optional data even when -v is passed to BCFG, and

[edk2] [PATCH 01/13] ShellPkg: UefiShellBcfgCommandLib: update whitespace & layout

This patch incurs no functional changes, it just modifies some whitespace, so we can separate these non-functional changes from the functional changes in the next patches. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution

[edk2] [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries

Rename the Ui libraries,so need to update the QuarkPlatformPkg.dsc file. Cc: Kelly Steele Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- QuarkPlatformPkg/Quark.dsc

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

Paolo, I think for short write case it means the data length to be written in AtaPacketReadWrite, that is ByteCount, is less than the one shipped in ATA cmd, for example, CDB (READ10.byte7&8). For such case, it should jump out the while loop in AtaPacketReadWrite and send EFI_DEVICE_ERROR as

Re: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

All 3 modified libraries need their version information modified. I think that the minor version of all 3 libraries debug, BCFG, and ShellCommandLib need to be incremented. Otherwise I think this looks good. -Jaben > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 04/12] SecurityPkg/TrEEConfig: Remove use of IoLib

Hi Chao I think we rely on Tpm12DeviceLib/Tpm12RequestUseTpm() to *detect* the existence of dTPM, because TPM12/TPM20 share same device access capability. If Tpm12RequestUseTpm() return fail, the hidden meaning is that TIS does not work. So it is safe to return DEVICE_NULL here. The benefit is

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

Laszlo, When I re-think about the cursor issue, I am curious whether the function keys (F1/F2/...) work well in your platform. I guess any keys that will translate to multiple bytes don't work. Correct? But I never heard of such issue in X86 platforms so far even the IsaSerialDxe driver in

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

Laszlo, I may not agree with your change to the Terminal driver. Firstly it's not a good code practice to not preserve the other fields when changing the time out value. People may forget that the FIFO depth was changed in Terminal driver after a long enough period. Secondly your change resets

Re: [edk2] [PATCH 04/12] SecurityPkg/TrEEConfig: Remove use of IoLib

Chao, It further below in the same function. Mike > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, January 20, 2016 8:40 PM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: RE: [PATCH 04/12]

Re: [edk2] [PATCH 09/12] SecurityPkg/TcgDxe: Use updated Tpm12CommandLib APIs

Hi Mike Patch 10~12 reviewed by: jiewen@intel.com I think we need more TCG feature like MOR or PP. Also, I guess we need ACPI table to report I2C resource to OS, right? We can add them later. I do not see problem for this series. Thank you Yao Jiewen -Original Message- From: Yao,

[edk2] [PATCH 09/12] SecurityPkg/TcgDxe: Use updated Tpm12CommandLib APIs

Use the following new APIs in Tpm12CommandLib and remove duplicate code from TcgPei and TcgDxe: Tpm12Extend() Tpm12PhysicalPresence() Tpm12ContinueSelfTest() Tpm12GetCapabilityFlagPermanent() Tpm12GetCapabilityFlagVolatile() Cc: Chao Zhang Cc: Jiewen Yao

[edk2] [PATCH 01/12] SecurityPkg/TcgPei: Replace TpmCommLib with Tpm12DeviceLib

Update TCG drivers for TPM 1.2 devices to use Tpm12DeviceLib instead of TpmCommLib. This is required to support TPM 1.2 hardware devices that are not on LPC bus. The current versions of the TCG PEIM and DXE driver contain MMIO reads/writes to a TPM attached to an LPC bus. In order to support

[edk2] [PATCH 03/12] SecurityPkg/TcgConfigDxe: Replace TpmCommLib with Tpm12DeviceLib

Update TCG drivers for TPM 1.2 devices to use Tpm12DeviceLib instead of TpmCommLib. This is required to support TPM 1.2 hardware devices that are not on LPC bus. Cc: Chao Zhang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 02/12] SecurityPkg/TcgDxe: Replace TpmCommLib with Tpm12DeviceLib

Update TCG drivers for TPM 1.2 devices to use Tpm12DeviceLib instead of TpmCommLib. This is required to support TPM 1.2 hardware devices that are not on LPC bus. The current versions of the TCG PEIM and DXE driver contain MMIO reads/writes to a TPM attached to an LPC bus. In order to support

[edk2] [PATCH 07/12] SecurityPkg/Tpm12CommandLib: Add TPM 1.2 commands used by TCG modules

Add the following APIs that are required by TcgPei and/or TcgDxe to the Tpm12CommandLib instance: Tpm12Extend() Tpm12PhysicalPresence() Tpm12ContinueSelfTest() Tpm12GetCapabilityFlagPermanent() Tpm12GetCapabilityFlagVolatile() Cc: Chao Zhang Cc: Jiewen Yao

[edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin

[edk2] [PATCH 08/12] SecurityPkg/TcgPei: Use updated Tpm12CommandLib APIs

Use the following new APIs in Tpm12CommandLib and remove duplicate code from TcgPei and TcgDxe: Tpm12Extend() Tpm12PhysicalPresence() Tpm12ContinueSelfTest() Tpm12GetCapabilityFlagPermanent() Tpm12GetCapabilityFlagVolatile() Cc: Chao Zhang Cc: Jiewen Yao

Re: [edk2] [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries

Reviewed by: Kelly Steele -Original Message- From: Kinney, Michael D Sent: January 20, 2016 17:31 To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Bi, Dandan Subject: [Patch] QuarkPlatformPkg/Quark.dsc: Update for

[edk2] [PATCH 12/12] QuarkPlatformPkg: Add MEASURED_BOOT_ENABLE feature

Add MEASURED_BOOT_ENABLE flag Add TPM_12_HARDWARE flag Add TrEEConfigPei to detect TPM 1.2 hardware device Use Tpm12DeviceLib instance for Atmel I2C TPM Use Tpm12DeviceLib instance for Infineon I2C TPM Add TcgPei and TcgDxe modules for TPM 1.2 support Clean up TpmMeasurementLib mappings Cc: Kelly

[edk2] [PATCH 10/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Atmel I2C TPM

Add new Tpm12DeviceLib instance for an Atmel I2C TPM Cc: Kelly Steele Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- .../Library/Tpm12DeviceLibAtmelI2c/TisPc.c

[edk2] [PATCH 04/12] SecurityPkg/TrEEConfig: Remove use of IoLib

Remove the use of the IoLib and Mmioxx() calls to detect dTPM. This module calls the Tpm12DeviceLib to detect a TPM and the implementation of the Tpm12DeviceLib for dTPM performs the same Mmioxx() calls to detect a dTPM. This change makes this module more generic and portable by maximizing the

[edk2] [PATCH 11/12] QuarkPlatformPkg: Add Tpm12DeviceLib instance for Infineon I2C TPM

Add Tpm12DeviceLib instance for Infineon I2C TPM Cc: Kelly Steele Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- .../Library/Tpm12DeviceLibInfineonI2c/TisPc.c

[edk2] [PATCH 05/12] SecurityPkg/Tcg2Config: Remove use of IoLib

Remove the use of the IoLib and Mmioxx() calls to detect dTPM. This module calls the Tpm12DeviceLib to detect a TPM and the implementation of the Tpm12DeviceLib for dTPM performs the same Mmioxx() calls to detect a dTPM. This change makes this module more generic and portable by maximizing the

[edk2] [PATCH 00/12] Add support for non-LPC TPM 1.2 hardware devices

This patch series updates the TCG modules and libraries in the SecurityPkg to remove assumptions that a TPM 1.2 hardware device is always on an LPC bus and allows a TPM 1.2 hardware device to be located on alternate bus types such as I2C and SPI. The changes include: 1) Use the Tpm12DeviceLib

[edk2] [PATCH 06/12] SecurityPkg/Tpm12CommandLib.h: Add TPM 1.2 commands used by TCG modules

Add the following APIs that are required by TcgPei and/or TcgDxe: Tpm12Extend() Tpm12PhysicalPresence() Tpm12ContinueSelfTest() Tpm12GetCapabilityFlagPermanent() Tpm12GetCapabilityFlagVolatile() Cc: Chao Zhang Cc: Jiewen Yao

Re: [edk2] [PATCH] [ShellPkg] fix operator

On 01/20/16 23:18, Ryan Harkin wrote: > > On 20 Jan 2016 21:23, "Carsey, Jaben" > wrote: >> >> I will wait. >> >> -Jaben >> >> > -Original Message- >> > From: Laszlo Ersek [mailto:ler...@redhat.com ] >> >

[edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

For some SCSI commands, notably INQUIRY, it's relatively common for the device to provide less data than we intended to read, and for this reason EFI_EXT_SCSI_PASS_THRU_SCSI_REQUEST_PACKET makes InTransferLength and OutTransferLength read-write. Make ATAPI aware of this. This makes it possible

Re: [edk2] Shell BCFG command - adding option data

Short help to long answer to long question. First you must enable verbose (use -v) output to see the optional data. Second - I agree something is wrong with that N saying there isn't any. The question is why that math thinks that there is no more data in the buffer. The output you're looking

Re: [edk2] Shell BCFG command - adding option data

On 01/20/16 20:52, Carsey, Jaben wrote: > Short help to long answer to long question. > > First you must enable verbose (use -v) output to see the optional data. Yep, thanks for the hint! I managed to figure it out as well, after all, in my followup. > Second - I agree something is wrong with

Re: [edk2] Shell BCFG command - adding option data

Long answer to long question ahead :) On 01/20/16 19:54, Ryan Harkin wrote: > Hello all, > > I'm using Shell.efi, a magic binary that is included in my aarch64 FVP binary. Not a magic binary, except if your platform DSC relies on the prebuilt binary that is (for some unfathomable reason)

Re: [edk2] Shell BCFG command - adding option data

On 01/20/16 20:48, Laszlo Ersek wrote: > Long answer to long question ahead :) > > On 01/20/16 19:54, Ryan Harkin wrote: >> Hello all, >> >> I'm using Shell.efi, a magic binary that is included in my aarch64 FVP >> binary. > > Not a magic binary, except if your platform DSC relies on the

Re: [edk2] Shell BCFG command - adding option data

On 01/20/16 21:20, Ryan Harkin wrote: > On 20 January 2016 at 19:52, Carsey, Jaben wrote: >> Short help to long answer to long question. >> >> First you must enable verbose (use -v) output to see the optional data. > > I already tried using -v but I've never seen the

Re: [edk2] [PATCH] [ShellPkg] fix operator

I will wait. -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 20, 2016 1:21 PM > To: Carsey, Jaben ; edk2-de...@ml01.01.org > Cc: ryan.har...@linaro.org > Subject: Re: [PATCH] [ShellPkg] fix operator >

Re: [edk2] Shell BCFG command - adding option data

On 20 January 2016 at 19:52, Carsey, Jaben wrote: > Short help to long answer to long question. > > First you must enable verbose (use -v) output to see the optional data. I already tried using -v but I've never seen the optional data > Second - I agree something is

[edk2] [PATCH] [ShellPkg] fix operator

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: jaben carsey --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] Shell BCFG command - adding option data

Laszlo, I was thinking that we could add something like this up front in the file and then we could remove lots of the pointer math from the main code part to make the logical part of the code easier to understand. #define BCFG_VAR_BUFFER_ATTS (x) (((EFI_LOAD_OPTION)(x))->Attributes) #define

Re: [edk2] Shell BCFG command - adding option data

On 01/20/16 22:30, Carsey, Jaben wrote: > Laszlo, > > I was thinking that we could add something like this up front in the file and > then we could remove lots of the pointer math from the main code part to make > the logical part of the code easier to understand. > > #define

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

Hi Paolo, On 01/20/16 16:58, Paolo Bonzini wrote: > For some SCSI commands, notably INQUIRY, it's relatively common for > the device to provide less data than we intended to read, and for > this reason EFI_EXT_SCSI_PASS_THRU_SCSI_REQUEST_PACKET makes > InTransferLength and OutTransferLength

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

On 01/20/16 22:57, Paolo Bonzini wrote: > > > On 20/01/2016 19:15, Laszlo Ersek wrote: >> If you think it's unnecessary to test the *short* write case >> specifically, then I'm willing to give my T-b. Thanks for the patch! > > Your testing is enough. The only way to test the short write case

Re: [edk2] [PATCH] [ShellPkg] fix operator

On 20 Jan 2016 21:23, "Carsey, Jaben" wrote: > > I will wait. > > -Jaben > > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Wednesday, January 20, 2016 1:21 PM > > To: Carsey, Jaben ; edk2-de...@ml01.01.org

Re: [edk2] [PATCH] [ShellPkg] fix operator

Note that when you specify your 1 2 3 it’s interpreted as a keystroke code. If you want a string you should use “1 2 3”… From: Ryan Harkin [mailto:ryan.har...@linaro.org] Sent: Wednesday, January 20, 2016 2:18 PM To: Carsey, Jaben Cc: edk2-devel@lists.01.org

Re: [edk2] [PATCH 0/3] MdeModulePkg: fix cursor movement keys on ARM FVP / Juno

On 01/19/16 14:53, Laszlo Ersek wrote: > In this series I've rounded up the ideas & fixes from the recent > discussion, started by Ryan's problem report. The commit messages are > verbose and contain references to the mailing list, so this blurb is > long enough already. :) > > I'd highly

[edk2] [PATCH] ArmPkg: LinuxLoader: fix typo in help string

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- ArmPkg/Application/LinuxLoader/LinuxLoader.uni | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Application/LinuxLoader/LinuxLoader.uni

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

On 01/19/16 21:34, Paolo Bonzini wrote: > > > On 19/01/2016 00:29, Laszlo Ersek wrote: >>> INQUIRY works slightly different from other commands. It has a maximum >>> length instead of a deterministic length; once HCYL/LCYL are read back, >>> should RequiredBytes not be adjusted in this case?