Re: [edk2] [PATCH v3] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-24 Thread Fu, Siyuan
The patch is good. Reviewed-by: Siyuan Fu -Original Message- From: Zhang, Lubo Sent: Monday, January 25, 2016 10:57 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin Subject:

Re: [edk2] [PATCH] Nt32Pkg: Fix asserts from running Nt32 64-bit on Win8

2016-01-24 Thread Gao, Liming
That's good. Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shia, Cinnamon Sent: Wednesday, January 20, 2016 11:05 AM To: Gao, Liming; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] Nt32Pkg:

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeDxe: Fix GCC build failure.

2016-01-24 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Monday, January 25, 2016 10:28 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/PciHostBridgeDxe: Fix GCC build failure. Contributed-under: TianoCore Contribution

[edk2] [Patch] MdeModulePkg/PciHostBridgeDxe: Fix GCC build failure.

2016-01-24 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg/.../IdeMode: correctly report length of returned data

2016-01-24 Thread Tian, Feng
I am OK with the fix. Reviewed-by: Feng Tian PS: The "should" words is my thought on the write case (not tested as well:-)). I thought the first patch should also work on short write case. Thanks Feng -Original Message- From: Laszlo Ersek

Re: [edk2] [patch 6/6] SecurityPkg: Add TPM PTP support in TCG2 Config.

2016-01-24 Thread Zhang, Chao B
Jiewen: Patch 1-6 are good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, January 22, 2016 3:14 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch 6/6]

[edk2] [patch] MdeModulePkg:Make the logic in ConfigRouting.c clear and safe

2016-01-24 Thread Dandan Bi
The BlockData is expected to be NULL when to call function IsThisOpcodeRequired in each opcode,but now exists case that the Blockdata not be cleaned,then will be used in other opcode.it is not correct,now add the check before use. The comments and logic in function IsThisOpcodeRequired are not

[edk2] [PATCH v3] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-24 Thread Zhang Lubo
v3: * Change the code logic in Ip6Dxe/ComponentName.c and TcpMisc.c Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting

Re: [edk2] [Patch] Refine the code to avoid potential buffer overflow or use NULL pointer.

2016-01-24 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Dong, Eric Sent: Wednesday, January 20, 2016 2:59 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] Refine the code to avoid potential buffer overflow or use NULL pointer. Contributed-under: TianoCore

[edk2] [Patch] BaseTools: Fix the bug when no FD section in the FDF file

2016-01-24 Thread Yonghong Zhu
Check if the Fdf.CurrentFdName is not None and in Fdf.Profile.FdDict before using it which fix a crash issue when no FD section in FDF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py