Re: [edk2] [PATCH v2 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe driver's adding ASL code

2016-04-20 Thread Wu, Hao A
> -Original Message- > From: Justen, Jordan L > Sent: Wednesday, April 20, 2016 3:21 PM > To: Wu, Hao A; edk2-devel@lists.01.org; Tian, Feng; samer.el-haj- > mahm...@hpe.com; Yao, Jiewen > Cc: Wu, Hao A; Laszlo Ersek > Subject: Re: [PATCH v2 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build fail

2016-04-20 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Thursday, April 21, 2016 10:07 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build fail > > Cc: Liming Gao

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix the VS2010/VS2012 build fail

2016-04-20 Thread Dandan Bi
Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

2016-04-20 Thread Wu, Jiaxin
Hello Bhupesh, Any test result or feedback for this patch? Thanks. Jiaxin > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, April 20, 2016 1:10 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: David Van Arnem ; Bhupesh Sharma >

Re: [edk2] [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from source

2016-04-20 Thread He, Tim
it is good for me. Reviewed-by: Tim He Best Regards, Tim -Original Message- From: Justen, Jordan L Sent: Thursday, April 21, 2016 1:14 AM To: edk2-devel@lists.01.org; Wei, David; He, Tim Subject: Re: [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from

Re: [edk2] [PATCH 01/12] FatPkg: Update License.txt to have the full license text

2016-04-20 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Thursday, April 21, 2016 12:53 AM To: edk2-devel@lists.01.org; Ni, Ruiyu Subject: Re: [edk2] [PATCH 01/12] FatPkg: Update License.txt to

Re: [edk2] [staging/HTTPS-TLS][PATCH 0/3] Provide an UI to support TLS authentication

2016-04-20 Thread El-Haj-Mahmoud, Samer
Thanks! I will take a look once I can build this and test it. For now: Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, Jiaxin Sent: Tuesday, April 19, 2016 10:13 PM To:

[edk2] [PATCH v4 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO window. The root complex resources in SSDT should match these settings. This patch fixes the min/max base address for the IO window in Juno PCIe root complex ACPI table. It also adds 'TypeTranslation'

Re: [edk2] [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from source

2016-04-20 Thread Jordan Justen
David, Tim, Any thoughts about this patch? -Jordan On 2016-04-06 08:15:01, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Note: Not build tested > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 00/12] Cleanups to follow FatPkg license update

2016-04-20 Thread Jordan Justen
On 2016-04-20 01:29:57, Ni, Ruiyu wrote: > Patch 2 is good. Reviewed-by: Ruiyu Ni > The commit message for patch 1 looks strange. I cannot fully understand it. > > - > The script replaced the contents of License.txt will the words the > shortened text that we include in

Re: [edk2] [PATCH 01/12] FatPkg: Update License.txt to have the full license text

2016-04-20 Thread Jordan Justen
On 2016-04-06 08:14:50, Jordan Justen wrote: > The script replaced the contents of License.txt will the words the > shortened text that we include in the headers to files. Instead, use > the full text. This is copied from MdePkg/License.txt. > In a reply to the cover-letter email, Ray wrote "The

Re: [edk2] [PATCH 08/12] CorebootPayloadPkg: Use serial drivers with PlatformHookLib

2016-04-20 Thread Ma, Maurice
Hi, Lee, Let's see try to use the Dynamic PCD solution to avoid duplicating the drivers in MdeModulePkg. Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, April 19, 2016 1:31 PM To: edk2-devel@lists.01.org; Ma, Maurice; Agyeman, Prince; Leahy, Leroy P Subject:

Re: [edk2] [PATCH 10/12] CorebootPayloadPkg: Allow MaxLogicalProcessorNumber to be changed

2016-04-20 Thread Ma, Maurice
This patch looks good. Reviewed-by: Maurice Ma Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, April 19, 2016 1:32 PM To: edk2-devel@lists.01.org; Ma, Maurice; Agyeman, Prince; Leahy, Leroy P Subject: [PATCH 10/12] CorebootPayloadPkg: Allow

Re: [edk2] [PATCH 11/12] CorebootPayloadPkg/PlatformHelperLib: Remove unreferenced function

2016-04-20 Thread Ma, Maurice
This patch looks good. Reviewed-by: Maurice Ma Thanks Maurice -Original Message- From: Leahy, Leroy P Sent: Tuesday, April 19, 2016 1:32 PM To: edk2-devel@lists.01.org; Ma, Maurice; Agyeman, Prince; Leahy, Leroy P Subject: [PATCH 11/12]

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Jeremy Linton
On 04/20/2016 11:00 AM, Sudeep Holla wrote: On 20/04/16 16:54, Sudeep Holla wrote: On 20/04/16 16:44, Jeremy Linton wrote: On 04/20/2016 10:35 AM, Sudeep Holla wrote: [...] Yes I got bitten by that and I failed to notice it :). I have fixed it locally and tested correctly now.

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Jeremy Linton
On 04/20/2016 10:54 AM, Sudeep Holla wrote: On 20/04/16 16:44, Jeremy Linton wrote: On 04/20/2016 10:35 AM, Sudeep Holla wrote: [...] Yes I got bitten by that and I failed to notice it :). I have fixed it locally and tested correctly now. DWordIo ( // IO window

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
On 20/04/16 16:54, Sudeep Holla wrote: On 20/04/16 16:44, Jeremy Linton wrote: On 04/20/2016 10:35 AM, Sudeep Holla wrote: [...] Yes I got bitten by that and I failed to notice it :). I have fixed it locally and tested correctly now. DWordIo ( // IO window

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
On 20/04/16 16:44, Jeremy Linton wrote: On 04/20/2016 10:35 AM, Sudeep Holla wrote: [...] Yes I got bitten by that and I failed to notice it :). I have fixed it locally and tested correctly now. DWordIo ( // IO window ResourceProducer, MinFixed,

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Jeremy Linton
On 04/20/2016 10:35 AM, Sudeep Holla wrote: On 20/04/16 16:13, Jeremy Linton wrote: On 04/20/2016 09:39 AM, G Gregory wrote: On 20 April 2016 at 15:30, Sudeep Holla wrote: XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
On 20/04/16 16:13, Jeremy Linton wrote: On 04/20/2016 09:39 AM, G Gregory wrote: On 20 April 2016 at 15:30, Sudeep Holla wrote: XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO window. The root complex resources in SSDT

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Jeremy Linton
On 04/20/2016 09:39 AM, G Gregory wrote: On 20 April 2016 at 15:30, Sudeep Holla wrote: XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO window. The root complex resources in SSDT should match these settings. This patch

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
On 20/04/16 15:39, G Gregory wrote: On 20 April 2016 at 15:30, Sudeep Holla wrote: XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO window. The root complex resources in SSDT should match these settings. This patch fixes

Re: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively with '-r'.

2016-04-20 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey From: Qiu, Shumin Sent: Tuesday, April 19, 2016 7:52 PM To: Carsey, Jaben Cc: Qiu, Shumin ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively

Re: [edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread G Gregory
On 20 April 2016 at 15:30, Sudeep Holla wrote: > XPress-RICH3 PCIe driver initializes the root complex with the source > and target address for IO window. The root complex resources in SSDT > should match these settings. > > This patch fixes the min/max base address for the

[edk2] [PATCH v3 1/3] Platforms/ARM/Juno: Fix IO window min/max base address in PCIe root complex

2016-04-20 Thread Sudeep Holla
XPress-RICH3 PCIe driver initializes the root complex with the source and target address for IO window. The root complex resources in SSDT should match these settings. This patch fixes the min/max base address for the IO window in Juno PCIe root complex ACPI table. Contributed-under: TianoCore

Re: [edk2] [PATCH v2 1/3] Platforms/ARM/Juno: Fix IO window translate offset in PCIe root complex

2016-04-20 Thread Sudeep Holla
On 20/04/16 15:10, Ard Biesheuvel wrote: On 20 April 2016 at 16:09, Sudeep Holla wrote: XPress-RICH3 PCIe driver initialises the root complex with the same source and target address for IO window which makes translate offset 0. This patch fixes the translate offset for

Re: [edk2] [PATCH v2 1/3] Platforms/ARM/Juno: Fix IO window translate offset in PCIe root complex

2016-04-20 Thread Ard Biesheuvel
On 20 April 2016 at 16:09, Sudeep Holla wrote: > XPress-RICH3 PCIe driver initialises the root complex with the same > source and target address for IO window which makes translate offset 0. > > This patch fixes the translate offset for the IO window in Juno PCIe > root

[edk2] [PATCH v2 1/3] Platforms/ARM/Juno: Fix IO window translate offset in PCIe root complex

2016-04-20 Thread Sudeep Holla
XPress-RICH3 PCIe driver initialises the root complex with the same source and target address for IO window which makes translate offset 0. This patch fixes the translate offset for the IO window in Juno PCIe root complex ACPI table. Contributed-under: TianoCore Contribution Agreement 1.0 Cc:

Re: [edk2] [PATCH v2 1/2] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-04-20 Thread Yao, Jiewen
Samer I agree with you that RamDisk should not touch NFIT and SSDT installed by other modules. What I mean is that RamDisk should remove NFIT and SSDT if they are installed by RamDisk driver itself. The code in patch forgets removing NFIT and SSDT even no RamDisk or NVDIMM existed, which seems

Re: [edk2] [PATCH v2 1/2] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-04-20 Thread Yao, Jiewen
Thanks. I think the code to add SSDT and NFIT is good. But I have concern on RamDiskUnpublishNfit(). I suggest we remove NFIT and SSDT if all RamDisk is removed. We should give OS a clean environment, if no RamDisk is published. Thank you Yao Jiewen > -Original Message- > From: Wu,

Re: [edk2] OVMF: hang when booting Linux via GRUB after driver allocates 2GB above 4GB

2016-04-20 Thread Laszlo Ersek
On 04/20/16 02:59, Bruce Cran wrote: > On 4/19/16 6:04 AM, Laszlo Ersek wrote: > >> Bruce, could you please test this? If 742563777e8d is indeed the >> solution, I will file an RHBZ (for the RHEL kernel) to backport it. > > > Laszlo, I've just verified that 742563777e8d does indeed fix the >

[edk2] [PATCH] ArmPkg/AArch64Mmu: don't let table entries inherit XN permission bits

2016-04-20 Thread Ard Biesheuvel
When we split a block entry into a table entry, the UXN/PXN/XN permission attributes are inherited both by the new table entry and by the new block entries at the next level down. Unlike the NS bit, which only affects the next level of lookup, the XN table bits supersede the permissions of the

Re: [edk2] [PATCH 3/3] Platforms/ARM/Juno: Add support for ACPI 6.0 LPI(Low Power Idle) states

2016-04-20 Thread Sudeep Holla
On 20/04/16 08:42, Ard Biesheuvel wrote: On 19 April 2016 at 17:11, Sudeep Holla wrote: ACPI 6.0 introduced LPI(Low Power Idle) states that provides an alternate method to describe processor idle states. LPI extensions leverages the processor container device(again

Re: [edk2] facing memory allocation failure on QEMU

2016-04-20 Thread Ard Biesheuvel
On 20 April 2016 at 09:33, Meenakshi Aggarwal wrote: > Hi, > > > I am trying to load a signed image from UEFI shell using QEMU, For any signed > image I faced following message (snapshot taken after loading grub): > > FS0:\> grubaa64-signed.efi > FSOpen: Open

Re: [edk2] [PATCH 3/3] Platforms/ARM/Juno: Add support for ACPI 6.0 LPI(Low Power Idle) states

2016-04-20 Thread Ard Biesheuvel
On 19 April 2016 at 17:11, Sudeep Holla wrote: > ACPI 6.0 introduced LPI(Low Power Idle) states that provides an alternate > method to describe processor idle states. > > LPI extensions leverages the processor container device(again introduced > in ACPI 6.0) allowing to

Re: [edk2] [PATCH 1/3] Platforms/ARM/Juno: Fix IO window translate offset in PCIe root complex

2016-04-20 Thread Ard Biesheuvel
On 19 April 2016 at 17:11, Sudeep Holla wrote: > XPress-RICH3 PCIe driver initialises the root complex with the same > source and target address for IO window which makes translate offset 0. > > This patch fixes the translate offset for the IO window in Juno PCIe > root

Re: [edk2] [PATCH 2/3] Platforms/ARM/Juno: limit ACPI support to v5.0 and higher

2016-04-20 Thread Ard Biesheuvel
On 19 April 2016 at 17:11, Sudeep Holla wrote: > The ACPI spec predates the AARCH64 architecture by 5 versions, so there > is no point in supporting anything below v5.0. So set the PCD that > controls the ACPI table generation to the appropriate value. > > Based on the

[edk2] facing memory allocation failure on QEMU

2016-04-20 Thread Meenakshi Aggarwal
Hi, I am trying to load a signed image from UEFI shell using QEMU, For any signed image I faced following message (snapshot taken after loading grub): FS0:\> grubaa64-signed.efi FSOpen: Open '\grubaa64-signed.efi' Success FSOpen: Open '\grubaa64-signed.efi' Success FSOpen: Open

Re: [edk2] [PATCH v2 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe driver's adding ASL code

2016-04-20 Thread Jordan Justen
On 2016-04-19 18:58:55, Hao Wu wrote: > The RamDiskDxe driver in MdeModulePkg now will sometimes report a NVDIMM > Root Device using ASL code which is put in a Secondary System Description > Table (SSDT) according to the ACPI 6.1 spec. > > Locating the SSDT requires modifying the fdf files in