DEVICE_ID_NOCARE is defined as 0x but Spec says (UINT64) -1
should be used to match any VendorId/DeviceId/RevisionId/
SubsystemVendorId/SubsystemDeviceId.
PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/
PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such
definitions.
PI spec IncompatiblePciSupport part defines (UINT64) -1 as all BARs
and 0 to use existing alignment. PciBus driver didn't accept these
values. It treated 0xFF as all BARs and 0xULL to use
existing alignment.
The patch changes the code to still accept old values while also
accept
When BarIndex equals to 0xFF, default value 0 is used as the BAR
index. Though PCI_BAR_ALL and MAX_UINT8 shares the same value,
using PCI_BAR_ALL is like to match any BAR not BAR 0, it's more
proper to use MAX_UINT8 here.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
When the VendorId/DeviceId/RevisionId/SubsystemVendorId
/SubsystemDeviceId is (UINT64)-1, IncompatiblePciDeviceSupport
driver doesn't use it to match any IDs.
The patch fixes this bug.
Since PciBus driver always calls IncompatiblePciDeviceSupport
using IDs read from HW, (UINT64)-1 is never passed
If a platform developer follows the PI spec to write an
IncompatiblePciDeviceSupport driver, due to a spec complaince
bug in PciBus driver, the IncompatiblePciDeviceSupport driver
may not work as expected. The patches fix PciBus to follow Spec
to accept Spec defined values.
Ruiyu Ni (5):
Star:
The patch is good to me. Reviewed-by: Chao Zhang
-Original Message-
From: Zeng, Star
Sent: Tuesday, January 24, 2017 6:07 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Yao, Jiewen ;
Zhang, Chao B
Before the "cd fs0:dir" fix, CD only prints destination directory
when the destination contains ":".
However, the "cd fs0:dir" fix changed CD to always print destination
directory.
This patch changes CD to never print destination directory.
Contributed-under: TianoCore Contribution Agreement 1.0
> On Jan 25, 2017, at 6:38 PM, Yao, Jiewen wrote:
>
> HI Pete
> Thanks to add a new arch support to EBC module.
>
> I like the idea to keep compatibility:
>> a) EBC executables that were produced with the older version of the
>> specs will run exactly as they did on EBC
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Thomas Huth [mailto:th...@redhat.com]
> Sent: Wednesday, January 25, 2017 6:02 PM
> To: edk2-de...@ml01.01.org
> Cc: Ni, Ruiyu
> Subject: [PATCH] OptionRomPkg: Remove superfluous
HI Pete
Thanks to add a new arch support to EBC module.
I like the idea to keep compatibility:
> a) EBC executables that were produced with the older version of the
> specs will run exactly as they did on EBC VMs that comply with the newer
> version of the specs
Thank you to let us know that we
Good feature to catch mis-configuration.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, January 24, 2017 6:07 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Zhang, Chao B
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
> Chao B
> Sent: Wednesday, January 25, 2017 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zhang, Chao B
>
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Wednesday, January 25, 2017 1:42 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zhang, Chao B
On Wed, Jan 25, 2017 at 03:16:21PM +, Ryan Harkin wrote:
> On 14 December 2016 at 03:47, Daniil Egranov wrote:
> > Fixed several style issues.
> > The patch set has been squashed in to the single patch after the
> > code review.
> >
>
> These are not the commit
On Tue, Jan 24, 2017 at 11:07:12AM +, Ryan Harkin wrote:
> On 24 January 2017 at 02:01, Daniil Egranov wrote:
> > The Marvell Yukon MAC address load supported only on Juno R1 and R2.
> > It disabled for Juno R0 due to PCI issues on this board.
> >
> >
If the code eventually returns "Status" anyway, it does not make
sense to explicitly return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth
---
OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c | 3
If the code eventually returns "Status" anyway, it does not make
sense to explicitly return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth
---
SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4
1
17 matches
Mail list logo