[edk2] [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros

2017-01-25 Thread Ruiyu Ni
DEVICE_ID_NOCARE is defined as 0x but Spec says (UINT64) -1 should be used to match any VendorId/DeviceId/RevisionId/ SubsystemVendorId/SubsystemDeviceId. PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such definitions.

[edk2] [PATCH 3/5] MdeModulePkg/PciBus: Accept Spec values as BarIndex and Alignment

2017-01-25 Thread Ruiyu Ni
PI spec IncompatiblePciSupport part defines (UINT64) -1 as all BARs and 0 to use existing alignment. PciBus driver didn't accept these values. It treated 0xFF as all BARs and 0xULL to use existing alignment. The patch changes the code to still accept old values while also accept

[edk2] [PATCH 2/5] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL

2017-01-25 Thread Ruiyu Ni
When BarIndex equals to 0xFF, default value 0 is used as the BAR index. Though PCI_BAR_ALL and MAX_UINT8 shares the same value, using PCI_BAR_ALL is like to match any BAR not BAR 0, it's more proper to use MAX_UINT8 here. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 5/5] MdeModulePkg/IncompatiblePci: Use -1 to match any IDs

2017-01-25 Thread Ruiyu Ni
When the VendorId/DeviceId/RevisionId/SubsystemVendorId /SubsystemDeviceId is (UINT64)-1, IncompatiblePciDeviceSupport driver doesn't use it to match any IDs. The patch fixes this bug. Since PciBus driver always calls IncompatiblePciDeviceSupport using IDs read from HW, (UINT64)-1 is never passed

[edk2] [PATCH 0/5] Fix PciBus to accept Spec values as BarIndex and Alignment

2017-01-25 Thread Ruiyu Ni
If a platform developer follows the PI spec to write an IncompatiblePciDeviceSupport driver, due to a spec complaince bug in PciBus driver, the IncompatiblePciDeviceSupport driver may not work as expected. The patches fix PciBus to follow Spec to accept Spec defined values. Ruiyu Ni (5):

Re: [edk2] [PATCH] SecurityPkg HashLibRouter: Avoid incorrect PcdTcg2HashAlgorithmBitmap

2017-01-25 Thread Zhang, Chao B
Star: The patch is good to me. Reviewed-by: Chao Zhang -Original Message- From: Zeng, Star Sent: Tuesday, January 24, 2017 6:07 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Zhang, Chao B

[edk2] [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits

2017-01-25 Thread Ruiyu Ni
Before the "cd fs0:dir" fix, CD only prints destination directory when the destination contains ":". However, the "cd fs0:dir" fix changed CD to always print destination directory. This patch changes CD to never print destination directory. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-25 Thread Andrew Fish
> On Jan 25, 2017, at 6:38 PM, Yao, Jiewen wrote: > > HI Pete > Thanks to add a new arch support to EBC module. > > I like the idea to keep compatibility: >> a) EBC executables that were produced with the older version of the >> specs will run exactly as they did on EBC

Re: [edk2] [PATCH] OptionRomPkg: Remove superfluous return statement

2017-01-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Thomas Huth [mailto:th...@redhat.com] > Sent: Wednesday, January 25, 2017 6:02 PM > To: edk2-de...@ml01.01.org > Cc: Ni, Ruiyu > Subject: [PATCH] OptionRomPkg: Remove superfluous

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-25 Thread Yao, Jiewen
HI Pete Thanks to add a new arch support to EBC module. I like the idea to keep compatibility: > a) EBC executables that were produced with the older version of the > specs will run exactly as they did on EBC VMs that comply with the newer > version of the specs Thank you to let us know that we

Re: [edk2] [PATCH] SecurityPkg HashLibRouter: Avoid incorrect PcdTcg2HashAlgorithmBitmap

2017-01-25 Thread Yao, Jiewen
Good feature to catch mis-configuration. Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, January 24, 2017 6:07 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Zhang, Chao B

Re: [edk2] [PATCH] SecurityPkg: Tcg2Dxe: Update PCR[4] measure logic

2017-01-25 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, > Chao B > Sent: Wednesday, January 25, 2017 1:42 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B >

Re: [edk2] [PATCH] SecurityPkg: Tcg2Dxe: Update PCR[4] measure logic

2017-01-25 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Wednesday, January 25, 2017 1:42 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zhang, Chao B

Re: [edk2] [PATCH v5] OpenPlatformPkg/Drivers/Net/MarvellYukonDxe: Added multi-controller support

2017-01-25 Thread Leif Lindholm
On Wed, Jan 25, 2017 at 03:16:21PM +, Ryan Harkin wrote: > On 14 December 2016 at 03:47, Daniil Egranov wrote: > > Fixed several style issues. > > The patch set has been squashed in to the single patch after the > > code review. > > > > These are not the commit

Re: [edk2] [PATCH v2] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Fixed crash on Juno R0

2017-01-25 Thread Leif Lindholm
On Tue, Jan 24, 2017 at 11:07:12AM +, Ryan Harkin wrote: > On 24 January 2017 at 02:01, Daniil Egranov wrote: > > The Marvell Yukon MAC address load supported only on Juno R1 and R2. > > It disabled for Juno R0 due to PCI issues on this board. > > > >

[edk2] [PATCH] OptionRomPkg: Remove superfluous return statement

2017-01-25 Thread Thomas Huth
If the code eventually returns "Status" anyway, it does not make sense to explicitly return "Status" in case of an error, too. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth --- OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c | 3

[edk2] [PATCH] SecurityPkg: Remove superfluous return statement

2017-01-25 Thread Thomas Huth
If the code eventually returns "Status" anyway, it does not make sense to explicitly return "Status" in case of an error, too. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth --- SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 1