Re: [edk2] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in UfsPassThruGetTargetLun()

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent: Tuesday, May 16, 2017 1:35 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star Subject: [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in

[edk2] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in UfsPassThruGetTargetLun()

For function UfsPassThruGetTargetLun(), the length of the input device node specified by 'DevicePath' should be compared with the size of 'UFS_DEVICE_PATH' rather than the size of 'SCSI_DEVICE_PATH'. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

Sergey: Could you give more detail on the undefined behavior on variadic parameters? I see https://bugzilla.tianocore.org/show_bug.cgi?id=410 describe this issues found in the latest CLANG tool chain. Do you find other tool chain reports it? Thanks Liming > -Original Message- >

Re: [edk2] [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

On Mon, May 15, 2017 at 05:40:59PM -0700, Jordan Justen wrote: > On 2017-05-12 01:40:34, Laszlo Ersek wrote: > > On 05/12/17 04:02, Gary Lin wrote: > > > On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > > >> On Sat, May 06, 2017 at 09:30:18PM +0200, Laszlo Ersek wrote: > > >>> (All hail

[edk2] [PATCH] MdeModulePkg: Fix undefined behavior on variadic parameters

Fix undefined behavior by avoiding automatic type promotion Signed-off-by: Sergey Temerkhanov --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH] MdePkg: Fix undefined behavior on variadic parameters

Fix undefined behavior by avoiding parameter type promotion Signed-off-by: Sergey Temerkhanov --- MdePkg/Include/Library/UefiLib.h | 2 +- MdePkg/Library/UefiLib/UefiLib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31

These registers are reserved for PPIs and unimplemented on some architectures Signed-off-by: Sergey Temerkhanov --- ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c

Re: [edk2] [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

On 2017-05-12 01:40:34, Laszlo Ersek wrote: > On 05/12/17 04:02, Gary Lin wrote: > > On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > >> On Sat, May 06, 2017 at 09:30:18PM +0200, Laszlo Ersek wrote: > >>> (All hail Saturday!) > >>> > >>> Gary, can you please fetch this from my repo (URL

Re: [edk2] [PATCH 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB

On 2017-05-06 12:30:20, Laszlo Ersek wrote: > EmuVariableFvbRuntimeDxe currently produces a Firmware Volume Block > protocol that is based on a block map of two blocks, each block having > PcdFlashNvStorageFtwSpareSize for size. > > (The total size is 2 * PcdFlashNvStorageFtwSpareSize.) > >

Re: [edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

Hi Tim, I think those are reasonable arguments. It's probably best to just leave the touch command alone. It sounds like we've gotten along fine with the existing behavior for quite a while. Regards, Jeff On Mon, 15 May 2017, Tim Lewis wrote: I don't think it is good to change the

Re: [edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

I don't think it is good to change the behavior of the tool beyond what is in the specification. Further, this tool has existed for quite a long time in the EDK shell and now the UEFI shell without this behavior. So the de-facto standard of this environment is "don't create". Leaving behind

[edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

The UEFI Shell touch command returns an error if a file to be touched doesn't exist. In other command line operating environments, the touch command typically creates a file if it doesn't exist. This patch updates the UEFI Shell touch command to follow this convention. Cc: Ruiyu Ni

Re: [edk2] [PATCH 5/7] OvmfPkg/PlatformPei: don't allocate reserved mem varstore if SMM_REQUIRE

On 2017-05-05 14:02:56, Laszlo Ersek wrote: > For the emulated variable store, PlatformPei allocates reserved memory (as > early as possible, so that the address remains the same during reboot), > and PcdEmuVariableNvStoreReserved carries the address to > EmuVariableFvbRuntimeDxe. > > However,

Re: [edk2] [PATCH v2] ShellPkg/Ls: Handle path specified from root

Reviewed-by: Jaben Carsey > -Original Message- > From: Jeff Westfahl [mailto:jeff.westf...@ni.com] > Sent: Monday, May 15, 2017 10:18 AM > To: edk2-devel@lists.01.org > Cc: Jeff Westfahl ; Ni, Ruiyu ; > Carsey, Jaben

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 2017-05-11 11:01:57, Brijesh Singh wrote: > > > On 05/11/2017 12:43 PM, Jordan Justen wrote: > > On 2017-05-11 08:53:39, Laszlo Ersek wrote: > >> (5) Please mention that the driver is being added to the APRIORI DXE > >> file for a separate reason as well (not just for the early clearing of >

[edk2] [PATCH v2] ShellPkg/Ls: Handle path specified from root

This fixes 'ls' when specifying a path from the root, like "ls \" from within a subfolder. Currently, 'ls' will append the specified path to the current working directory. The correct behavior is to start from the root of the currently selected filesystem. Cc: Ruiyu Ni Cc:

[edk2] UEFI HTTPS Boot Whitepaper on gitbook

The UEFI HTTPS Boot whitepaper, originally published as an Intel document, has been migrated to the TianoCore gitbook account. We plan to use gitbook format for all future TianoCore whitepapers. Please review and let us know if you have any feedback.

[edk2] [staging/cadence-aarch64] Add readme for cadence-aarch64 branch

Announcing the creation of a new edk2-staging branch for Cadence peripheral hardware support in AArch64 platforms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Scott Telford --- Readme.MD | 27 +++ 1 file changed, 27

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Star -- Thanks for your work on this. I have reviewed this and it looks good, addressing all of our concerns. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, May 15, 2017 2:46 AM To: Tim Lewis ; Kinney, Michael D

Re: [edk2] [RFC 0/2] PCD: Extended SKU support 2 - sub SKU

Hi, The development will be done on a staging branch if there is no any comments in the following week. Anyway, feedback still can be provided during the development on the staging branch and merging to master finally. :) Thanks, Star -Original Message- From: Zeng, Star Sent:

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Thanks all for the comments to this RFC. I have sent out the V2 of this RFC at https://www.mail-archive.com/edk2-devel@lists.01.org/msg25687.html. Tim, Could you help review the V2 of this RFC and provide feedback? With the V2 of this RFC, the actual code for the runtime usage you provided

[edk2] [RFC V2] PCD: Extended SKU support 1 - inheritance

- Requirement Simplify the PCDs configuring for multiple SKUs in DSC. Provide interface to get the relationship between multiple SKUs for runtime usage. - Current limitation Non-DEFAULT SKU could only derive from DEFAULT SKU, but could not derive from another non-DEFAULT SKU. For example