Re: [edk2] [PATCH] MdePkg/IndustryStandard: update ACPI/IORT definitions to revision C

Liming is taking leave today, and Reviewed-by: Star Zeng . And we have no concern to pull this to UDK2017 branch. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, June 27, 2017 12:57

Re: [edk2] [PATCH V3 3/3] DuetPkg FsVariable: Update GetNextVariableName to follow UEFI 2.7

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, June 26, 2017 5:21 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Ni, Ruiyu > Subject: [PATCH

Re: [edk2] [PATCH] ShellPkg: Update dh command to reflect correct driver field information

Tapan, Can you change commit message to similar as below? dh command gets driver name and wrongly prints it as 'Child [handle]'. It should print it as 'Driver Name [handle]'. Thanks/Ray > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Tuesday, June 27, 2017

Re: [edk2] [PATCH V4] MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol

I have reverted this patch at fd220166c435479a81dfe8519c92abec9acf7d82 first. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, June 27, 2017 8:53 AM To: Laszlo Ersek ; Amit Kumar ; edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [PATCH V4] MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol

Laszlo, I agree to revert this patch first since it breaks something. Could you help do that with detailed revert log? Anyway, have you found any bug in this patch itself? Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, June 27, 2017 8:47

Re: [edk2] [PATCH V4] MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol

On 06/23/17 12:09, Amit Kumar wrote: > Change since v3: > 1) Fixed issue when Attributes = EFI_OPEN_PROTOCOL_TEST_PROTOCOL > and Inteface = NULL case. [Reported by:star.zeng at intel.com] > > Change Since v2: > 1) Modified to use EFI_ERROR to get status code > > Change since v1: > 1) Fixed typo

Re: [edk2] can't boot OVMF guest after commit 45cfcd8

On 06/26/17 21:52, Laszlo Ersek wrote: > Hi Gabriel, > > On 06/26/17 19:13, Gabriel L. Somlo wrote: >> Hi, >> >> Following commit 45cfcd8dccf84b8abbc1d6f587fedb5d2037ec79, a.k.a. >> "MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol", >> I'm no longer able to boot a VM guest with

Re: [edk2] [PATCH 1/5] OvmfPkg: introduce Q35TsegSizeLib (class header and sole lib instance)

On 06/27/17 00:36, Jordan Justen wrote: > On 2017-06-26 12:12:45, Laszlo Ersek wrote: >> On 06/26/17 19:59, Jordan Justen wrote: >>> I looked at this series a number of times. My thought is that: >>> >>> * PcdQ35TsegMbytes should become dynamic >>> >>> * No PCD for tseg mask >>> >>> * PlatformPei

Re: [edk2] [PATCH 1/5] OvmfPkg: introduce Q35TsegSizeLib (class header and sole lib instance)

On 2017-06-26 12:12:45, Laszlo Ersek wrote: > On 06/26/17 19:59, Jordan Justen wrote: > > I looked at this series a number of times. My thought is that: > > > > * PcdQ35TsegMbytes should become dynamic > > > > * No PCD for tseg mask > > > > * PlatformPei adds knowledge of qemu ext tseg to set

[edk2] [PATCH] ShellPkg: Update dh command to reflect correct driver field information

dh command gets driver name and prints it as 'Child [handle]' instead of printing it as 'Driver Name [handle]'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tapan Shah --- ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 3 ++-

Re: [edk2] can't boot OVMF guest after commit 45cfcd8

Hi Gabriel, On 06/26/17 19:13, Gabriel L. Somlo wrote: > Hi, > > Following commit 45cfcd8dccf84b8abbc1d6f587fedb5d2037ec79, a.k.a. > "MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol", > I'm no longer able to boot a VM guest with OVMF. Using command line: > >

Re: [edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

On 06/26/17 18:47, Supreeth Venkatesh wrote: > *** > PI v1.5 Specification Volume 4 defines Management Mode Core Interface. > In order to support Management Mode Core Interface, Module Types > MM_STANDALONE, MM_CORE_STANDALONE are needed. > PI specification v1.5 defines the following new file

Re: [edk2] [PATCH 1/5] OvmfPkg: introduce Q35TsegSizeLib (class header and sole lib instance)

On 06/26/17 19:59, Jordan Justen wrote: > On 2017-06-19 12:39:51, Laszlo Ersek wrote: >> >> Even if the PCDs were technically doable, I think I'd slightly prefer >> the current approach. The PCI config space accesses at module startup >> are minimal, and they affect only three modules. OTOH,

Re: [edk2] [PATCH 1/5] OvmfPkg: introduce Q35TsegSizeLib (class header and sole lib instance)

On 2017-06-19 12:39:51, Laszlo Ersek wrote: > > Even if the PCDs were technically doable, I think I'd slightly prefer > the current approach. The PCI config space accesses at module startup > are minimal, and they affect only three modules. OTOH, introducing two > PCDs feels, in this particular

Re: [edk2] can't boot OVMF guest after commit 45cfcd8

Hi, Following commit 45cfcd8dccf84b8abbc1d6f587fedb5d2037ec79, a.k.a. "MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol", I'm no longer able to boot a VM guest with OVMF. Using command line: bin/qemu-system-x86_64 -machine q35,accel=kvm -m 2048 -bios OVMF.fd \ -device

Re: [edk2] [PATCH] MdePkg/IndustryStandard: update ACPI/IORT definitions to revision C

On 22 June 2017 at 11:02, Ard Biesheuvel wrote: > This updates the IORT header to include the definitions that were added > in revision C of the IORT spec that was made public recently. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

[edk2] [PATCH v5 10/10] BaseTools/Eot: register MM Module types with FFS class.

This patch registers MM_STANDALONE and MM_CORE_STANDALONE with Ffs class. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh --- BaseTools/Source/Python/Eot/FvImage.py | 2 ++ 1

[edk2] [PATCH v5 09/10] BaseTools/Workspace: check MM module type compatibility with PI version.

This patch checks SUP_MODULE_MM_CORE_STANDALONE and SUP_MODULE_MM_STANDALONE module compatibility with PI specification version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh

[edk2] [PATCH v5 08/10] BaseTools/build: register MM module types with build tools.

This patch registers MM_STANDALONE and MM_CORE_STANDALONE module type with python build tools. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh ---

[edk2] [PATCH v5 07/10] BaseTools/GenFds: register MM Modules and MM FV file types.

This patch verifies MM_CORE_STANDALONE module compatibility with PI specification version. Also, it registers MM_STANDALONE/MM_CORE_STANDALONE modules with FdfParser class and provides mapping between MM_STANDALONE and MM_CORE_STANDALONE module type in FDF with EFI_FV_FILETYPE_MM_STANDALONE and

[edk2] [PATCH v5 06/10] BaseTools/CommonDataClass: register MM Modules.

This patch registers MM_STANDALONE and MM_CORE_STANDALONE module types with CommonClass and PackageIncludePkgHeaderClass in CommonDataClass. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh

[edk2] [PATCH v5 05/10] BaseTools/Common: add support in FDF Parser to parse MM Modules.

This patch adds support for FdfParser tool to parse MM_STANDALONE and MM_CORE_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh ---

[edk2] [PATCH v5 03/10] BaseTools/AutoGen: auto generate MM template APIs and dependencies.

This patch adds changes to auto generate MM_CORE_STANDALONE and MM_STANDALONE Entry Point templates. Also, it adds changes to help auto generate dependency expressions for MM_STANDALONE modules. PI Specification v1.5 specifies Management Mode System Table (MMST) which is a collection of common

[edk2] [PATCH v5 04/10] BaseTools/Common: add MM Module data types.

This patch adds SUP_MODULE_MM_STANDALONE and SUP_MODULE_MM_CORE_STANDALONE data types and includes it in SUP_MODULE_LIST. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Supreeth Venkatesh ---

[edk2] [PATCH v5 02/10] BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers.

PI v1.5 Specification Volume 4 defines Management Mode Core Interface. In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. This patch ensures that MM_STANDALONE, MM_CORE_STANDALONE Modules are treated as EFI Boot Service Driver in GenFw

[edk2] [PATCH v5 01/10] BaseTools/GenFfs: add FFS file types for MM modules.

PI specification v1.5 defines new firmware volume file types for Management Mode (MM). This patch adds the new file type EFI_FV_FILETYPE_MM_STANDALONE and EFI_FV_FILETYPE_MM_CORE_STANDALONE in GenFfs tool. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao

[edk2] [PATCH v5 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

*** PI v1.5 Specification Volume 4 defines Management Mode Core Interface. In order to support Management Mode Core Interface, Module Types MM_STANDALONE, MM_CORE_STANDALONE are needed. PI specification v1.5 defines the following new file types: #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E

[edk2] DXE core - Connecting a controller to driver

Hi experts, I have a question related to the ConnectController implementation in the edk2 codebase (MdeModulePkg\Core\Dxe\Hand\DriverSupport.c). Under the CoreConnectSingleController function, what if DriverBinding->Supported returns an error? I see that there is a do/while loop waiting for

Re: [edk2] [PATCH v4 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification ***

On Fri, 2017-06-23 at 23:19 +0200, Laszlo Ersek wrote: > Hi, > > On 06/23/17 22:41, Supreeth Venkatesh wrote: > > > > ***  > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface. > > In order to support Management Mode Core Interface, Module Types > > MM_STANDALONE,

[edk2] [PATCH V3 2/3] MdeModulePkg Variable: Update GetNextVariableName to follow UEFI 2.7

"The size must be large enough to fit input string supplied in VariableName buffer" is added in the description for VariableNameSize. And two cases of EFI_INVALID_PARAMETER are added. 1. The input values of VariableName and VendorGuid are not a name and GUID of an existing variable. 2.

[edk2] [PATCH V3 3/3] DuetPkg FsVariable: Update GetNextVariableName to follow UEFI 2.7

"The size must be large enough to fit input string supplied in VariableName buffer" is added in the description for VariableNameSize. And two cases of EFI_INVALID_PARAMETER are added. 1. The input values of VariableName and VendorGuid are not a name and GUID of an existing variable. 2.

[edk2] [PATCH V3 1/3] MdePkg: Update comments for GetNextVariableName to follow UEFI 2.7

"The size must be large enough to fit input string supplied in VariableName buffer" is added in the description for VariableNameSize. And two cases of EFI_INVALID_PARAMETER are added. 1. The input values of VariableName and VendorGuid are not a name and GUID of an existing variable. 2.

[edk2] [PATCH V3 0/3] Update comments and code for GetNextVariableName to follow UEFI 2.7

V3: Remove the ((VariableName[MaxLen - 1] != 0) check and enhance the code comments based on Ruiyu's feedback. V2: Add changes for EmuVariable and FsVariable. "The size must be large enough to fit input string supplied in VariableName buffer" is added in the description for

Re: [edk2] [patch 2/2] MdeModulePkg/BdsDxe: Report Status Code when booting from BootOrder list

Looks good. This is what we discussed with Ray for adding BDS platform hook function. Thanks for implementing this, Dandan. Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, June

Re: [edk2] [patch 1/2] MdePkg/PiStatusCode: Add new Status Code for BDS when attempting BootOrder

Looks good. This is what we discussed with Ray for adding BDS platform hook function. Thanks for implementing this, Dandan. Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, June

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Security of Setup Variable

System can still boot to shell and OS successfully after EFI variable deletion/corruption. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BuildBios.bat | 11 +-

Re: [edk2] [PATCH V2 3/3] DuetPkg FsVariable: Update GetNextVariableName to follow UEFI 2.7

I meant the behavior by the spec was unpredictable. "Passing in a VariableName parameter that is neither a Null-terminated string nor a value that was returned on the previous call to GetNextVariableName() may also produce *unpredictable* results." The behavior by the code was to return

Re: [edk2] [PATCH V2 3/3] DuetPkg FsVariable: Update GetNextVariableName to follow UEFI 2.7

Thanks! Could you please put the comments in code? But why do you say it's unpredictable? The behavior is to return EFI_NOT_FOUND. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, June 26, 2017 1:52 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc:

Re: [edk2] [patch 2/2] MdeModulePkg/BdsDxe: Report Status Code when booting from BootOrder list

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, June 26, 2017 1:51 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2]

Re: [edk2] [patch 1/2] MdePkg/PiStatusCode: Add new Status Code for BDS when attempting BootOrder

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Monday, June 26, 2017 1:51 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [patch 1/2] MdePkg/PiStatusCode: Add new Status Code for BDS > when attempting