Re: [edk2] [PATCH] MdeModulePkg/UsbStorage: Fix "map -r" cannot detect media change

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, January 19, 2018 3:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [PATCH] MdeModulePkg/UsbStorage: Fix "map -r"

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

Yes, and the function comment were already there. -Original Message- From: Ni, Ruiyu Sent: Friday, January 19, 2018 3:16 PM To: Zeng, Star ; Long, Qin ; edk2-devel@lists.01.org Cc: Ye, Ting ; Zeng, Star

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

Qin, How about add more comments to say the tick is calculated from 1970 first second? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Friday, January 19, 2018 3:14 PM > To: Long, Qin ;

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

Ok, got it. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Long, Qin Sent: Friday, January 19, 2018 3:12 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [PATCH] CryptoPkg/BaseCryptLib: Add

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

It's legal to continue the calculation about the seconds elapsed since 1970.01.01 00:00:00. -Original Message- From: Zeng, Star Sent: Friday, January 19, 2018 3:10 PM To: Long, Qin ; edk2-devel@lists.01.org Cc: Ye, Ting ; Zeng, Star

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

What will happen if Time.Year == 1970? :) Thanks, Star -Original Message- From: Long, Qin Sent: Friday, January 19, 2018 3:05 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ye, Ting ; Long, Qin Subject: [PATCH]

[edk2] [PATCH] CryptoPkg/BaseCryptLib: Add error handling for time() wrapper

In time() wrapper implementation, the gRT->GetTime() call may be not available. This patch adds the extra error handling to avoid the potential dead loop. Cc: Star Zeng Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin

[edk2] [PATCH] MdeModulePkg/UsbStorage: Fix "map -r" cannot detect media change

When system boots to Shell without CDROM in the USB CDROM drive, and then user inserts one CDROM with Eltorito file system, "map -r" cannot show the the new Eltorito file system. The root cause is when "map" command probes the media change by calling dummy ReadBlockIo(), UsbMassStorage

Re: [edk2] [PATCH] MdeModulePkg/Core: fix a logic hole in page free

On 1/18/2018 3:38 PM, Jian J Wang wrote: This hole will cause page fault randomly. The root cause is that Guard page, which is just freed back to page pool but not yet cleared not- present attribute, will be allocated right away by internal function CoreFreeMemoryMapStack(). The solution to this

[edk2] [PATCH 15/15] BaseTools: Replace StringIO.StringIO with io.BytesIO

Replace StringIO.StringIO with io.BytesIO to be compatible with python3. This commit also removes "import StringIO" from those python scripts that don't really use it. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [PATCH 08/15] BaseTools: Replace StandardError with Expression

StandardError has been removed from python 3. Replace it with Exception. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Source/Python/UPT/UPT.py | 2 +-

[edk2] [PATCH 02/15] BaseTools: Refactor python print statements

Refactor print statements to be compatible with python 3. Based on "futurize -f libfuturize.fixes.fix_print_with_import" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin

[edk2] [PATCH 03/15] BaseTools: Remove the old python "not-equal"

Replace "<>" with "!=" to be compatible with python3. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/Scripts/BinToPcd.py

[edk2] [PATCH 00/15] BaseTools: One step toward python3

Since python2 will be EOF in 2020, we start to evaluate the impact of the python2 removal. As expected, OMVF building failed the test. It's actually a task noted in the wiki page: https://github.com/tianocore/tianocore.github.io/wiki/Tasks-BaseTools-Python3-Support Maybe it's time to convert the

[edk2] [PATCH 14/15] BaseTools: Adjust old python2 idioms

Based on "futurize -f lib2to3.fixes.fix_idioms" * Change some type comparisons to isinstance() calls: type(x) == T -> isinstance(x, T) type(x) is T -> isinstance(x, T) type(x) != T -> not isinstance(x, T) type(x) is not T -> not isinstance(x, T) * Change "while 1:" into "while

[edk2] [PATCH 13/15] BaseTools: Unify long int and int in python scripts

According to PEP237, long int and int are unified. https://www.python.org/dev/peps/pep-0237/ Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 09/15] BaseTools: Remove types.TypeType

"types.TypeType" is now an alias of the built-in "type" and is not compatible with python 3. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 05/15] BaseTools: Remove tuple parameter in python scripts

According to PEP3113, tuple parameter is removed in python 3. (PEP3113: https://www.python.org/dev/peps/pep-3113/) Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 04/15] BaseTools: Use the python3-range functions

Replace xrange() and range() with the newer range() function Based on "futurize -f libfuturize.fixes.fix_xrange_with_import" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin

[edk2] [PATCH 10/15] BaseTools: Refactor python raise statement

Make "raise" to be compatible with python3. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin --- BaseTools/gcc/mingw-gcc-build.py | 4 ++-- 1 file changed, 2

[edk2] [PATCH 06/15] BaseTools: Remove the deprecated hash_key()

Replace "has_key()" with "in" to be compatible with python3. Based on "futurize -f lib2to3.fixes.fix_has_key" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 07/15] BaseTools: Import reduce() from functools

In python3, reduce() is not a built-in function anymore. Import it from "functools" to be compatible with python 3. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 12/15] BaseTools: Migrate to the new octal literal

Change the octal literals according to PEP3127 https://www.python.org/dev/peps/pep-3127/ Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin ---

[edk2] [PATCH 01/15] BaseTools: Refactor python except statements

Convert "except ... ," to "except ... as" to be compatible with python3. Based on "futurize -f lib2to3.fixes.fix_except" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Gary Lin

[edk2] [PATCH] BaseTools: Fix increment build bug

Issue decription: step 1, build platform X64 step 2, build platform IA32 step 3, build platform X64 step 4, check all ffs files for X64, the content still has IA32 in it Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

Paulo Alcantara writes: >> 3) I am a little surprised on PeCoffSearchImageBase() issue. >> >> We have 4 PeCoffSearchImageBase() call in each arch. DumpImageModuleNames() >> calls twice and DumpStacktrace() calls twice. >> Do you know which specific one triggers the zero address

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

Hi Jiewen, "Yao, Jiewen" writes: > I have some more thought on #3 for your consideration. > > Given the situation that we are doing heap guard feature, a *valid* > EIP address might not be enough to guarantee the address is inside of > an *executable* page. OK. > > I am

Re: [edk2] [RFC v5 0/8] Stack trace support in X64 exception handling

"Yao, Jiewen" writes: Hi Jiewen, Thank you very much for teh review! My comments below: > The 8 patches keep updating 4 files, so I squash them when I review. The > comment below is for the final code, not for a specific patch. > > 1) CpuExceptionCommon.c:

Re: [edk2] Missing FAB_D blobs when building devel-MinnowBoard3-UDK2017 for Leafhill CRB

Cameron: I saw the issue you filed in Bugzilla. That is the best method to track this request. Our team is reviewing the request and will reply there. Thanks ... br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richard...@intel.com -- @intel_brian (Twitter &

Re: [edk2] [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

Hi Daryl, First, sorry for not having RTFM and submitting the patch via github. I was planning to read your workflow during the weekend and re-submit via the mailing list. Second, I am using gcc. I tried gcc 4.8 and 5.2 and with both, my applications using Stdlib badly hang. I dug a bit and

Re: [edk2] [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

Daryl, Thanks for your patches! Have you compiled your changes with CLANG38? In my sandbox (which, admittedly I may have stale CLANG38 compiler options), the second argument must be a VOID* type or the compiler is upset. CLANG can be more strict here than GCC Regards,

Re: [edk2] [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

Marco, Thank you for your submission. Can you please tell me which compiler you are using? Thank you, Daryl McDaniel From: Marco Guerri [mailto:notificati...@github.com] Sent: Wednesday, January 17, 2018 7:22 AM To: tianocore/edk2 Cc: Subscribed

[edk2] [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms.

--- Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes

[edk2] [PATCH edk2-non-osi v1 1/3] Hisilicon D03/D05: Move SasPlatform to edk2-platforms

From: Jason Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

Update SnpPV660Dxe binary to fix network interface order issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: rp-1802-osi-v1 *** BLURB HERE *** Heyi Guo (2): Hisilicon D0x: Fix network interface order issue Hisilicon D0x: Move SnpPlatform to edk2-platforms. Jason Zhang (1): Hisilicon D03/D05: Move

[edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

OsBootLib can create OS option after upgrade firmware. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/D03.dsc | 1 +

[edk2] [PATCH edk2-platforms v1 14/14] Hisilicon D03/D05: Update firmware version to 18.02

Replace the old string with short one. The old one is too long that can not be show integrallty in Setup nemu. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v1 12/14] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM

Add PXM method for Pcie device, HNS device and SAS device. Add STA method for HNS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: hensonwang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v1 10/14] Hisilicon/D03: Replace SP805Watchdog by WatchdogTimer driver.

In SCT test,we find SP805 watchdog driver can't reset when timeout so we use another driver in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: GongChengYa

[edk2] [PATCH edk2-platforms v1 11/14] Hisilicon/D05/ACPI: Add ITS PXM

Add ITS affinity structure in SRAT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++

[edk2] [PATCH edk2-platforms v1 09/14] Hisilicon/D05: Replace SP805Watchdog by WatchdogTimer driver.

In SCT test,we find SP805 watchdog driver can't reset when timeout so we use another driver in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: GongChengYa

[edk2] [PATCH edk2-platforms v1 08/14] Hisilicon/PCIe: Disable PCIe ASPM

From: Yan Zhang In order to replace command line parameter pcie_aspm=off, BIOS needs to disable Pcie Aspm support during Pcie initilization. D03 and D05 do not support PCIe ASPM, so we disable it in BIOS. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v1 06/14] Hisilicon D03/D05: Open SnpPlatform source code

From: Jason Zhang 1. Open driver source code. 2. This code includes network sequence correction solution. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang

[edk2] [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4

modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, indicator to obtain the processor family from the Processor Family 2 field. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option

Modify the feature of BMC set boot option as switching generic BDS. Move main functions to BmcConfigBootLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/D03.dsc

[edk2] [PATCH edk2-platforms v1 01/14] Hisilicon/D05: Add PPTT support

From: Jason Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D05/D05.dsc

[edk2] [PATCH edk2-platforms v1 04/14] Hisilicon D03/D05: Add capsule upgrade support

From: Jason Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo ---

[edk2] [PATCH edk2-platforms v1 00/14] Improve D0x platforms and bug fix

MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit *** BLURB HERE *** Jason Zhang (4): Hisilicon/D05: Add PPTT support Hisilicon D03/D05: Add capsule upgrade support Hisilicon D03/D05: Open SasPlatform source code Hisilicon D03/D05: Open SnpPlatform

[edk2] [PATCH edk2-platforms v1 05/14] Hisilicon D03/D05: Open SasPlatform source code

From: Jason Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo --- Platform/Hisilicon/D03/D03.dsc

[edk2] [PATCH edk2-platforms v1 02/14] Hisilicon D03/D05：Switch to Generic BDS driver

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: Jason Zhang --- Platform/Hisilicon/D03/D03.dsc | 24 +

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix bad boot performance

Reviewed-by: Eric Dong -Original Message- From: Wang, Jian J Sent: Thursday, January 18, 2018 3:39 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Laszlo Ersek Subject: [PATCH] UefiCpuPkg/CpuDxe: fix bad boot performance If

Re: [edk2] [PATCH] MdeModulePkg/Core: fix a logic hole in page free

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wang, Jian J Sent: Thursday, January 18, 2018 3:39 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Zeng, Star Subject: [PATCH]

Re: [edk2] [staging/edk2-test Patch 00/10] MsUnitTestPkg: Add Unit Test Support and sample

Reviewed-by: Sean Brogan -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, December 19, 2017 4:00 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Gao, Liming ;

Re: [edk2] [staging/edk2-test Patch 0/2] MdePkgUnitTest: Add unit test package for MdePkg

Reviewed-by: Sean Brogan -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, December 19, 2017 4:16 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Gao, Liming ;