[edk2] [PATCH edk2-platforms v6 0/2] add platform boot options

Changelog: v6: * Remove redundant definition -- "GRUB_FILE_NAME". v5: * Avoid to merge device path and grub's file path in driver. Merge them directly in DSC file. * Avoid duplicated code to create boot options. * Use goto to handle error condition. v4: * Add BootCount parameter in

[edk2] [PATCH edk2-platforms v6 1/2] Platform/HiKey960: register predefined boot options

Create 4 boot options on HiKey960 platform. They're "Boot from SD", "Grub", "Android Boot" and "Android Fastboot". Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH edk2-platforms v6 2/2] Platform/HiKey: create 4 boot options

Create 4 predefined boot options for HiKey. They're "Boot from SD", "Grub", "Android Boot" and "Android Fastboot". Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

On 26 April 2018 at 00:10, Laszlo Ersek wrote: > Hello Haojian, > > On 04/25/18 06:59, Haojian Zhuang wrote: >> Changelog: >> v5: >> * Avoid to merge device path and grub's file path in driver. >> Merge them directly in DSC file. >> * Avoid duplicated code to create

[edk2] [EDK2]How to do source level debug (OVMF & QEMU & Intel UEFI Development Debugger Tool)

Hi everyone, I know nothing about this source level debug mode so I had read some articles and tried to make this environment,but failed. I do this as I want to observe how SEC phase jump to PEI phase. #1 build ovmf: build -p OvmfPkg/OvmfPkgIa32.dsc -a IA32 -D DEBUG_ON_SERIAL_PORT -D

[edk2] [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when polling

RootBridgeIo.PollMem()/PollIo() originally don't count the IO/MMIO access overhead when delaying. The patch changes the implementation to count the access overhead so that the actually delay equals to user required delay. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: remove OpenSSL version number from OpenSSL-HOWTO.txt

Yes, this was not refreshed at last upgrade. And I agree it's better to remove this statement. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, April 26, 2018 1:58 AM To:

Re: [edk2] Incorrect Author on patch

On 04/25/18 17:02, Evan Lloyd wrote: > Hi Ruiyu. > When we look at the edk2 git log, or GitHub > https://github.com/tianocore/edk2/commit/ee4dc24f57c32a445e7c747396c9bfbd8b221568 > we see that Sami's AcpiView patch shows you as the Author. > I'm not sure what might have caused that (and it is

Re: [edk2] [PATCH] QemuVideoDxe: round up FrameBufferSize to full page

On 04/25/18 16:08, Laszlo Ersek wrote: > (1) Please use the EFI_SIZE_TO_PAGES() macro for rounding up the size. > > (EFI_SIZE_TO_PAGES() takes one UINTN argument, but there's no need for > an explicit cast, because > "EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE.FrameBufferSize" is already UINTN.) Argh,

[edk2] [PATCH] CryptoPkg/OpensslLib: remove OpenSSL version number from OpenSSL-HOWTO.txt

Remove any concrete OpenSSL version numbers from "OpenSSL-HOWTO.txt". That information is out of date and there's no reason for us to refresh it: We now track stable OpenSSL releases via a git submodule. CryptoPkg maintainers push such submodule updates to edk2 that identify the correct stable

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

Hi Ard, Thank you for the series, I confirm it fixes EDK2 boot in Xen guest. Tested-by: Julien Grall Acked-by: Julien Grall Cheers, On 23/04/18 16:00, Ard Biesheuvel wrote: Reinstate the timer mask quirk for Xen that we recently removed under the

Re: [edk2] [PATCH edk2-platforms v5 0/2] add platform boot options

Hello Haojian, On 04/25/18 06:59, Haojian Zhuang wrote: > Changelog: > v5: > * Avoid to merge device path and grub's file path in driver. > Merge them directly in DSC file. > * Avoid duplicated code to create boot options. > * Use goto to handle error condition. > v4: > * Add

[edk2] Incorrect Author on patch

Hi Ruiyu. When we look at the edk2 git log, or GitHub https://github.com/tianocore/edk2/commit/ee4dc24f57c32a445e7c747396c9bfbd8b221568 we see that Sami's AcpiView patch shows you as the Author. I'm not sure what might have caused that (and it is obviously accidental), but it is a little

Re: [edk2] [PATCH v1 10/18] StandaloneMmPkg/HobLib: Add AARCH64 Specific HOB Library for management mode.

Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:15PM +0100, Supreeth Venkatesh wrote: > The Standalone MM environment is initialized during the SEC phase on ARM > Standard Platforms. The MM Core driver implements an entry point module > which is architecture specific and runs prior to the generic core

Re: [edk2] [PATCH v1 09/18] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.

Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:14PM +0100, Supreeth Venkatesh wrote: > This patch implements management mode memory allocation services.The > implementation borrows the MM Core Memory Allocation services as the > primitive for memory allocation instead of using MM System Table >

Re: [edk2] [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path

Hello Ray, On 04/25/18 07:44, Ruiyu Ni wrote: > Today's implementation does an exact device path match to check > whether the device path of a console is in ConIn/ConOut/ErrOut. > But that doesn't work for the USB keyboard. > Because when a platform have multiple USB port, ConIn needs to > carry

Re: [edk2] [PATCH] QemuVideoDxe: round up FrameBufferSize to full page

Hi Gerd, On 04/25/18 14:10, Gerd Hoffmann wrote: > Guests do the same, because the framebuffer is mapped somewhere, which > obviously works with page granularity only. > > When not rounding up to full page size we get messages like this one > (linux kernel): > > efifb: framebuffer at

[edk2] [PATCH] Add QemuIGDHelperDxe

Little driver to setup the OpRegion for Intel vgpu devices. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuIGDHelperDxe/QemuIGDHelper.c | 262 ++ OvmfPkg/OvmfPkgIa32.dsc |

[edk2] [PATCH] QemuVideoDxe: round up FrameBufferSize to full page

Guests do the same, because the framebuffer is mapped somewhere, which obviously works with page granularity only. When not rounding up to full page size we get messages like this one (linux kernel): efifb: framebuffer at 0x8000, using 1876k, total 1875k

Re: [edk2] [PATCH v1 08/18] StandaloneMmPkg/MemLib: AARCH64 Specific instance of memory check library.

Hi Jiewen, On Mon, Apr 16, 2018 at 10:30:55PM +, Yao, Jiewen wrote: > Hi > I don't think this lib is generic, because it hardcode the physical address > bits. > > PhysicalAddressBits = 36; > > For X86 CPU, we get it from CPUID. :-) > > As enhancement, we may put most common C-code logic

[edk2] [Patch] BaseTools: Separate HOST and PREFIX env for GCC tool chain

The crossing GCC compiler may use the different path for make and gcc tool. So, GCC_HOST_BIN is introduced for make path. GCC5_BIN is still kept for gcc path. User needs to set GCC_HOST_BIN besides set GCC5_BIN env if the default make and gcc is not used. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v1 20/27] BaseTools: remove duplicate variable

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 09/27] BaseTools: AutoGen - remove unused variables.

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 27/27] BaseTools: CommonClass - remove unused classes

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 03/27] BaseTools: Share RegEx between files

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 24/27] BaseTools: GenFds - simplify testing for Hex number

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 10/27] BaseTools: Remove extra .keys()

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1

Re: [edk2] [PATCH v1 02/27] BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple compiling

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 07/27] BaseTools: Workspace - refactor GetStructurePcdInfo

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 12/27] BaseTools: remove dict from DscBuildData

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 08/27] BaseTools: AutoGen - remove dictionary populated, but never accessed

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 05/27] BaseTools: Autogen - replace string constants with those from DataType

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 06/27] BaseTools: simplify if call

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 04/27] BaseTools: Workspace - refactor RegEx to minimize multiple compiling

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 01/27] BaseTools: Misc - refactor RegEx to minimize multiple compiling

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:51 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

[edk2] [PATCH] IntelFrameworkModule/LegacyBios: Use reserved memory for legacy data

Certain Legacy USB implementation needs to access legacy data (BDA, etc.) from SMM environment. While currently it's not allowed to access BS memory from SMM after EndofDxe, change the legacy data to use reserved memory type. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH] MdePkg/DevicePathToText: Fix iSCSI.Lun byte order issue

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [edk2] [PATCH v1 21/27] BaseTools: replace string with predefined constant

Should use DT.PLATFORM_COMPONENT_TYPE_LIBRARY_CLASS, because current in the file header it use "import Common.DataType as DT". Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming

Re: [edk2] [PATCH v1 18/27] BaseTools: Replace PCD type strings with predefined constant

GenFdsGlobalVariable.py: should use DataType.TAB_PCDS_FIXED_AT_BUILD format, because it use import Common.DataType as DataType in file header. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: edk2-devel@lists.01.org Cc: Gao,