Re: [edk2] Dynamic Pci configuration devices

Thanks for the detailed answer. if i choose the 2nd approach would it be possible to modify the structrue itself of the pci tree, and not only a specific device number? example: if i add a pci bridge between my board and a graphic card. Thanks, On Tue, May 8, 2018 at 5:47 PM, Laszlo Ersek

Re: [edk2] [patch] BaseTools/VfrCompile: Avoid using uninitialized pointer

Thanks for your test work. I have created a V2 patch which make the code logic more clean. Would you mind to try the V2 patch in your environment? Thanks, Dandan -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, May 9, 2018 10:32 AM To: Bi, Dandan

[edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

V2: Add function _INIT_OPHDR_COND () for variable initialization. Make code logic more clean. Previously _CLEAR_SAVED_OPHDR () is used for variable initialization, and we updated it to clean memory. But _CLEAR_SAVED_OPHDR () is still called for variable initialization. This will cause

Re: [edk2] [patch] BaseTools/VfrCompile: Avoid using uninitialized pointer

On Tue, May 08, 2018 at 07:46:19PM +0800, Dandan Bi wrote: > _CLEAR_SAVED_OPHDR () is used for initialize the variables. > We should not update it to free memory. > It will cause some pointer used before initialization. > This patch is to fix this issue. > > Cc: Eric Dong >

Re: [edk2] [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues

On Tue, May 08, 2018 at 11:50:46AM +, Bi, Dandan wrote: > Yes. We have submitted patch to fix it. Sorry for the inconvenience. > Awesome! Thanks for the quick response :) Gary Lin > Thanks, > Dandan > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

I think that this is a fatal error in EDK2. It basically says, "we are out of stack space." The alternative is: the system hangs in an unexpected way since the stack overflows into other pages. Tim -Original Message- From: edk2-devel On Behalf Of Yao,

Re: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, May 09, 2018 12:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

We discussed internally in Intel. The quick workaround is: use /Gs65536. :-) At the same time, our recommendation is to revisit the code which triggers this error. Why this function need such a big stack? And try to reduce the local stack usage. What is why we still use /Gs32768 as default,

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

Oh, if you are prefering a good implementation, I will be all for that. This was just a 'quick workaround', same as currently done for GCC. I'm actually unsure whether a good implementation is possible with a flat memory model. It will likely be mere luck whether there is enough space free

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

There are some open source implementation: MSVC: https://github.com/ispc/ispc/issues/542 GCC: https://android.googlesource.com/toolchain/gcc/+/b094d6c4bf572654a031ecc4afe675154c886dc5/gcc-4.4.3/gcc/config/i386/chkstk.asm The compiler generated code assumes the stack is enlarged after we can

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

Hey Yao, As far as I am aware, all __chkstk does is access the stack in 4 KB intervals from the current location to the maximum requested location to eventually hit the Windows Guard Page, which then triggers the stack increase. Because I do not know of any equivalent concept in edk2 and the

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

HI Marvin Would you mind to share the information on how you test this update? Per my experience, chkstk not only does the check but also does the real work to allocate more stack. /Gs can be used to indicate the size (/Gs[num] control stack checking calls) We use /Gs32768 by default, see

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

Hey Liming, According to the MSDN documentation, the call will be inserted for a stack usage past a defined threshold - 4 KB for IA32, 8 KB for X64 (source: https://msdn.microsoft.com/en-us/library/ms648426(v=vs.85).aspx). Thanks, Marvin > -Ursprüngliche Nachricht- > Von: Gao, Liming

[edk2] [PATCH 2/2] MdeModulePkg/AcpiPlatformDxe: Consume PlatformAcpiLib.

This patch updates the generic ACPI Platform driver to consume PlatformAcpiLib to allow platform specific updates to the ACPI tables loaded from the configured Firmware Volume. This allows for more platforms to incorporate the generic ACPI Platform driver. Contributed-under: TianoCore

[edk2] [PATCH 1/2] MdeModulePkg: Add PlatformAcpiLib LibraryClass.

PlatformAcpiLib can be consumed by the generic ACPI Platform driver to allow platform specific updates to the ACPI tables loaded from the configured Firmware Volume. This allows for more platforms to incorporate the generic ACPI Platform driver. This commit also provides a NULL implementation of

Re: [edk2] Empty function at BaseCacheMaintenanceLib

Got it! Thanks for the answer Andrew. Rafael Machado Em ter, 8 de mai de 2018 às 12:55, Andrew Fish escreveu: > Rafael, > > I seem to remember those functions are used to manage the cache on a > Harvard architecture caches [1]. > > If you look at

[edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

the "0x" was missing. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/FvImageSection.py | 4 ++-- 1 file changed, 2

Re: [edk2] Empty function at BaseCacheMaintenanceLib

Rafael, I seem to remember those functions are used to manage the cache on a Harvard architecture caches [1]. If you look at InvalidateInstructionCacheRange() you will notice it is used when code gets loaded into memory to keep the data and instruction caches coherent. If the instruction

Re: [edk2] Dynamic Pci configuration devices

On 05/08/18 16:16, Guy Raviv wrote: > Hi all, > > currently in > > \Vlv2DeviceRefCodePkg\AcpiTablesPCAT\HOST_BUS.ASL > > The PCI devices are declared statically. > > i want to make this declaration dynamic - so that the device number can change > > according according to my hardware setup. Is

[edk2] Dynamic Pci configuration devices

Hi all, currently in \Vlv2DeviceRefCodePkg\AcpiTablesPCAT\HOST_BUS.ASL The PCI devices are declared statically. i want to make this declaration dynamic - so that the device number can change according according to my hardware setup. Is it possible? Thanks, Guy

[edk2] Empty function at BaseCacheMaintenanceLib

Hi everyone I have a question. During a research I got to the BaseCacheMaintenanceLib, and noticed that there is a function that is not implemented. The function InvalidateInstructionCache does not have a body, but as far as I could check it's used in some places. Is it ok to have this function

Re: [edk2] OVMF Logo

I'm unclear what you mean by "overlap Windows Logo". Can you provide a screenshot? Thanks : br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richard...@intel.com -- @intel_brian (Twitter & WeChat)

Re: [edk2] [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues

Yes. We have submitted patch to fix it. Sorry for the inconvenience. Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Tuesday, May 8, 2018 5:46 PM To: Bi, Dandan Cc: edk2-devel@lists.01.org;

[edk2] [patch] BaseTools/VfrCompile: Avoid using uninitialized pointer

_CLEAR_SAVED_OPHDR () is used for initialize the variables. We should not update it to free memory. It will cause some pointer used before initialization. This patch is to fix this issue. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] [PATCH] CryptoPkg/CrtLibSupport: add secure_getenv() stub function

On 05/08/18 10:51, Long, Qin wrote: > It's OK for me to add this NULL wrapper. > > Reviewed-by: Long Qin Thank you very much! Commit ee3198e672e2. Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, May 8, 2018 4:21 AM >

Re: [edk2] OVMF Logo

Hi Dmitry, On 05/05/18 12:36, <8B@89 !B5?0=>2 wrote: > Hello! > Is it possible to tune Logo's behavior in OVMF? Now it overlaps > Windows Logo during system boot Hmmm, generally that shouldn't happen; the logo's location is made available to windows via the BGRT (boot graphics resource table)

Re: [edk2] [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues

On Tue, Apr 10, 2018 at 03:54:46PM +0800, Dandan Bi wrote: > Cc: Eric Dong > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > BaseTools/Source/C/VfrCompile/VfrSyntax.g |

Re: [edk2] [PATCH] CryptoPkg/CrtLibSupport: add secure_getenv() stub function

It's OK for me to add this NULL wrapper. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, May 8, 2018 4:21 AM To: edk2-devel-01 Cc: Long, Qin

Re: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver.

Thanks! Please also add what is "Add supports for pyrite 2.0 spec" as detail as possible. Thank you Yao Jiewen > -Original Message- > From: Dong, Eric > Sent: Monday, May 7, 2018 10:50 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org; Wu, Hao A >