[edk2] [patch 1/3] ShellPkg/Dp: make sure memory is freed before exit

2018-05-13 Thread Dandan Bi
Run dp command now: Firstly it will get performance records from FPDT and then parse the DP command. And if encounter invalid parameters, it will exit directly. Thus the performance records got before are invalid. And what's worse is that the memory allocated in getting performance records phase

[edk2] [patch 2/3] ShellPkg/Dp: Initialize summary date when run DP

2018-05-13 Thread Dandan Bi
Issue: When run "dp -s" or ("dp -v") command in shell several times, the summary reuslts are different each time. The root cause is that the previous global data "SummaryData" is not cleaned when the dp command is callled next time. This patch initializes the global data "SummaryData" when the dp

[edk2] [patch 3/3] ShellPkg/Dp: Make the help info align with code

2018-05-13 Thread Dandan Bi
Remove -T, -P, -h flags in the help info of DP to align with current code implementation. Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

Re: [edk2] Enabling network interface for Realtek8168 chip

2018-05-13 Thread Richardson, Brian
The driver (.efi file) needs to be included in the EDK II project FDF file to be properly integrated into the binary firmware image. There is a good example of this in the MinnowBoard Max/Turbot project.

[edk2] [PATCH edk2-platforms v4 5/6] Platform/HiKey: do basic initialization on hikey

2018-05-13 Thread Haojian Zhuang
Do some basic initialization on HiKey platform, such as pin setting, regulators and making peripherals out of reset mode. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian

[edk2] [PATCH edk2-platforms v4 6/6] Platform/HiKey: enable virtual keyboard

2018-05-13 Thread Haojian Zhuang
Enable virtual keyboard on HiKey platform. It detects the pattern in memory and GPIO pin setting, and simulates them into virtual key. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH edk2-platforms v4 3/6] Platform/HiKey960: enable virtual keyboard

2018-05-13 Thread Haojian Zhuang
Enable virtual keyboard on HiKey960 platform. It checks two conditions, such as pattern in memory and GPIO pin setting. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang

[edk2] [PATCH v4 0/6] enable virtual keyboard

2018-05-13 Thread Haojian Zhuang
Changelog: v4: * Fix hard-coding value. * Remove unused functions. v3: * Remove ADC and boardid, since it's not really used yet. * Add more comments. v2: * Split HiKeyDxe & HiKey960Dxe into smaller patches. * Replace hardcoding register with macro. v1: * Enable GPIO driver. *

[edk2] [PATCH edk2-platforms v4 1/6] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-05-13 Thread Haojian Zhuang
Add gpio platform driver to enable GPIO in HiKey960 platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---

[edk2] [PATCH edk2-platforms v4 4/6] Platform/Hisilicon/HiKey: add gpio platform driver

2018-05-13 Thread Haojian Zhuang
Add gpio platform driver to enable GPIO in HiKey platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---

[edk2] [PATCH edk2-platforms v4 2/6] Platform/HiKey960: do basic initialization

2018-05-13 Thread Haojian Zhuang
Do some basic initliazation on peripherals, such as pins and regulators. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---

Re: [edk2] Enabling network interface for Realtek8168 chip

2018-05-13 Thread Anatol Pomozov
Awesome, thank you Brian! On Sun, May 13, 2018 at 7:42 PM, Richardson, Brian wrote: > You can try the UEFI UNDI driver available for download from Realtek's > website: > > http://www.realtek.com/Downloads/downloadsView.aspx?Langid=1=13=5=5=4=3=fa=1 I contacted

Re: [edk2] Enabling network interface for Realtek8168 chip

2018-05-13 Thread Richardson, Brian
You can try the UEFI UNDI driver available for download from Realtek's website: http://www.realtek.com/Downloads/downloadsView.aspx?Langid=1=13=5=5=4=3=fa=1 Thanks ... br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richard...@intel.com -- @intel_brian

Re: [edk2] [PATCH v2 1/2] MdeModulePkg Variable: Fix a corner case issue about setting a variable

2018-05-13 Thread Zeng, Star
Thanks for the contribution. Reviewed-by: Star Zeng to the patch series. And push the patches to d741d1419350dc4ae868d4a9396f9da33a3416a0 and 989f7a2cf0e27123fda5ca538b15832e115e0f4e. Thanks, Star -Original Message- From: edk2-devel

[edk2] [Patch] BaseTools: Enhance error message when file is not exist for Gensec

2018-05-13 Thread Yonghong Zhu
When the file is not exist in workspace or packages path, current Gensec tool doesn't report exactly error message. FILE FV_IMAGE = -4CF1-42D8-A0C3-B3F60779dF4D { SECTION GUIDED A7717414-C616-4977-9420-844712A735BF { SECTION FV_IMAGE = TestPkg/Test.fd } } Contributed-under:

Re: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files

2018-05-13 Thread Laszlo Ersek
On 05/13/18 16:31, Liming Gao wrote: > NASM has replaced ASM and S files. > Rmove ASM from all modules. > Remove S files from the drivers only. > After NASM is updated, S files can be removed from Library. The patch looks good to me. I suggest a few commit message updates: (1) If I remember

[edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files

2018-05-13 Thread Liming Gao
NASM has replaced ASM and S files. Rmove ASM from all modules. Remove S files from the drivers only. After NASM is updated, S files can be removed from Library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

[edk2] [Patch 1/5] IntelFrameworkModulePkg: Remove X86 ASM and S files

2018-05-13 Thread Liming Gao
NASM has replaced ASM and S files. Rmove ASM from all modules. Remove S files from the drivers only. After NASM is updated, S files can be removed from Library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

[edk2] [Patch 2/5] MdeModulePkg: Remove X86 ASM and S files

2018-05-13 Thread Liming Gao
NASM has replaced ASM and S files. Rmove ASM from all modules. Remove S files from the drivers only. After NASM is updated, S files can be removed from Library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

[edk2] [Patch 4/5] SourceLevelDebugPkg: Remove X86 ASM and S files

2018-05-13 Thread Liming Gao
NASM has replaced ASM and S files. Rmove ASM from all modules. Remove S files from the drivers only. After NASM is updated, S files can be removed from Library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

[edk2] [Patch 0/5] Remove X86 ASM and S files

2018-05-13 Thread Liming Gao
For IA32 and X64, NASM has replaced ASM and S files. Rmove ASM from all modules. Remove S files from the drivers only. After NASM is updated, S files can be removed from Library. Liming Gao (5): IntelFrameworkModulePkg: Remove X86 ASM and S files MdeModulePkg: Remove X86 ASM and S files

[edk2] Enabling network interface for Realtek8168 chip

2018-05-13 Thread Anatol Pomozov
Hello I have a HP Chromebox (codename "zako") that is a small-form factor nice x86 computer useful for experiments. I installed firmware from Matt Davo - the firmware is Coreboot + UEFI payload. UEFI compiled from this sourcecode fork https://github.com/MattDevo/edk2 At my cromebox I have an

Re: [edk2] reasoning beehind prohibiting VFP/NEON on AArch32

2018-05-13 Thread Michael Zimmermann
I looked at ARMs TimerDxe and saw that mTimerNotifyFunction is called with TPL_HIGH_LEVEL but didn't realize that RestoreTPL would call all pending events. Thank you for your help. On Sun, May 13, 2018 at 1:39 PM Ard Biesheuvel wrote: > On 13 May 2018 at 12:58,

Re: [edk2] reasoning beehind prohibiting VFP/NEON on AArch32

2018-05-13 Thread Ard Biesheuvel
On 13 May 2018 at 12:58, Michael Zimmermann wrote: >> No, the other way around. You should raise the TPL to TPL_HIGH_LEVEL >> to prevent being interrupted by something that may corrupt the NEON >> registers. > But isn't that only necessary if you assume that

Re: [edk2] reasoning beehind prohibiting VFP/NEON on AArch32

2018-05-13 Thread Michael Zimmermann
> No, the other way around. You should raise the TPL to TPL_HIGH_LEVEL > to prevent being interrupted by something that may corrupt the NEON > registers. But isn't that only necessary if you assume that interrupt-handlers use VFP registers? afaik on ARM wrote: > On 13 May 2018 at 11:48, Michael

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-13 Thread Ard Biesheuvel
On 9 May 2018 at 22:17, Roman Bacik wrote: > I will upload v2 with the corrected subject - add package name > MdeModulePkg/Bus > . > I don't think this is the correct approach. Please use the address translation support that has been added recently to PciHostBridgeDxe

Re: [edk2] reasoning beehind prohibiting VFP/NEON on AArch32

2018-05-13 Thread Ard Biesheuvel
On 13 May 2018 at 11:48, Michael Zimmermann wrote: > So basically using them should be safe as long as you're in > EfiGetCurrentTpl() < TPL_HIGH_LEVEL, right? No, the other way around. You should raise the TPL to TPL_HIGH_LEVEL to prevent being interrupted by something

Re: [edk2] reasoning beehind prohibiting VFP/NEON on AArch32

2018-05-13 Thread Ard Biesheuvel
On 12 May 2018 at 23:11, Michael Zimmermann wrote: > For AArch32 the spec says in 2.3.5.3: >> Floating point, SIMD, vector operations and other instruction set > extensions must not > be used. > > For AArch64 the spec says in 2.3.6.4: >> Floating point and SIMD