Re: [edk2] [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO

2018-07-06 Thread Laszlo Ersek
On 07/06/18 17:00, Brijesh Singh wrote: > The Qemu flash range is marked as 'system ram' in EFI runtime memmap > but it is actually an IO address. The patch series updates the > EFI runtime memmap to add this range as Memory Mapped IO address. > > Changes since v3: > - minor changes to address

Re: [edk2] [PATCH v3 0/3] OvmfPkg: mark flash memory range as MMIO

2018-07-06 Thread Brijesh Singh
On 07/06/2018 09:01 AM, Laszlo Ersek wrote: On 07/05/18 21:12, Brijesh Singh wrote: The Qemu flash range is marked as 'system ram' in EFI runtime memmap but it is actually an IO address. The patch series updates the EFI runtime memmap to add this range as Memory Mapped IO address. Changes

Re: [edk2] question about uefi shell pipe.

2018-07-06 Thread krishnaLee
Hi,All: may be I should reply this to EDK2 group,I had attached my file again. After many test,my right key of "ls | grep -trim-last 0 | grep -trim-last 0" is: 1,before pipe out the buffer,trim off all in-visible wchars at end of this buffer, (the trimed of wchar is "like ASCII's range

[edk2] [PATCH v4 3/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is active

2018-07-06 Thread Brijesh Singh
AmdSevDxe maps the flash memory range with C=0, but SetMemorySpaceAttributes() unconditionally resets the C-bit to '1'. Lets restore the mapping back to C=0. Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Cc: Justen Jordan L Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [PATCH v4 2/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM build

2018-07-06 Thread Brijesh Singh
In the SMM build, only an SMM driver is using the address range hence we do not need to expose the flash MMIO range in EFI runtime mapping. Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Cc: Justen Jordan L Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v4 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO

2018-07-06 Thread Brijesh Singh
The flash memory range is an IO address and should be presented as Memory Mapped IO in EFI Runtime mapping. This information can be used by OS when mapping the flash memory range. It is especially helpful in SEV guest case, in which IO addresses should be mapped as unencrypted. If memory region

[edk2] [PATCH v4 0/3] OvmfPkg: mark flash memory range as MMIO

2018-07-06 Thread Brijesh Singh
The Qemu flash range is marked as 'system ram' in EFI runtime memmap but it is actually an IO address. The patch series updates the EFI runtime memmap to add this range as Memory Mapped IO address. Changes since v3: - minor changes to address Laszlo's review feedback. Changes since v2: - added

Re: [edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: Update batch file to call python.exe

2018-07-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Thursday, July 5, 2018 11:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH edk2-platforms\devel-MinPlatform]

Re: [edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report

2018-07-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Thursday, July 5, 2018 11:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH edk2-platforms\devel-MinPlatform]

Re: [edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: update ReadMe.md to correct branch name

2018-07-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Thursday, July 5, 2018 11:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH edk2-platforms\devel-MinPlatform]

Re: [edk2] [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override

2018-07-06 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Thursday, July 5, 2018 11:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: > Remove unnecessary Link16 and IASL override > >

Re: [edk2] [PATCH v3 0/3] OvmfPkg: mark flash memory range as MMIO

2018-07-06 Thread Laszlo Ersek
On 07/05/18 21:12, Brijesh Singh wrote: > The Qemu flash range is marked as 'system ram' in EFI runtime memmap > but it is actually an IO address. The patch series updates the > EFI runtime memmap to add this range as Memory Mapped IO address. > > Changes since v2: > - added cover letter and

[edk2] [PATCH v4] MdePkg/BaseLib: Add bit field population calculating methods

2018-07-06 Thread Tomas Pilar (tpilar)
Hopefully this should tidy the conversion warnings. Add 32-bit and 64-bit functions that count number of set bits in a bitfield using a divide-and-count method. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tomas Pilar Cc: Liming Gao Cc: Michael D Kinney ---

Re: [edk2] [PATCH v3] MdePkg/BaseLib: Add bit field population calculating methods

2018-07-06 Thread Tomas Pilar (tpilar)
Apologies, I usually compile with GCC49 since I work on linux. Respinning now. Cheers Tom On 05/07/18 15:07, Gao, Liming wrote: > warning C4244 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v3 3/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is active

2018-07-06 Thread Laszlo Ersek
On 07/05/18 21:12, Brijesh Singh wrote: > AmdSevDxe maps the flash memory range with C=0, but > SetMemorySpaceAttributes() unconditionally resets the C-bit to '1'. Lets > restore the mapping back to C=0. > > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: Justen Jordan L >

Re: [edk2] [PATCH v3 2/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM build

2018-07-06 Thread Laszlo Ersek
On 07/06/18 13:35, Laszlo Ersek wrote: > On 07/05/18 21:12, Brijesh Singh wrote: >> In the SMM build, only an SMM driver is using the address range hence we >> do not need to expose the flash MMIO range in EFI runtime mapping. >> >> Cc: Ard Biesheuvel >> Cc: Anthony Perard >> Cc: Julien Grall

Re: [edk2] [PATCH v3 2/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM build

2018-07-06 Thread Laszlo Ersek
On 07/05/18 21:12, Brijesh Singh wrote: > In the SMM build, only an SMM driver is using the address range hence we > do not need to expose the flash MMIO range in EFI runtime mapping. > > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: Justen Jordan L > Cc: Laszlo Ersek >

Re: [edk2] [PATCH v3 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO

2018-07-06 Thread Laszlo Ersek
On 07/05/18 21:12, Brijesh Singh wrote: > The flash memory range is an IO address and should be presented as Memory > Mapped IO in EFI Runtime mapping. This information can be used by OS > when mapping the flash memory range. > > It is especially helpful in SEV guest case, in which IO addresses

Re: [edk2] [PATCH 1/1] MdeModulePkg/DisplayEngineDxe: Fix small InitializeDisplayEngine leak

2018-07-06 Thread Zeng, Star
Reviewed-by: Star Zeng And pushed patch at 9090c8b533013078c6df773e128070c76d917830. Thanks, Star -Original Message- From: Bi, Dandan Sent: Friday, July 6, 2018 4:11 PM To: Thomas Palmer ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH 1/1]

Re: [edk2] [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT

2018-07-06 Thread Thomas Abraham
On Wed, Jul 4, 2018 at 6:34 PM, AlexeiFedorov wrote: > From: Alexei Fedorov > > Juno's DSDT contains 2 PLPI packages in Clusters #0 and #1 and > _OSC method reports support for platform coordinated mode only. > According to the description of LevelID field in > ACPI 6.2 Errata A Specification

Re: [edk2] [PATCH 1/1] MdeModulePkg/DisplayEngineDxe: Fix small InitializeDisplayEngine leak

2018-07-06 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas Palmer Sent: Wednesday, July 4, 2018 12:46 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: [edk2] [PATCH 1/1]

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: update ReadMe.md to correct branch name

2018-07-06 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- ReadMe.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReadMe.md b/ReadMe.md index 9de6493..5bcdd1d 100644 --- a/ReadMe.md +++ b/ReadMe.md @@ -32,7 +32,7 @@ edk2-non-osi

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: Update batch file to call python.exe

2018-07-06 Thread Liming Gao
Use python.exe from PYTHON_HOME Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/bld.bat | 2 +- .../Tools/Fsp/RebaseAndPatchFspBinBaseAddress.py | 7 ---

[edk2] [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report

2018-07-06 Thread Liming Gao
PCD value in build report shows HEX and DEC both. PatchFv tool only requires one value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- Platform/Intel/MinPlatformPkg/Tools/PatchFv/PatchBfv.py | 2 +-

[edk2] [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override

2018-07-06 Thread Liming Gao
Link16 is not used any longer. Remove the checker for it. IASL path is not required to be override. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- .../BoardMtOlympus/PlatformPkgBuildOption.dsc| 2 +-

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Fix small LoadOptionToVariable leak

2018-07-06 Thread Zeng, Star
Pushed at 4d76bbcce62e3b972cd226e5f0e43d21db48a3f7. Thanks, Star -Original Message- From: Zeng, Star Sent: Friday, July 6, 2018 3:30 PM To: Thomas Palmer ; edk2-devel@lists.01.org Cc: Dong, Eric ; gar...@hpe.com; joseph.shiffl...@hpe.com; Zeng, Star Subject: RE: [PATCH 1/1]

Re: [edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in FreePciDevice

2018-07-06 Thread Zeng, Star
Hi Thomas, Basically, I agree with this patch as PciIoDevice->BusNumberRanges equals Configuration from PciResAlloc->StartBusEnumeration, and according to PI spec "Because the size of ACPI resource descriptors is not fixed, StartBusEnumeration() is responsible for allocating memory for the

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Fix small LoadOptionToVariable leak

2018-07-06 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Thomas Palmer [mailto:thomas.pal...@hpe.com] Sent: Wednesday, July 4, 2018 12:41 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star ; gar...@hpe.com; joseph.shiffl...@hpe.com; Thomas Palmer Subject: [PATCH 1/1]