[edk2] [Patch] Build Spec: Add rules for structure pcd display in the report

2018-07-31 Thread Yonghong Zhu
Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 13_build_reports/136_global_pcd_section.md | 32 +- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Stripped square brackets in IPv6 expressed HostName.

2018-07-31 Thread Fu, Siyuan
OK, the patch is good with me. Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, August 1, 2018 10:42 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Laszlo Ersek > Subject: RE: [Patch] NetworkPkg/HttpDxe: Stripped square brackets in IPv6

Re: [edk2] [Patch] [UDK2017] SecurityPkg OpalPasswordSupportLib: Add check to avoid potential buffer overflow.

2018-07-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Dong, Eric > Sent: Wednesday, August 1, 2018 10:33 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: RE: [edk2] [Patch] [UDK2017] SecurityPkg OpalPasswordSupportLib: > Add check to avoid potential

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Stripped square brackets in IPv6 expressed HostName.

2018-07-31 Thread Wu, Jiaxin
Hi Siyuan, Even we have one lib for us to get the IPv6 address, I still prefer to use the patch did, because the format returned from the HttpUrlGetIp6 is EFI_IPv6_ADDRESS, we have to transform it to CHAR8, which means we also need another lib included here to do that. Actually, the patch is

Re: [edk2] [Patch] [UDK2017] SecurityPkg OpalPasswordSupportLib: Add check to avoid potential buffer overflow.

2018-07-31 Thread Dong, Eric
Hi Hao & Jiewen, This patch has been verified by the original reporter, also pass regression test done by myself. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Tuesday, July 31, 2018 1:16 PM > To:

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Stripped square brackets in IPv6 expressed HostName.

2018-07-31 Thread Fu, Siyuan
Hi, Jiaxin The HttpLib already has HttpUrlGetIp6() for this. BestRegards Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, August 1, 2018 9:55 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Laszlo > Ersek ; Wu, Jiaxin > Subject: [Patch]

[edk2] [Patch] NetworkPkg/HttpDxe: Stripped square brackets in IPv6 expressed HostName.

2018-07-31 Thread Jiaxin Wu
In URI, the colon (:) is used to terminate the HostName path before a port number. However, if HostName is expressed as IPv6 format, colon characters in IPv6 addresses will conflict with the colon before port number. To alleviate this conflict in URI, the IPv6 expressed HostName are enclosed in

Re: [edk2] [PATCH] BaseTools: Use pickle to replace cPickle

2018-07-31 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, July 31, 2018 8:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: Use pickle

Re: [edk2] [PATCH] BaseTools: remove unused import thread

2018-07-31 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, July 31, 2018 8:21 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] BaseTools: remove

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-07-31 Thread Ard Biesheuvel
On 31 July 2018 at 22:56, Leif Lindholm wrote: > On Tue, Jul 17, 2018 at 02:05:45AM +, Chris Co wrote: >> This debug library provides support for importing symbols to >> debug using Lauterbach. >> >> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib > > I'm not seeing any difference

Re: [edk2] [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

2018-07-31 Thread Leif Lindholm
On Tue, Jul 17, 2018 at 02:05:45AM +, Chris Co wrote: > This debug library provides support for importing symbols to > debug using Lauterbach. > > Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib I'm not seeing any difference between this one and the original other than the addition of

Re: [edk2] [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg

2018-07-31 Thread Leif Lindholm
On Tue, Jul 17, 2018 at 02:05:43AM +, Chris Co wrote: > MsPkg is a collection of libraries and drivers that are specific > to supporting Windows IoT Core but are not Platform/Silicon specific. Minor comments inline. > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney >

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver

2018-07-31 Thread Leif Lindholm
Hi Chris, On Tue, Jul 17, 2018 at 02:05:42AM +, Chris Co wrote: > This SdMmc driver adds support to boot Windows from SD and eMMC. > It implements RPMB protocol support for eMMC, unique device path > creation for each slot on the SD bus, high speed modes, > eMMC bus width auto-detection, and

[edk2] [Patch] BaseTools/BinToPcd: Fix Python 2.7.x compatibility issue

2018-07-31 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=1042 Convert Buffer to type bytearray before converting to a string of hex byte values so the type of items in Buffer is consistent for both Python 2.7.x and Python 3.x. Cc: YanYan Sun Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore

Re: [edk2] :Build error

2018-07-31 Thread Jose Trujillo
Here is the file attached Liming... ‐‐‐ Original Message ‐‐‐ On July 31, 2018 3:52 PM, Gao, Liming wrote: > Could you attach >

[edk2] [PATCH] BaseTools: Use pickle to replace cPickle

2018-07-31 Thread Yonghong Zhu
From: Yunhua Feng Use pickle to replace cPickle because of python3 removed cPickle Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/Common/Misc.py | 6 +++--- 1 file changed, 3 insertions(+), 3

[edk2] [PATCH] BaseTools: remove unused import thread

2018-07-31 Thread Yonghong Zhu
From: Yunhua Feng remove unused import thread Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/Common/Misc.py | 1 - 1 file changed, 1 deletion(-) diff --git

[edk2] [PATCH] BaseTools: Guid.xref doesn't specify the correct GUID value for Driver

2018-07-31 Thread Yonghong Zhu
From: Yunhua Feng In DSC, we can define the driver with the different FILE GUID. So, this driver name and its FILE GUID should also be listed in Build output Guid.xref. But now, Guid.xref still lists the driver MODULE_GUID. The case in Platform.dsc:

Re: [edk2] [PATCH] SignedCapsulePkg SystemFirmwareReportDxe: Try LocateProtocol

2018-07-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, July 31, 2018 8:58 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Zeng, Star > Subject: [edk2] [PATCH]

Re: [edk2] :Build error

2018-07-31 Thread Gao, Liming
Which tool chain is used? What is CBSDK? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jose > Trujillo > Sent: Monday, July 30, 2018 9:26 PM > To: edk2-devel@lists.01.org > Subject: [edk2] :Build error > > Dear Tianocore developers: > > I