Re: [edk2] [edk2-test] SctPkg compilation is failing

2019-03-18 Thread Meenakshi Aggarwal
Hi Supreeth, I tried the step suggested by you, but still facing error: meenakshi@uefi-OptiPlex-790:~/SCT/edk2/SctPkg$ export EDK_TOOLS_PATH="/home/meenakshi/SCT/edk2/BaseTools" meenakshi@uefi-OptiPlex-790:~/SCT/edk2/SctPkg$ rm -f $EDK_TOOLS_PATH/Source/C/bin/GenBin

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-18 Thread Ming Huang
On 3/19/2019 10:25 AM, Wu, Hao A wrote: >> -Original Message- >> From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >> Sent: Monday, March 18, 2019 8:43 PM >> To: Ming Huang >> Cc: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Zeng, Star; Dong, >> Eric; Ni, Ray;

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-18 Thread Ming Huang
On 3/18/2019 8:42 PM, Leif Lindholm wrote: > +MdeModulePkg maintainers (you added MdePkg maintainers to cc) > > This looks like an improvement to me. > > Am I correct in guessing this behaviour refers to some specific corner > case of a USB CDROM emulated from a BMC? Yes, I found this issue

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-18 Thread Wu, Hao A
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, March 18, 2019 8:43 PM > To: Ming Huang > Cc: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org; Zeng, Star; Dong, > Eric; Ni, Ray; dann.fraz...@canonical.com; ard.biesheu...@linaro.org;

Re: [edk2] [Patch] MdeModulePkg/PiSmmCore: Control S3 related functionality with flag.

2019-03-18 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Tuesday, March 05, 2019 10:07 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] MdeModulePkg/PiSmmCore: Control S3 related > functionality with flag. > >

Re: [edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Size in EraseBlocks() is in bytes

2019-03-18 Thread Supreeth Venkatesh
On Mon, 2019-03-11 at 13:29 +0800, Eric Jin wrote: > The erase size used in current test is blocks number, Please reword. Block number or number of blocks? > and should be corrected to the size in bytes to be > erased. According to UEFI spec, it must be a multiple > of the physical block size of

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-18 Thread Jordan Justen
On 2019-03-18 11:25:54, Kinney, Michael D wrote: > Hi Jordan, > > No proposed changes to the Signed-off-by tags. I think it's good to continue with the Signed-off-by tags. One slight concerns I have is what Signed-off-by becomes a little vague with your proposed change. Previously it meant that

Re: [edk2] [edk2-test][Patch 1/1] uefi-sct:SctPkg:Fix underflow in EraseBlocks test

2019-03-18 Thread Supreeth Venkatesh
On Mon, 2019-03-11 at 16:08 +0800, Eric Jin wrote: > The test case does not handle properly when > the 'EraseLengthGranularity' field of an Erase > Block Protocol instance is 1(SD device). > The Size parameter will underflow and become a > very large value, cause to exceed the last LBA. > The fix

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-18 Thread Jordan Justen
On 2019-03-18 08:09:36, Gao, Liming wrote: > Jordan: > Coding style document CCS_2_1_Draft.pdf 5.1 General Rules, 5.1.1 > Lines shall be 120 columns, or less. Preferably, limit line > lengths to 80 columns or less. So, I don't think the line length > bigger than 80 and less than 120

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-18 Thread Kinney, Michael D
Hi Jordan, No proposed changes to the Signed-off-by tags. If you have a proposal, please provide an RFC or bring to the monthly EDK II community meeting. This series is focused on the license change, the use of SPDX identifiers, and removing the Contributed-under tag from commit messages. I

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-18 Thread Kinney, Michael D
Laszlo, Thanks for the feedback. I will entered a few BZs based on this feedback and will provide a V2 version of the content. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, March 14, 2019 3:56 AM >

Re: [edk2] [edk2-test] SctPkg compilation is failing

2019-03-18 Thread Supreeth Venkatesh
Changing Subject line to append [edk2-test]. If the source code for edk2 and/or edk2-test is stale, this may happen, as GenBin is no longer a pre-built binary but it is getting built from the source. Please try this with the existing build and recompile. rm -f

[edk2] [PATCH 0/2] DynamicTablesPkg: add package .dsc

2019-03-18 Thread Leif Lindholm
Having a top-level .dsc simplifies automated builds of core modules in isolation from any final platforms. As demonstrated by 1/2, discovered while putting the .dsc together. Leif Lindholm (2): DynamicTablesPkg: correct LibraryClass dependencies for Arm/DBG2 DynamicTablesPkg: add package .dsc

[edk2] [PATCH 1/2] DynamicTablesPkg: correct LibraryClass dependencies for Arm/DBG2

2019-03-18 Thread Leif Lindholm
This patch changes the stated dependency in AcpiDbg2LibArm.inf from currently listed SerialPortLib to actually required PL011UartLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf | 2

[edk2] [PATCH 2/2] DynamicTablesPkg: add package .dsc file

2019-03-18 Thread Leif Lindholm
Having a top-level .dsc makes it easier to perform standalone build tests of the core code, so add one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- DynamicTablesPkg/DynamicTablesPkg.dsc | 44 +++ 1 file changed, 44

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-18 Thread Gao, Liming
Jordan: Coding style document CCS_2_1_Draft.pdf 5.1 General Rules, 5.1.1 Lines shall be 120 columns, or less. Preferably, limit line lengths to 80 columns or less. So, I don't think the line length bigger than 80 and less than 120 violates coding style documents. We should update wiki

[edk2] [RFC PATCH] MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc

2019-03-18 Thread Leif Lindholm
Commit 05fd2a926833 ("MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox") added a dependency on LockBoxLib to NvmExpressPei, causing builds using MdeModulePkg.dsc to fail on architectures other than IA32/X64 with missing reference to

[edk2] [PATCH v4] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-18 Thread nkvangup
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 register only when SMM on-demand paging support is enabled in 64 bit operation mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vanguput Narendra K Cc: Eric Dong

[edk2] [PATCH] Vlv2TbltDevicePkg: SPI lock

2019-03-18 Thread Zailiang Sun
https://vthsd.intel.com/hsd/tiano/tracker/default.aspx?tracker_id=221549 Set protection bit such as BCR, PR0, PR1 and HSFS bits in SPI registers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zailiang Sun Cc: David Wei Cc: Yi Qian Cc: Michael Kinney ---

Re: [edk2] [MdeModulePkg/Library v1 1/1] MdeModulePkg/UefiBootManangerLib: Fix exception issue

2019-03-18 Thread Leif Lindholm
+MdeModulePkg maintainers (you added MdePkg maintainers to cc) This looks like an improvement to me. Am I correct in guessing this behaviour refers to some specific corner case of a USB CDROM emulated from a BMC? On Mon, Feb 25, 2019 at 05:10:52PM +0800, Ming Huang wrote: > The system

Re: [edk2] Regarding PXE boot NACK error.

2019-03-18 Thread MohammadYounasKhan.P
Is there anybody who knows about it and help me on this? Thank you, Younas. -Original Message- From: edk2-devel On Behalf Of Pathan, MohammadYounasKhan Sent: Sunday, March 10, 2019 11:19 PM To: edk2-devel@lists.01.org Cc: S, Shekar Babu; Poosapalli, Karunakar; Raju, SriramKumar

[edk2] [PATCH v3] UefiCpuPkg\CpuSmm: Save & restore CR2 on-demand paging in SMM

2019-03-18 Thread nkvangup
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593 For every SMI occurrence, save and restore CR2 register only when SMM on-demand paging support is enabled in 64 bit operation mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vanguput Narendra K Cc: Eric Dong

[edk2] SctPkg compilation is failing

2019-03-18 Thread Meenakshi Aggarwal
Hi, I followed below steps to compile SctPkg: Refer to SctPkg/Tools/Source/GenBin/HowTo.txt to gen the GenBin and copy it to Home/Dev/SctWorkspace/Bin/BaseTools/BinWrappers/PosixLike Build Instructions for UEFI SCTII AARCH64 (Linux) 1) mkdir "sct_workspace" 2) cd sct_workspace 3) git

Re: [edk2] [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib

2019-03-18 Thread Jordan Justen
On 2019-03-17 17:14:40, Gao, Zhichao wrote: > > -Original Message- > > From: Justen, Jordan L > > Sent: Friday, March 15, 2019 2:16 PM > > > > On 2019-03-14 22:17:33, Zhichao Gao wrote: > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 > > > > > > Add a new api DebugVPrint