Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

I propose to rev the version of the library + 0.1 in the INF file? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, December 01, 2015 9:54 PM > To:

Re: [edk2] [Patch 0/2] Fix Shell mm command bugs

For the series (I made a tiny comment on the INF in the other patch email) Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, December 01, 2015 9:54 PM > To:

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Wednesday, December 02, 2015 2:17 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jabe

Re: [edk2] MdePkg: DebugAssert enhancement

r 01, 2015 3:26 PM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Gao, > Liming <liming@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: Re: [edk2] MdePkg: DebugAssert enhancement > Importance: High > > M

Re: [edk2] Where do I find the system table address for an EFI app ?

Its passed as a parameter to the "main" function when your app starts. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shubha Ramani > Sent: Tuesday, December 01, 2015 8:35 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] Where

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

Not sure how to RB this ... it's fine with me to commit it. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 23, 2015 5:22 AM > To: Leif Lindholm <leif.lindh...@linaro.org> > Cc: edk2-devel@lists.01.org; Car

Re: [edk2] [PATCH] ShellPkg: Corrected CatSPrint usage to prevent memory leaks.

Good catch. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cecil Sheng > Sent: Tuesday, November 17, 2015 4:19 PM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng >

Re: [edk2] [PATCH] PerformancePkg/Dp_App: Support dumping cumulative data

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, November 09, 2015 6:54 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] PerformancePkg/Dp_App: Support

Re: [edk2] [PATCH 4/4] AppPkg/Python-2.7.10: AppPkg.dsc, pyconfig.h, PyMod-2.7.10 (resend)

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daryl McDaniel > Sent: Saturday, November 07, 2015 11:46 AM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car

Re: [edk2] [PATCH] ShellPkg: Don't strip positional parameters of quotation marks.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Friday, November 06, 2015 12:06 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> >

[edk2] [PATCH] ShellBinPkg: Update INF with Protocols section

Shumin, Can you review this please? ShellBinPkg: Update INF with Protocols section Add missing section for the binary shell INF file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey ___

Re: [edk2] [PATCH v3 2/2] ShellPkg/UefiDpLib: Support dumping cumulative data

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Tuesday, November 03, 2015 5:01 PM > To: Cinnamon Shia ; edk2-devel@lists.01.org > Subject: Re:

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix a DP cumulative data issue

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Tuesday, November 03, 2015 5:01 PM > To: Cinnamon Shia ; edk2-devel@lists.01.org > Subject: Re:

Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix a DP cumulative data issue

> -Original Message- > From: Zeng, Star > Sent: Monday, November 02, 2015 7:13 PM > To: Carsey, Jaben <jaben.car...@intel.com>; Cinnamon Shia > <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fi

Re: [edk2] [PATCH] ShellPkg UefiDpLib: Use correct string length for the input UnicodeBuffer

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Monday, November 02, 2015 8:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH] ShellPkg UefiDpLib: Use corre

Re: [edk2] [Patch v2 1/1] AppPkg/Python remove improper characters from pyconfig.h

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Tuesday, November 03, 2015 10:37 AM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; > Bjorge, Erik

Re: [edk2] [Patch 1/1] AppPkg/Python remove improper characters from pyconfig.h

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Bjorge, Erik C > Sent: Tuesday, November 03, 2015 10:43 AM > To: Daryl McDaniel <edk2-li...@mc2research.org>; edk2-devel@lists.01.org; > Carsey, Jaben <jaben.car...@intel.com>;

Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix a DP cumulative data issue

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, November 02, 2015 1:12 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix a

Re: [edk2] [PATCH 2/2] ShellPkg/UefiDpLib: Support dumping cumulative data

Code looks good. I can't tell must about your UNI file change. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, November 02, 2015 1:12 AM > To:

Re: [edk2] [PATCH v2] MdeModulePkg: Add some common HTTP definitions

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, October 30, 2015 4:08 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Samer

Re: [edk2] [Patch] MdeModulePkg FileExplorerLib: Create file explorer library.

You need to clarify in the function header comment for ChooseFile API if the caller needs to free the returned DevicePath (File parameter). Also, ChooseFile API may fail to de-allocate memory upon some failure conditions. Reviewed-by: Jaben Carsey > -Original

Re: [edk2] [PATCH] ShellPkg: Refine code by initializing local variable and adding ASSERT statement.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, October 27, 2015 6:38 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> >

Re: [edk2] EFI pe version number

Is there a reason that you don't just set the version number in the INF file for your application? There is an entry in the [DEFINES] section. I think that one is retained. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Miller, Carl H >

Re: [edk2] [PATCH] ShellPkg: Refine code by initializing local variable and adding ASSERT statement.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> -Original Message- From: Qiu, Shumin Sent: Tuesday, October 27, 2015 6:38 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: [PATCH] She

Re: [edk2] [PATCH] ShellPkg: Update 'tftp' command help output and error messages

18659 Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Friday, October 23, 2015 1:07 PM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com> > Cc: El-Haj-Mahmou

Re: [edk2] [PATCH 1/1] AppPkg: Allow interactive Python on platforms without STDERR

> Sent: Friday, October 16, 2015 4:19 PM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; > Bjorge, Erik C <erik.c.bjo...@intel.com> > Subject: [edk2] [PATCH 1/1] AppPkg: Allow interactive Python on platforms > without STDERR > Importance: High &

Re: [edk2] [PATCH] ShellPkg: Use safe string functions to refine Tftp.c code.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Qiu Shumin > Sent: Tuesday, October 13, 2015 10:00 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] worth openning gEfiSimpleTextIinputProtocol ?

There may be multiple text in protocols. How will you know which one to open? ConIn may also be redirecting from a Unicode file, an asci file, or an environment variable if you run under the shell. Tl;dr No, don't do it. > -Original Message- > From: edk2-devel

[edk2] ShellPkg: ShellPkg DSC update

Shumin, Can you review this? The update makes all the libs built when the package is built. (prevent future issue like where TFPT lib wouldn't build) ShellPkg: ShellPkg DSC update Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey

Re: [edk2] [PATCH 1/3] ShellPkg: UefiShellTftpCommandLib: fix incompatible pointer assignment

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, September 24, 2015 2:30 PM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel.com>

Re: [edk2] ShellPkg: ShellPkg DSC update

That was an error on my part. I plan to revert the change and then apply the correct one. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, September 24, 2015 1:21 PM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@

Re: [edk2] [PATCH] ShellPkg: Fix Shell fail when execute command in ShellProtocol.Execute().

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, September 15, 2015 10:52 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; > Carsey,

Re: [edk2] [Patch] Nt32Pkg: Fix PlatformBootManagerLib to respect PcdShellFile.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, September 15, 2015 11:10 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Jin, Eric

Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem

Thanks. I looked at the wrong thing somehow. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Wednesday, September 16, 2015 11:15 AM &

Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 2.8 Type 17 changes to smbiosview

Reviewed-by: Jaben Carsey > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hp.com] > Sent: Wednesday, September 16, 2015 11:10 AM > To: edk2-devel@lists.01.org > Cc: jaben.car...@intel.com --cc=shumin@intel.com; Samer El-Haj- >

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

, > Ruiyu > Sent: Monday, September 14, 2015 9:54 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben; chr...@hpe.com; Hale, Robert P; Rothman, Michael A > Subject: [edk2] Proposal to let standalone UEFI shell application carry help > inside .EFI instead of in .MAN file > > A

Re: [edk2] [PATCH] ShellPkg: Rename some functions in Dp to avoid build errors

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, September 11, 2015 4:53 PM > To: edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@h

Re: [edk2] [PATCH] ShellPkg: Update the help information for 'setvar' command to follow Shell behavior.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, September 14, 2015 1:28 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> > S

Re: [edk2] Application abort event for EFI_ABORTED

The shell does this be using SimpleTextInEx and registering for a CTRL-C keystroke. Then the interrupt from that will set another event that some applications and all long commands are watching for in a polling loop such that things can be halted. For example, the ls command checks if this

Re: [edk2] [PATCH] ShellPkg: Fix Shell does not support ASCII pipe(|a).

s.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> > Subject: [PATCH] ShellPkg: Fix Shell does not support ASCII pipe(|a). > Importance: High > > Cc: Jaben Carsey <jaben.car...@intel.com> > Contributed-under: TianoCo

Re: [edk2] [PATCH 2/2] ShellPkg: Fix Shell fail with redundant space following delay number.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, September 06, 2015 8:06 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] MdePkg: Refine UefiFileHandleLib to avoid write non-ASCII char into ASCII file.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, September 08, 2015 12:05 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH 1/2] ShellPkg: Fix 'for' command fail with multiple fields.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, September 06, 2015 8:06 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] ShellPkg: Fix the ASSERT issue in drvcfg command.

Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: Qiu, Shumin Sent: Tuesday, August 25, 2015 7:46 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin shumin@intel.com; Carsey, Jaben jaben.car...@intel.com Subject: [PATCH] ShellPkg: Fix the ASSERT issue

Re: [edk2] [PATCH] ShellPkg: use UEFI_APPLICATION module type for Shell components

Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, August 25, 2015 6:04 AM To: edk2-devel@lists.01.org; Carsey, Jaben; Qiu, Shumin Cc: Ard Biesheuvel Subject: [PATCH] ShellPkg: use UEFI_APPLICATION

Re: [edk2] [PATCH v3 2/3] MdePkg/Library/UefiFileHandleLib: Make the FileHandleGetFileName return the file name in right format.

I like the comments. Thanks for updating them! -Original Message- From: Qiu, Shumin Sent: Monday, August 24, 2015 11:39 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Carsey, Jaben; Gao, Liming Subject: [PATCH v3 2/3] MdePkg/Library/UefiFileHandleLib: Make the FileHandleGetFileName

Re: [edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

What about other error return values in *TransferResult? Both places you check for a specific set of errors, but the set is not exhaustive and if a different error occurs, will the caller know? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH 1/3] MdePkg/Library/UefiFileHandleLib: Update the module Basename and module type to 'UEFI*'.

Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: Qiu, Shumin Sent: Friday, August 21, 2015 1:03 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin shumin@intel.com; Carsey, Jaben jaben.car...@intel.com; Gao, Liming liming@intel.com Subject: [PATCH 1/3

Re: [edk2] [PATCH v2 1/2] ShellPkg: force use of AARCH64 small model when building DEBUG shell

Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, August 19, 2015 2:48 AM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org Cc: Carsey, Jaben jaben.car

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

Reviewed-by: Jaben Carsey jaben.car...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Wednesday, August 19, 2015 8:53 AM To: Ard Biesheuvel ard.biesheu...@linaro.org Cc: edk2-devel@lists.01.org;

Re: [edk2] [uswg] Shell 2.0 and 2.1

, August 17, 2015 10:09 AM To: Carsey, Jaben jaben.car...@intel.com; uswg u...@uefi.org Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [uswg] Shell 2.0 and 2.1 Importance: High Thank you, Jaben. I have added my comments inline *From:* Carsey, Jaben [mailto:jaben.car...@intel.com

Re: [edk2] [uswg] Shell 2.0 and 2.1

(note: I changed the edk2 mailing list) Daniel, A UEFI Shell 2.0 application will work fine in UEFI Shell 2.1 with no changes. To create/build a UEFI Shell 2.1 application would need to have a version of the UDK that has the updated protocol to get easy access to the new API’s that were added

Re: [edk2] TianoCore Subversion down?

18032 was just a change to maintainers.txt by me replacing Daryl as the maintainer of a few packages with myself. I can send it if necessary, but I'd say it's pretty uninteresting really... -Jaben -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

<    2   3   4   5   6   7