Re: [edk2] [patch] MdeModulePkg: Refine the UI code

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Monday, March 14, 2016 3:24 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg: Refine the UI code > > Remove

Re: [edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Reviewed-by: Eric Dong Feng, Please help to check in this code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016 3:56 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH v5] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Hi Cecil, The gEfiImageDecoderProtocolGuid value in the .h file is not consistent with the value in the dec file. Please correct it. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016

Re: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Monday, March 07, 2016 2:07 PM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng > Subject: [edk2] [PATCH v4] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder > protocol

Re: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

anks, Eric > -Original Message- > From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com] > Sent: Friday, March 04, 2016 9:36 AM > To: Bi, Dandan; edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming; Chang, Abner (HPS SW/FW Technologist) > Subject: RE: [edk2] [PATCH] M

Re: [edk2] [PATCH v2] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Reviewed-by: Eric Dong Hi Feng, Please help to check in the code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Wednesday, March 02, 2016 10:56 AM > To: edk2-devel@lists.01.org >

Re: [edk2] [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, March 03, 2016 4:54 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric > Subject: [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style &g

Re: [edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointers are not NULL

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 10:52 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric

Re: [edk2] [patch] MdeModulePkg: FileExplorerLib: Modify the EFI_FILE_EXPLORE_FORMSET_GUID

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 2:58 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming

[edk2] FW: [PATCH] MdeModulePkg/HiiDatabaseDxe: Fix a variable is uninitialized.

Reviewed-by: Eric Dong Feng & Star, Can you help to check in this patch? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cinnamon Shia Sent: Monday, February 22, 2016 10:53 AM To: edk2-devel@lists.01.org

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

form with a large amount of > HII data. On this platform, we end up disabling the largest but least > used setup screens when running on the simulator, simply to avoid the > time overhead of processing the HII data. This saves many minutes of > execution time. > > >>>

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

Hi Brian, Thanks for your comments, we need internal discussion for your raised issues, will reply later this week. Thanks, Eric > -Original Message- > From: Brian J. Johnson [mailto:bjohn...@sgi.com] > Sent: Friday, February 19, 2016 5:18 AM > To: Andrew Fish; Dong, Eric

Re: [edk2] [patch] MdeModulePkg: Refine the code in BootMaintenanceManagerUiLib

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, February 17, 2016 6:15 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg: Refine the code in BootMaintenance

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

Correct one error in former mail, the extra data size cost is the runtime memory cost instead of bios flash data cost. Thanks, Eric > -Original Message- > From: Dong, Eric > Sent: Thursday, February 18, 2016 10:51 AM > To: El-Haj-Mahmoud, Samer; Andrew Fish; Brian J. John

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

a PCD to control it. Thanks, Eric > -Original Message- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Wednesday, February 17, 2016 2:14 AM > To: Andrew Fish; Brian J. Johnson > Cc: Bi, Dandan; edk2-devel@lists.01.org; Dong, Eric; Gao, Liming >

Re: [edk2] [patch 0/2] Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

Reviewed-by: Eric Dong <eric.d...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, February 16, 2016 7:55 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subj

Re: [edk2] [patch 0/2] Refine function comments in Keyword Handler Protocol

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, February 15, 2016 2:56 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch 0/2] Refine fu

Re: [edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Zhang, Chao B Sent: Thursday, January 14, 2016 4:43 PM To: edk2-de...@ml01.01.org Cc: Dong, Eric; Fu, Siyuan; Zhang, Chao B Subject: [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update lo

Re: [edk2] [patch 1/8] MdeModulePkg:Rename BootMaintenanceManagerLib to BootMaintenanceManagerUiLib

nal Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Tuesday, January 12, 2016 1:52 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> > Subject: [edk2

Re: [edk2] [Patch] MdeModulePkg: DeleteLoadOptionVariable() removes Boot####

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Thursday, January 07, 2016 6:15 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: DeleteLoadOptionVariable() removes Boot

Re: [edk2] [Patch] MdeModulePkg/BootManagerMenu: Fix bug that boots to undesired option

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, December 24, 2015 3:50 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [edk2] [Patch] MdeMod

Re: [edk2] [Patch 3/8] MdeModulePkg: Add the missing library uni files of UI instances

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 3/8] MdeModulePkg: Add the missing library uni

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

[mailto:aaron@congatec.com] Sent: Wednesday, December 23, 2015 2:27 AM To: Dong, Eric Cc: Bi, Dandan; edk2-devel@lists.01.org; edk2-devel; Gao, Liming; El-Haj-Mahmoud, Samer Subject: Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime I have a question about

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, December 21, 2015 4:45 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch] MdeModulePkg:Ma

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Yes, all the Hii database data will be export. Also the ConfigResp string for all HII drivers. -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, December 22, 2015 9:25 AM To: Dong, Eric; Bi, Dandan; edk2-devel@lists.01.org Cc: Gao

Re: [edk2] [patch] MdeModulePkg:Update Boot Manager form when enter it.

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 5:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Update Boot Manager form when enter it. Currently BootM

Re: [edk2] [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict.

Add more description for it: GCC49 has enhance the global variable name conflict check. If different module share the same global name, it will report link error. This patch fixed one case reported for DxeTpmMeasureBootLib and DxeImageVerificationLib. -Original Message- From:

Re: [edk2] [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

Hi Cecil, Why not also use mCurrentFormSetGuid and mCurrentHiiHandle for the guid and HiiHandle info? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil Sheng Sent: Monday, December 14, 2015 1:38 PM To: edk2-devel@lists.01.org

Re: [edk2] [PATCH] MdeModulePkg: Convert HiiDatabaseDxe ConfigRouting ASSERT to return an error

Reviewed-by: Eric Dong <eric.d...@intel.com> Checked in code at r19219 Thanks, Eric -Original Message- From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Friday, December 04, 2015 9:33 PM To: edk2-devel@lists.01.org; Dong, Eric; Gao, Liming Subject: [PATCH] MdeModulePkg: C

Re: [edk2] [patch] MdeModulePkg:Refine the comments in INF files

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 4:55 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Refine the comments in INF files Add comments in IN

Re: [edk2] [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 24, 2015 3:22 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option BDS puts a special GUID i

Re: [edk2] [patch] MdeModulePkg:Correct the file name in UiApp.inf

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 12:43 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Correct the file name in UiApp.inf Cc: Liming Gao <liming@inte

Re: [edk2] [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing.

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Ni, Ruiyu Sent: Monday, November 09, 2015 1:24 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch V2 5/5] Nt32Pkg: Use LogoLib for LOGO and progress bar drawing. Contributed-under: Tia

Re: [edk2] [Patch V3 2/2] MdeModulePkg FileExplorerDxe: Create file explorer Protocol.

Yes, will update when check in the code. -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, November 11, 2015 1:41 PM To: Dong, Eric Cc: edk2-devel@lists.01.org; cecil.sh...@hpe.com; samer.el-haj-mahm...@hpe.com; Gao, Liming Subject: Re: [edk2] [Patch V3

Re: [edk2] Configuration Menu

Hi Foster, Do you use goto opcode to create "System Setup" menu? Can you help to attach the source code for your menu? I think it must be some error in the goto opcode caused this issue. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch 1/2] BaseTools VfrCompiler: In order to keep consistent, add an optional "; " for condition op-code.

Leif, Got it, I will update the format to follow the BaseTools/Contributions.txt. Thanks for your comments. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Wednesday, October 14, 2015 10:32 PM To: Dong, Eric Cc

Re: [edk2] [patch] MdeModulePkg:Fix the bug the incorrect change of StrCpyS function

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Wednesday, September 16, 2015 5:14 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Fix the bug the incorrect change of StrCpyS function The p

Re: [edk2] [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe.

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Bi, Dandan Sent: Friday, September 11, 2015 2:29 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe. Contributed-under: Tia

Re: [edk2] [patch] CryptoPkg: Replace string wrapper functions with safe string functions

Reviewed-by: Eric Dong <eric.d...@intel.com> -Original Message- From: Long, Qin Sent: Tuesday, September 01, 2015 4:55 PM To: Ye, Ting; Dong, Eric Cc: edk2-devel@lists.01.org Subject: [patch] CryptoPkg: Replace string wrapper functions with safe string functions EDKII core s

Re: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build.

Checked in code at r18350 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric Sent: Friday, August 28, 2015 12:54 PM To: Wang, Sunny (HPS SW); edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: Re: [edk2] [PATCH

Re: [edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Monday, August 24, 2015 1:28 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe Check the local variable 'NameSpace' before use

Re: [edk2] [Patch] MdeModulePkg: Update UiApp to handle terminal type TtyTerm

Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Wednesday, August 19, 2015 5:35 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Update UiApp to handle terminal type TtyTerm Contributed-under: TianoCore

Re: [edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Tuesday, August 04, 2015 12:51 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch 2/2] MdeModulePkg:Refine the code comments in UiApp Contributed-under: TianoCore Contribution

Re: [edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, August 04, 2015 1:16 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue

Re: [edk2] [Patch 2/2] Update copyright info, use BDS license.

- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daryl McDaniel Sent: Friday, July 31, 2015 2:32 AM To: 'Ard Biesheuvel'; Dong, Eric Cc: Ni, Ruiyu; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [Patch 2/2] Update copyright info, use BDS license. The copyright

Re: [edk2] [Patch] MdeModulePkg: Enhance PciBusDxe to handle high 32bit of MEM64 BAR returns 0

Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, July 30, 2015 11:11 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Enhance PciBusDxe to handle high 32bit of MEM64 BAR returns 0 According to the PCI

<    1   2   3   4