Re: [edk2] [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

2019-03-26 Thread Julien Grall
. with the UEFI shell? Just to confirm, should we test for x86 only? If so, I will leave that to Anthony. Cheers, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-20 Thread Julien Grall
Hi, On 20/03/2019 18:25, Laszlo Ersek wrote: On 03/20/19 14:03, Lars Kurth wrote: On 15/03/2019, 17:48, "Lars Kurth" wrote: On 15/03/2019, 10:18, "Julien Grall" wrote: Is the issue that you don’t trust that the license specified in the files are correct?

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-15 Thread Julien Grall
Hi Lars, On 15/03/2019 17:04, Lars Kurth wrote: On 15/03/2019, 02:35, "Julien Grall" wrote: Hi Lars, On 14/03/2019 20:04, Lars Kurth wrote: > > > On 14/03/2019, 12:07, "Julien Grall" wrote: > > (+ Lars)

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-15 Thread Julien Grall
Hi Lars, On 14/03/2019 20:04, Lars Kurth wrote: On 14/03/2019, 12:07, "Julien Grall" wrote: (+ Lars) On 3/14/19 10:55 AM, Laszlo Ersek wrote: > On 03/13/19 18:54, Kinney, Michael D wrote: > (2.2.2) Files that seem to be covered by

Re: [edk2] PATCH] Change EDK II to BSD+Patent License

2019-03-14 Thread Julien Grall
OvmfPkg/XenBusDxe/GrantTable.c OvmfPkg/XenPvBlkDxe/BlockFront.c That's correct, they are licensed under 2-clause BSD. Cheers, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Julien Grall
Hi, On 21/02/2019 16:47, Laszlo Ersek wrote: On 02/21/19 16:21, Julien Grall wrote: I don't watch much my Linaro e-mail anymore. So update my e-mail address from Linaro to the Arm one. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall --- Maintainers.txt

Re: [edk2] [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers

2019-02-21 Thread Julien Grall
: Julien Grall Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- Notes: v2: - new in v2 Maintainers.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Julien Grall
I don't watch much my Linaro e-mail anymore. So update my e-mail address from Linaro to the Arm one. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall --- Maintainers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Maintainers.txt b

Re: [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-17 Thread Julien Grall
lly sorted. For this patch: Reviewed-by: Leif Lindholm However - unrelated sidenote: Julien, is that address still valid for you? I still have a linaro account. Although, I guess it would be best if we use my Arm e-mail for the EDK2 review. I will send a patch to change the address. Cheers,

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-23 Thread Julien Grall
On 23/01/2019 01:41, Zeng, Star wrote: Hi Julien, Hi Star, On 2019/1/22 12:30, Zeng, Star wrote: On 2019/1/22 3:40, Ard Biesheuvel wrote: On Mon, 21 Jan 2019 at 14:36, Julien Grall wrote: diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c b/MdeModulePkg/Universal

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-21 Thread Julien Grall
Hi, On 21/01/2019 10:46, Zeng, Star wrote: > On 2019/1/18 2:59, Julien Grall wrote: > I saw the discussion at > https://lists.01.org/pipermail/edk2-devel/2019-January/035405.html. > Fortunately, > it has been fixed. > So I did rebase for the code. > Repo: g...@github

Re: [edk2] Unable to boot Linux with master EDK2

2019-01-21 Thread Julien Grall
it! Cheers, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Unable to boot Linux with master EDK2

2019-01-18 Thread Julien Grall
what could have gone wrong? Best regards, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-17 Thread Julien Grall
Hi Star, On 17/01/2019 01:26, Zeng, Star wrote: On 2019/1/16 22:26, Julien Grall wrote: Hi Laszlo, On 15/01/2019 09:37, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-16 Thread Julien Grall
and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- ArmVirtPkg/ArmVirtXen.dsc | 9 +++-- ArmVirtPkg/ArmVirtXen.fdf | 4

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

2018-04-25 Thread Julien Grall
Hi Ard, Thank you for the series, I confirm it fixes EDK2 boot in Xen guest. Tested-by: Julien Grall <julien.gr...@arm.com> Acked-by: Julien Grall <julien.gr...@arm.com> Cheers, On 23/04/18 16:00, Ard Biesheuvel wrote: Reinstate the timer mask quirk for Xen that we recently r

Re: [edk2] [PATCH v2] ArmPkg/TimerDxe: remove workaround for KVM timer handling

2018-04-23 Thread Julien Grall
On 19/04/18 15:34, Ard Biesheuvel wrote: On 19 April 2018 at 16:23, Julien Grall <julien.gr...@arm.com> wrote: Hi Ard, Sorry for the late reply. On 19/04/18 09:16, Ard Biesheuvel wrote: On 17 April 2018 at 08:03, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: When we

Re: [edk2] [PATCH v2] ArmPkg/TimerDxe: remove workaround for KVM timer handling

2018-04-19 Thread Julien Grall
MER_IMASK; ArmWriteCntvCtl (TimerCtrlReg); } -- 2.17.0 ___ cross-distro mailing list cross-dis...@lists.linaro.org https://lists.linaro.org/mailman/listinfo/cross-distro -- Julien Grall ___ edk2-devel mailing l

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

2017-12-04 Thread Julien Grall
Hi Ard, On 04/12/17 15:55, Ard Biesheuvel wrote: On 4 December 2017 at 15:52, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: On 4 December 2017 at 15:19, Julien Grall <julien.gr...@linaro.org> wrote: On 30/11/17 20:31, Ard Biesheuvel wrote: Hmm, looking again, what you

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

2017-12-04 Thread Julien Grall
mer # My knowledge in UEFI is still limited, so I would appreciate any feedbacks here. Cheers, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v3 2/3] MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

2017-11-29 Thread Julien Grall
uture, all the errors but EFI_INVALID_PARAMETERR and EFI_UNSUPPORTED will return EFI_DEVICE_ERROR. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Star Zeng <star.z...@intel.com> --- Star, I found a proto

[edk2] [PATCH v3 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes

2017-11-29 Thread Julien Grall
Per the UEFIv2.7 spec, EFI_DEVICE_ERROR is returned when the serial device is not functioning correctly. Update the description to avoid confusion. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Star Zeng &

[edk2] [PATCH v3 3/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-11-29 Thread Julien Grall
uted-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> Reviewed-by: Star Zeng <star.z...@intel.com> --- Changes in v3: - Add Star reviewed-by - Fix typoes in the commit message --- MdeModulePkg/Universal/SerialDxe/Seria

[edk2] [PATCH v3 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-11-29 Thread Julien Grall
Julien Grall (3): MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported MdeModulePkg/Universal/SerialDxe/SerialIo.c | 23

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-11-27 Thread Julien Grall
viewed-by? Regards, Thanks, Star -Original Message- From: Julien Grall [mailto:julien.gr...@linaro.org] Sent: Saturday, November 25, 2017 12:20 AM To: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; pankaj.ban...@nxp.com; ler...@redhat.com; leif.lind

[edk2] [PATCH v2 3/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-11-24 Thread Julien Grall
uted-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 9 + 1 file changed, 9 insertions(+) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Universal/SerialDxe/

[edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-11-24 Thread Julien Grall
Hi all, This is another attempt to fix the console issue when using UEFI in Xen guest. This new series is based on Laszlo suggestions on the previous version (see [1]). Cheers, [1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html Julien Grall (3): MdeModulePkg/SerialDxe

[edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

2017-11-24 Thread Julien Grall
uture, all the errors but EFI_INVALID_PARAMETERR and EFI_UNSUPPORTED will return EFI_DEVICE_ERROR. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 9 ++--- 1 file changed, 6

[edk2] [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes

2017-11-24 Thread Julien Grall
Per the UEFIv2.7 spec, EFI_DEVICE_ERROR is returned when the serial device is not functioning correctly. Update the description to avoid confusion. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> --- MdeModulePkg/Universal/Ser

Re: [edk2] [PATCH v2 10/14] ArmVirtPkg/ArmVirtXen: add ArmVirtMemInfoLib implementation

2017-11-22 Thread Julien Grall
ArmVirtMemInfoLib implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> Cc: Julien Grall <julien.gr...@linaro.org> I have tested the series on both Arm32 and Arm64 guests:

Re: [edk2] [PATCH V2] MdeModulePkg SerialDxe: Handle Timeout change more robustly

2017-11-08 Thread Julien Grall
he input parameters at all. And SerialDxe can also be enhanced like this patch to be more robust to handle Timeout change. Cc: Julien Grall <julien.gr...@linaro.org> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Compare against the original parameters S

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Handle Timeout change more robustly

2017-11-07 Thread Julien Grall
. Thank you for sending the patch. I will test the v2 and tell you the result. Cheers, Thanks, Star -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Xen Console input very slow in recent UEFI

2017-11-01 Thread Julien Grall
definitely should not be updated. > If the EFI_INVALID_PARAMETER is because of other parameters, the status > should be returned to the caller. Fair enough. Are you going to resend the change you suggest with a commit message? Cheers, -- Julien Grall ___

Re: [edk2] Xen Console input very slow in recent UEFI

2017-10-27 Thread Julien Grall
(This->Mode->DataBits == (UINT32) DataBits) && +(This->Mode->Parity == (UINT32) Parity) && +(This->Mode->StopBits == (UINT32) StopBits)) { + Status = EFI_SUCCESS; +} else { + return Status; +} }

Re: [edk2] Xen Console input very slow in recent UEFI

2017-10-26 Thread Julien Grall
Hi Laszlo, Thank you for your help. On 26/10/17 16:20, Laszlo Ersek wrote: On 10/26/17 17:13, Laszlo Ersek wrote: Hello Julien, On 10/26/17 13:05, Julien Grall wrote: Hi all, I was doing more testing of UEFI in Xen guests and noticed some slow down when using the shell. The characters

[edk2] Xen Console input very slow in recent UEFI

2017-10-26 Thread Julien Grall
ently in SerialRead". The Serial Driver for Xen PV console is very simple (see OvmfPkg/Library/XenConsoleSerialPortLib). So I am not sure where the root cause is. Would anyone have any tips on it? Cheers, -- Julien Grall ___ edk2-devel mailing

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-23 Thread Julien Grall
Hi Laszlo, On 18/10/17 13:11, Laszlo Ersek wrote: On 10/18/17 12:19, Julien Grall wrote: After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change serial attributes", serial is initialized using the reset method that will call SetAttributes. However, SetAttr

[edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-18 Thread Julien Grall
ntribution Agreement 1.1 Signed-off-by: Julien Grall <julien.gr...@linaro.org> --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Universal/SerialDxe/SerialIo.c index ebcd927263..4

Re: [edk2] [PATCH 0/2] ArmVirtPkg: limit IPA space to prevent page table memory waste

2015-11-30 Thread Julien Grall
a similar change may be necssary > on > the Xen end. There is no fixed limit for the PA space on Xen as we re-use the one provided by the hardware. Regards, -- Julien Grall ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel