don't have a 4KB aligned codeoffset.
>From experimentation, Visual Studio builds already enforce this on
AArch64.
I guess my only question/comment would be if GCC48 is left out
intentionally?
Reviewed-by: Leif Lindholm
Tested-by: Leif Lindholm
> ---
> BaseTools/Conf/tools_def.template |
emoved.
> https://bugzilla.tianocore.org/show_bug.cgi?id=158
>
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang
> ---
> ShellPkg/Inclu
more in edk2-platforms :)
https://bugzilla.tianocore.org/show_bug.cgi?id=1389
Regards,
Leif
>
> Thanks
> Liming
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif
> > Lindholm
> > Sent: Monday, December 10, 2018 8:26 PM
if
> Thanks
> Liming
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif
> > Lindholm
> > Sent: Monday, December 10, 2018 8:30 PM
> > To: Feng, Bob C
> > Cc: edk2-devel@lists.01.org; Gao, Liming
&g
ntribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
I think I would personally prefer to see this folded into the "drop
unused GCCnn profiles", but I'll leave that to the discretion of the
BaseTools maintainers.
GCC47_AARCH64* was always a bit cringeworthy, so glad to see it go :
On Mon, Dec 10, 2018 at 12:09:23PM +, Feng, Bob C wrote:
> For the "customized deepcopy" and "cache for uni file parser" data,
> you can see the AutoGen is not slower. The whole Build Duration is
> longer because Make Duration is longer while Make Duration time
> depends on the external make,
Hi Bob,
On Mon, Dec 10, 2018 at 09:16:58AM +0800, BobCF wrote:
> From: "Feng, Bob C"
>
> V2:
Patch version information does not belong in the commit message.
It belongs in a cover letter, or if a cover letter is not used, you
can put these details below the --- line. This way it gets filtered
On Sat, Dec 08, 2018 at 11:24:31AM +0100, Ard Biesheuvel wrote:
> Struct packing is only necessary for data structures whose in-memory
> representation is covered by the PI or UEFI specs, and may deviate
> from the ordinary C rules for alignment.
>
> So in case of FileExplorerLib, this applies to
On Thu, Dec 06, 2018 at 02:42:35PM +, Gao, Liming wrote:
> Hi, all
> tools_def.template includes all tool chains. Some are not used any
> more. And, there is no verification for them. So, I propose to
> remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> UNIXGCC, GCC44,
; Hi,
>
> I have added the performance data in BZ
> https://bugzilla.tianocore.org/show_bug.cgi?id=1288 . Please have a
> review.
>
> Thanks,
> Bob
>
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng,
> Bob C
&g
lear decision on what is required.
>
> Mike
>
> > -Original Message-
> > From: Jin, Eric
> > Sent: Sunday, December 9, 2018 6:19 PM
> > To: Supreeth Venkatesh ; Leif
> > Lindholm ; edk2-
> > de...@lists.01.org
> > Cc: Kinney, Michael D ; Dong
se :-)
Nah, that's what the period right after the stable tag is for. And git
revert :)
Have a retroactive
Reviewed-by: Leif Lindholm
for the list archive.
/
Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On Fri, Sep 21, 2018 at 08:26:04AM +, Chris Co wrote:
> This adds support for using the SD host controller on
> NXP i.MX platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
&
Hi Nariman,
Sorry, one more round: can you replace the tags for 'text` and
```text
more text
even more text
```
please?
And the with **text**?
(And if I missed any more inline HTML, please convert that too.)
Regards,
Leif
On Fri, Nov 30, 2018 at 01:56:36PM +, Nariman Poushin wrote:
>
On Tue, Dec 04, 2018 at 05:40:14PM +0100, Ard Biesheuvel wrote:
> > > +STATIC
> > > +EFI_STATUS
> > > +MvGpioGetValue (
> > > + IN MARVELL_GPIO_PROTOCOL *This,
> > > + IN UINTN ControllerIndex,
> > > + IN UINTN GpioPin,
> > > + IN OUT BOOLEAN *Value
> > > + )
> > > +{
> > > +
On Sat, Oct 20, 2018 at 03:57:41AM +0200, Marcin Wojtas wrote:
> To abstract the initialization required for non-discoverable devices, which
> is often platform specific (i.e., enabling VBUS gpios for USB), introduce
> a NonDiscoverableInitLib for use by the NonDiscoverable code, for which
> each
-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 ++
> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc| 4 ++--
> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf.inc| 2 ++
> Platform/Marvell/
On Sat, Oct 20, 2018 at 03:57:39AM +0200, Marcin Wojtas wrote:
> Marvell Armada 7k/8k-based platforms may use Pca95xx to extend
> amount of the GPIO pins.
>
> This patch introduces support for PCA95xxx I2C IO expander family,
> which is a producer of MARVELL_GPIO_PROTOCOL, by implementing
>
On Sat, Oct 20, 2018 at 03:57:38AM +0200, Marcin Wojtas wrote:
> Hitherto I2c solution used same macros, defined in multiple
> places. Move them to a new common header.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
Reviewed-by
On Sat, Oct 20, 2018 at 03:57:37AM +0200, Marcin Wojtas wrote:
> From: jinghua
>
> Marvell Armada 7k/8k SoCs comprise integrated GPIO controllers,
> one in AP and two in each possible CP hardware blocks.
>
> This patch introduces support for them, which is a producer of
> MARVELL_GPIO_PROTOCOL,
On Sat, Oct 20, 2018 at 03:57:36AM +0200, Marcin Wojtas wrote:
> From: jinghua
>
> This patch introduces protocol that can be used by multiple
> producers (e.g. platform driver or I2C I/O expander).
> It exposes generic api for controlling GPIO pins state.
> Drives are differentiated by
On Sat, Oct 20, 2018 at 03:57:35AM +0200, Marcin Wojtas wrote:
> Introduce new callback that can provide information
> about GPIO SoC controllers, as well as on-board
> I2C IO expanders. According ArmadaSoCDescLib
> ArmadaBoardDescLib routines are used for
> obtaining required data.
>
>
On Sat, Oct 20, 2018 at 03:57:34AM +0200, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada80x0Db and introduces ArmadaBoardDescGpioGet
> routine with per-board I2C IO expander description.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Sat, Oct 20, 2018 at 03:57:33AM +0200, Marcin Wojtas wrote:
> This patch implements ArmadaBoarDescLib library for
> Armada70x0Db and introduces ArmadaBoardDescGpioGet
> routine with per-board I2C IO expander description.
Same commit message comment as 3/12.
This one actually has I2c, but
n" rather than "introduces"
(2/12 did that). Also, since there _is_ no expansion here, the
referring to it as I2C gets ever weirder.
No issues beyond such nitpicking: if you address the commit message
and purge all mentions of I2C from this patch:
Reviewed-by: Leif Lindholm
>
On Wed, Nov 14, 2018 at 01:12:22AM +, Leif Lindholm wrote:
> On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote:
> > This patch extends library with GPIO devices per-board
> > description. Both embedded SoC controllers and
> > I2C IO expanders are supported.
On Tue, Dec 04, 2018 at 02:06:04AM +, Chris Co wrote:
> > > diff --git a/Silicon/NXP/iMX6Pkg/Include/common_epit.h
> > > b/Silicon/NXP/iMX6Pkg/Include/common_epit.h
> > > new file mode 100644
> > > index ..485d6ccbc51e
> > > --- /dev/null
> > > +++
On Tue, Dec 04, 2018 at 10:33:23AM +0100, Ard Biesheuvel wrote:
> > +#pragma pack(push, 1)
>
> I don't see this #pragma making any difference to the structs below,
> can it be dropped?
> >>>
> >>> The pragma pack is defensive. Without it, we rely on the compiler
> >>> packing
On Mon, Dec 03, 2018 at 03:11:33PM +0100, Laszlo Ersek wrote:
> On 11/30/18 07:03, Andrew Fish wrote:
> > Mike,
> >
> > As Krishna points out there are flavors of Apps. Do we want to have
> > different packages for different flavor of apps, or different dirs in
> > a more generic App package?
Hi Eric, Supreeth, Mike,
I was looking to raise a feature request on UEFI SCT and didn't spot
such a product. Should we create one?
Or perhaps we should have an EDK2 Test product with an SCT component?
Regards,
Leif
___
edk2-devel mailing list
On Sat, Dec 01, 2018 at 12:22:17AM +, Chris Co wrote:
> > If using EFI_ACPI prefix, these #defines really should be in edk2 MdePkg.
> > And
> > CSRT itself is, so that might not be a bad idea.
> >
> > > +
> > > +#pragma pack(push, 1)
> >
> > I don't see this #pragma making any difference to
iptor whose old value is zero,
> pass in the address explicitly.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c | 8 ++--
> 1 file changed, 6 ins
ion Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
> index 12ca5b26673e..3b29d33d
uvel
Reviewed-by: Leif Lindholm
> ---
> Silicon/Hisilicon/Hisilicon.dsc.inc | 1 -
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc| 1 -
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 -
> Platf
On Thu, Nov 29, 2018 at 06:39:28PM +, Kinney, Michael D wrote:
> Hello,
>
> This RFC follows up on the proposal from Mark Doran to change the
> EDK II Project to an Apache 2.0 License.
>
> https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
>
>
> ** Please provide
On Thu, Nov 29, 2018 at 05:58:08PM +, Kinney, Michael D wrote:
> Hello,
>
> I would like to propose the creation of a new
> repository called edk2-apps. This repository
> would initially be used to host the following
> packages from the edk2 repository:
>
> * AppPkg
> * StdLib
> *
On Wed, Nov 28, 2018 at 03:33:57PM +0100, Ard Biesheuvel wrote:
> PcdPrePiCpuMemorySize is no longer used so drop the declarations from
> the package DEC file.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by
On Wed, Nov 28, 2018 at 03:33:55PM +0100, Ard Biesheuvel wrote:
> Drop the reference to gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
> which is never used.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by
n Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> BeagleBoardPkg/PrePi/PeiUniCore.inf | 1 -
> BeagleBoardPkg/PrePi/PrePi.c| 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/BeagleBoardPkg/PrePi/PeiUniCore.inf
>
On Wed, Nov 28, 2018 at 03:33:54PM +0100, Ard Biesheuvel wrote:
> Drop some PCD references that are not actually referenced from the
> PlatformPei code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by
n Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Drivers/CpuPei/CpuPei.inf | 1 -
> ArmPkg/Drivers/CpuPei/CpuPei.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.inf
> b/A
n Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 -
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 1 -
> ArmPlatformPkg/PrePi/PrePi.c| 2 +-
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
pages, take MAX_ADDRESS into account as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 3 ---
> ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
On Wed, Nov 28, 2018 at 03:33:47PM +0100, Ard Biesheuvel wrote:
> Add a helper function that returns the maximum physical address space
> size as supported by the current CPU.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by
On Wed, Nov 28, 2018 at 03:33:43PM +0100, Ard Biesheuvel wrote:
> Drop the declaration and the implementation of CreateHoblist(),
> which is not used anywhere.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by
On Wed, Nov 28, 2018 at 03:33:42PM +0100, Ard Biesheuvel wrote:
> Remove this module: it is unused, and should not be used as an
> example going forward.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
>
per happy that the Change from COM1 -> \\_SB.COM0 got
folded into Patch number 2, but I'm not going to ask for a v4 over it.
For the series:
Reviewed-by: Leif Lindholm
Pushed as 86c75fc51f..77ae8610df.
> Chandni Cherukuri (6):
> Platform/ARM/Sgi: Adapt to changes in system-id DT no
ith those tweaks:
Reviewed-by: Leif Lindholm
> cover only 48 address bits.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
> MdePkg/Include/AArch64/ProcessorBind.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
&g
On Tue, Nov 27, 2018 at 01:27:16PM +0100, Ard Biesheuvel wrote:
> On Tue, 27 Nov 2018 at 13:26, Leif Lindholm wrote:
> >
> > While this isn't the only Aarch64 directory in the tree, let's
> > keep from adding more of them.
> >
> > Contributed-under: TianoCore Cont
On Tue, Nov 27, 2018 at 01:17:27PM +0100, Ard Biesheuvel wrote:
> ArmMmuStandaloneMmLib.inf cannot be built for ARM so move it to the
> [Components.AARCH64] section in ArmPkg.dsc.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Re
While this isn't the only Aarch64 directory in the tree, let's
keep from adding more of them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 2 +-
.../StandaloneMmMmuLib/{Aarch64
On Tue, Nov 27, 2018 at 04:56:19PM +0530, Jagadeesh Ujja wrote:
> Adapt the NorFlashDxe driver to be used as a MM_STANDALONE driver to
> allow access to NOR flash for code executing in MM_STANDALONE mode.
> This allows storing of EFI variables on NOR flash which is accessible
> only via the MM
On Mon, Nov 26, 2018 at 01:10:53PM +, Nariman Poushin wrote:
> Openssl is fetched as a git submodule, so make sure git clone --recursive
> is specified in the instructions to fetch a full source tree.
Can you add a
Contributed-under: TianoCore Contribution Agreement 1.1
tag for all patches
On Mon, Nov 26, 2018 at 01:17:48PM +, Nariman Poushin wrote:
> This covers the bulk of the information originally present in
> https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64
> regarding building and running the Foundation/Base FVP Platforms.
>
> The sections on
On Mon, Nov 26, 2018 at 06:50:09PM +0100, Ard Biesheuvel wrote:
> On Mon, 26 Nov 2018 at 18:46, Leif Lindholm wrote:
> >
> > On Fri, Nov 23, 2018 at 01:14:28PM +0100, Ard Biesheuvel wrote:
> > > In preparation of permitting the virt code to define a larger
On Fri, Nov 23, 2018 at 01:14:28PM +0100, Ard Biesheuvel wrote:
> In preparation of permitting the virt code to define a larger PA space
> size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the
> CPU actually supports, take the CPU's capabilities into account when
> setting up the
On Wed, Nov 21, 2018 at 01:01:42PM +0100, Ard Biesheuvel wrote:
> Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank
> NOR flash GUIDs.
For the series:
Reviewed-by: Leif Lindholm
> Ard Biesheuvel (3):
> Platform/ARM: replace hardcoded VenHW() device pat
n Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> ArmPkg/Include/Library/BdsLib.h | 212
> 1 file changed, 212 deletions(-)
>
> diff --git a/ArmPkg/Include/Library/BdsLib.h b/ArmPkg/Include/Library/BdsLib.h
> deleted f
uvel
Reviewed-by: Leif Lindholm
> ---
> Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
> b/Platform/Comcast/Library/RdkBootManagerLib/RdkBoot
Paths,
> so let's fix those, but first move over the library interface declaration
> and get rid of the parts that are no longer used. This will permit dropping
> it from ArmPkg in EDK2.
For the series:
Reviewed-by: Leif Lindholm
> Changes since v1:
> - add Laszlo's ack to
On Wed, Nov 21, 2018 at 02:26:23AM +0100, Marcin Wojtas wrote:
> Hi Leif,
>
> śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a):
> >
> > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote:
> > > > I think all of my comments on this patch can be sum
On Tue, Nov 20, 2018 at 11:00:49PM +0800, Ming Huang wrote:
> On 11/20/2018 10:39 PM, Leif Lindholm wrote:
> > On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote:
> >>>>> And all Hisilicon platforms still use
> >>>>> AuthVariabl
: Ard Biesheuvel
> ---
> v2: - add asm routines to ensure that we don't access memory after
> disabling the MMU and caches
Fun times.
Reviewed-by: Leif Lindholm
> - set MemMap to NULL
>
> ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S | 30
On Tue, Nov 20, 2018 at 07:32:35PM +0530, Thomas Abraham wrote:
> On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm
> wrote:
> >
> > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> > > Commit dc37ca75 ("Edk2Platforms: Re
ADDRESS PhysicalBase;
> + EFI_VIRTUAL_ADDRESS VirtualBase;
>UINT64Length;
>ARM_MEMORY_REGION_ATTRIBUTES Attributes;
> } ARM_MEMORY_REGION_DESCRIPTOR;
Without the above hunk:
Reviewed-by: Leif Lindholm
> diff --git
> a/ArmPkg/Library/ArmSmcPsciReset
On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote:
> >>> And all Hisilicon platforms still use
> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> >>> regardless of Secure Boot setting.
> >>>
> >>> So what problem does this patch solve? A runtime one?
On Tue, Nov 20, 2018 at 07:31:34PM +0530, Thomas Abraham wrote:
> On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel
> wrote:
> >
> > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm
> > wrote:
> > >
> > > Hmm, a follow-up question (which does not affect my r-
a maximum variable
> size of atleast 4KB.
>
> So increase the maximum supported variable size to 8KB on the SGI
> platforms. Without this, the iSCSI driver fails to load.
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Contributed-under: TianoCore Contribution Agreement 1.1
t; https://github.com/hisilicon/OpenPlatformPkg.git
> branch: d06-acs-platforms-v3
The below three patches:
Hisilicon/D06: Correct PcdGicInterruptInterfaceBase
Hisilicon/D06: Modify Gic base
was folded into
Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot
Reviewed-by: Leif Lindholm
Pushed as
On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote:
>
>
> On 11/20/2018 8:13 PM, Leif Lindholm wrote:
> > On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote:
> >> Now that the generic Variable Runtime DXE code no longer
> >> disti
On Tue, Nov 20, 2018 at 05:01:46PM +0800, Ming Huang wrote:
> Now that the generic Variable Runtime DXE code no longer
> distinguishes between gEfiVariableGuid and
> gEfiAuthenticatedVariableGuid in the varstore FV header.
> We can relax the check in the flashFvb driver to accept
> either GUID
On Tue, Nov 20, 2018 at 09:34:51AM +0800, Ming Huang wrote:
>
>
> On 11/20/2018 2:46 AM, Leif Lindholm wrote:
> > On Fri, Nov 16, 2018 at 04:13:02PM +0800, Ming Huang wrote:
> >> Main Change since v1:
> >> 1 Modify comments;
> >>
> >> Code c
On Tue, Nov 20, 2018 at 02:55:11PM +0800, Ming Huang wrote:
> > But if I understand correctly, the remainder of the patch will be
> > incorrect until the other changes to book from TA have been applied
> > (in the subsequent patch).
> > So please move the MADT change to the other patch.
>
> D06
On Tue, Nov 20, 2018 at 02:38:32PM +0800, Ming Huang wrote:
> > My feedback was:
> > ---
> > This would be more clear as "platform specific" than "cpld relative".
> >
> > I did not realise this wasn't a Hisilicon component when reviewing the
> > original set.
> >
> > I approve of this change,
On Tue, Nov 20, 2018 at 03:02:44PM +0800, Ming Huang wrote:
> > Please rebase on new master and address comments for v3.
> > If you can merge
> > Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot
> > and
> > Hisilicon/D06: Modify Gic base
> > as requested and get those sent out before I start
On Tue, Nov 20, 2018 at 05:27:13AM +, Ni, Ruiyu wrote:
> All,
> DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was
> invented in the era when UEFI environment is hard to find. Since now
> UEFI is very popular in PC area, we could stop the official support
> of this package
On Mon, Nov 19, 2018 at 11:27:22AM -0800, Ard Biesheuvel wrote:
> > > > > > In this case, NorFlashQemuLib should not expose the first flash bank
> > > > > > at all.
> > > > > >
> > > > > > To prevent introducing too much internal knowledge about which flash
> > > > > > bank is accessible under
On Mon, Nov 19, 2018 at 07:12:47PM +, Leif Lindholm wrote:
> On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote:
> > The ArmPlatformPkg NOR flash driver has been updated to use device paths
> > consisting of a fixed GUID and a numeric index rather than a separate GU
On Mon, Nov 19, 2018 at 11:16:09AM -0800, Ard Biesheuvel wrote:
> On Mon, 19 Nov 2018 at 11:10, Leif Lindholm wrote:
> >
> > On Fri, Nov 16, 2018 at 05:29:05PM -0800, Ard Biesheuvel wrote:
> > > On Fri, 16 Nov 2018 at 16:45, Ard Biesheuvel
> > > wrote:
>
VenHw(F9B94AE2-8BA6-409B-9D56-B9B417F53CB3)
> BLK0: Alias(s):
> VenHw(8047DB4B-7E9C-4C0C-8EBC-DFBBAACACE8F)
>
> After:
>
> Mapping table
> BLK0: Alias(s):
> VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)
> BLK1: Alias(s):
vice path
> references to NOR flash banks have to be brought up to date as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
This looks good to me, but I'd like a comment from Thomas/Nariman.
With that:
Reviewed-by: Leif Lindholm
> ---
to be exactly 64MB. Or does that require further
changes on the QEMU side?
If it does, please add a comment to the commit message.
Either way:
Reviewed-by: Leif Lindholm
/
Leif
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuv
On Fri, Nov 16, 2018 at 04:45:23PM -0800, Ard Biesheuvel wrote:
> Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe
> has its own VendorHw GUID, and instances of NorFlashPlatformLib
> describe each bank to the driver, along with the GUID for each.
>
> This works ok for bare
exception and a
> truncated backtrace.
If I was bikeshedding, I'd ask for a (NULL) in the comments next to
the 0x0. But other than that, for the series:
Reviewed-by: Leif Lindholm
(be it green or black)
> Ard Biesheuvel (2):
> ArmPlatformPkg: clear frame pointer in startup code
> ArmVirtPkg/PrePi
k fine.
Are there any implications of the TB->TA boot that means I need to
synchronise pushing these with pushing that change for edk2-platforms?
If not, for the series:
Reviewed-by: Leif Lindholm
and I'll push when I have confirmation.
> Ming Huang (4):
> Hisilicon/D06: Add cpu on/
On Fri, Nov 16, 2018 at 02:56:53PM +0800, Ming Huang wrote:
> As M41T83RealTimeClockLib is common library, so move two cpld
> relative functions to OemMiscLib and rename this two functions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
I did not see any
You said in reply to my comment on v1:
---
The PcdGicInterruptInterfaceBase(0xFE00) is wrong, it just copy
from D05/D03,
maybe somewhere will need the right value of Pcd.
---
Please split that out as a separate change, with the above mentioned
in the commit message.
But if I understand
On Fri, Nov 16, 2018 at 02:56:54PM +0800, Ming Huang wrote:
> When SECURE_BOOT_ENABLE is TRUE, FlashFvbDxe should use
> gEfiAuthenticatedVariableGuid, When SECURE_BOOT_ENABLE
> is FALSE, gEfiVariableGuid should be used.
>
Other platforms seem to resolve this by doing something like:
!if
uvel
Reviewed-by: Leif Lindholm
> ---
> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 3f73c191d4d6.
On Mon, Nov 12, 2018 at 05:11:56PM +0530, Chandni Cherukuri wrote:
> Add the initial support for ARM's System Guidance for Infrastructure
> SGI-Clark.Helios platform. The ACPI tables for this platform are
> installed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Mon, Nov 12, 2018 at 05:11:55PM +0530, Chandni Cherukuri wrote:
> Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid'
> for SGI-Clark.Helios platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> S
On Mon, Nov 12, 2018 at 05:11:53PM +0530, Chandni Cherukuri wrote:
> Added ACPI tables and GUID name 'gSgiClarkAresAcpiTablesFileGuid'
> for SGI-Clark.Ares platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> S
On Mon, Nov 12, 2018 at 05:11:54PM +0530, Chandni Cherukuri wrote:
> Add the initial support for ARM's System Guidance for Infrastructure
> SGI-Clark.Ares platform. The ACPI tables for this platform are
> installed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Hi Chandni,
On Mon, Nov 19, 2018 at 05:00:39PM +0530, chandni cherukuri wrote:
> On Mon, Nov 12, 2018 at 9:57 PM Leif Lindholm
> wrote:
> >
> > Hi Chadni,
> >
> > I will disregard this set.
> > Please send out a new v3 containing the changes we've disc
> > Signed-off-by: Ard Biesheuvel
>
> Please consider this patch with the hunk below appended
Reviewed-by: Leif Lindholm
> > ---
> > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.S | 6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
>
MU emulation and on real hardware.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
I would say given how long we've gone without finding this, it's not
justifiable to push this before the stable tag is made - so pleas
On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote:
> > I think all of my comments on this patch can be summarised as "what is
> > an AP in this context"?
> >
> > The term either needs explicit documenting, or expansion in the macro
> > names such that documentation is not required.
>
On Wed, Nov 14, 2018 at 07:16:33AM +0100, Marcin Wojtas wrote:
> Hi Leif,
>
> śr., 14 lis 2018 o 02:12 Leif Lindholm napisał(a):
> >
> > On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote:
> > > This patch extends library with GPIO devices per-board
&g
On Wed, Nov 14, 2018 at 08:53:55AM +, Prasanth Pulla wrote:
> > > The result in DDR may rewrite by cache data. The essence of this
> > > problem is that primary core and slave core access the same area with
> > > different cache attribute.
> > > Configure L3T register to fix this issue;
> >
>
I'm fine with this message, but more changes may be required for PE15
test, so I won't give r-b yet.
On Mon, Oct 29, 2018 at 11:51:08AM +0800, Ming Huang wrote:
> Add cpu on/off feature to support SBSA-PE test.
>
> Build commit information:
> TrustedFirmware:5888a78d43c
>
> Contributed-under:
301 - 400 of 2250 matches
Mail list logo
