ff-by: Qin Long
Signed-off-by: Long Qin
---
CryptoPkg/Include/Library/BaseCryptLib.h | 18 +-
CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h
b/CryptoP
, …).
Theprocss_files.pl was originally created in UNIX-like style (“#!/usr/bin/perl
–w”).
So no more validations on those third-party Perl utility (ActivePerl,
Strawberry, etc). Of cause, I can take a look at those Perl environments later.
Best Regards & Thanks,
LONG, Qin
From: winddy [mailto:windd
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> winddy
> Sent: Thursday, April 13, 2017 10:39 AM
> To: edk2-devel
> Subject: [edk2] CryptoPkg compiles error: BIO_printf() and BIO_snprintf()
> redefined.
>
> Hi experts,
> Now I compile
Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long Qin
---
SecurityPkg/SecurityPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 07a66f5fac..db0c9ac7be 100644
--- a/SecurityPkg/Secur
Yes.
It will be another patch to update the sample PCD data.
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, April 11, 2017 4:00 PM
> To: Long, Qin; Dong, Eric
> Cc: edk2-devel@lists.01.org
> Subject: RE: [Patch] BaseTools/Pkcs7Sign: Update the test certific
: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Long Qin
---
BaseTools/Source/Python/Pkcs7Sign/Readme.md| 42 +++-
BaseTools/Source/Python/Pkcs7Sign/TestCert.pem | 117 +++--
BaseTools/Source/Python/Pkcs7Sign/TestCert.pub.pem
Thanks for doing this.
Looks we just filed internal tracker for this spec update. This BZ is helpful
for community tracking.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, April 7, 2017 6:18 PM
&g
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, April 6, 2017 8:57 PM
> To: Long, Qin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Hao A ; Tian,
> Feng ; Dong, Eric
> Subject: Re: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg
s2.h definition for consistence, which
was submitted / approved by the PR
(https://github.com/openssl/openssl/pull/3121)
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent:
Reviewed-by: Long Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, April 06, 2017 4:16 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
> Subject: [edk2] [Patch] CryptoPkg Intrinsi
Yes, it's feasible.
I still prefer to use "Library/Include" path setting for this, since only
CryptoPkg/Library/*
will refer to these internal header files.
It may be cleaner to keep the current directory in root of CryptoPkg.
Best Regards & Thanks,
LONG, Qin
>
ontributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long
Signed-off-by: Long Qin
---
CryptoPkg/CryptoPkg.dec | 3 +++
CryptoPkg/{ => Library}/Include/CrtLibSupport.h | 0
CryptoPkg/{ => Library}/Include/assert.h | 0
Crypto
From: Qin Long
There are some explicit time(NULL) calls in openssl-1.1.0xx source,
but the dummy time() wrapper in ConstantTimeClock.c (used by PEI
and SMM module) has no any checks on NULL parameter. This is one bug
and will cause the memory access issue.
This patch adds the NULL parameter check
From: Qin Long
V2:
Updated the patches as the comments from Laszlo (ler...@redhat.com).
And filed two TianoCore BZ (#455, #456) to track the further follow-ups
on openssl and EDKII-CryptoPkg:
https://bugzilla.tianocore.org/show_bug.cgi?id=455
https://bugzilla.tianocore.org/show_bug.
From: Qin Long
(Need further follow-ups as described in
https://bugzilla.tianocore.org/show_bug.cgi?id=455)
This patch added some extra build options to suppress possible warnings
when building openssl source under GCC48 and VS2010. Including:
Adding "-Wno-error=maybe-uninitialized" to supp
From: Qin Long
The compiler (visual studio) may optimize some explicit strcmp call
in openssl source to use the intrinsic memcmp call.
In CrtLibSupport.h, we just use #define to mapping memcmp to
CompareMem API. So in Link phase, this kind of intrinsic optimization
will cause the "unresolved exte
From: Qin Long
This patch duplicates one e_os2.h with minor changes into
"CryptoPkg/Include/openssl/" as one workaround to resolve some
external components/modules build issue.
(NOTE: This duplicated e_os2.h may be removed after upstreaming
the changes into openssl. Refer to
htt
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, April 01, 2017 2:45 AM
> To: Long, Qin; edk2-devel@lists.01.org
> Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric
> Subject: Re: [Patch 2/4] CryptoPkg: Fix possible unresolved exter
Yes, will follow the openssl upstreaming and next clean-ups.
Thanks.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, April 01, 2017 2:50 AM
> To: Long, Qin; edk2-devel@lists.01.org
> Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eri
Got it. Will correct the commit message.
Thanks.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, April 01, 2017 2:46 AM
> To: Long, Qin; edk2-devel@lists.01.org
> Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric
> Subject: Re: [Pa
& Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, April 01, 2017 2:24 AM
> To: Long, Qin; edk2-devel@lists.01.org
> Cc: Ye, Ting; Wu, Hao A; Tian, Feng; Dong, Eric
> Subject: Re: [Patch 1/4] CryptoPkg/OpensslLib
implicitely):
int strcasecmp(const char *s1, const char *s2) __attribute__((nonnull));
And there was also one extra build warning (on openssl source) under GCC48.
Let me dig more and provide possible fixes to address this later.
Best Regards & Thanks,
LONG, Qin
> -Original
Reviewed-by: Long Qin
And some typos need to be corrected when check-in:
+EnrollAuthenication2Descriptor (
--> EnrollAuthentication2Description (
+return EnrollAuthenication2Descriptor(Private, VariableName);
--> EnrollAuthentication2Desc
Looks there are other places (e.g. lhash.c) also have this function-mapping
issue.
OK, let's keep this patch.
And o_names.c can be simplified then. (Will submit the patch to openssl part).
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:
nks,
LONG, Qin
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Wednesday, March 22, 2017 6:11 PM
> To: Long, Qin
> Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Ye, Ting
> ; David Woodhouse ;
> ronald.c...@arm.com; Wu, Jiaxin ;
> ler..
Thank you, Ersek.
The comments looks good to me.
Yes, I will send out the V2 patches to integrate those comments, after we
finish the validations on TLS/HTTPS part with Thomas's suggestions about TlsLib
wrapper.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
&g
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, March 22, 2017 10:23 AM
> To: Long, Qin; edk2-devel@lists.01.org
> Cc: ard.biesheu...@linaro.org; Ye, Ting; ronald.c...@arm.com; Wu, Jiaxin;
> g...@suse.com; ler...@redhat.com
> Subject: RE: [edk2] [PATC
Thomas,
Thanks for the comments. I will check this with Jiaxin, and make the possible
updates in V2.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
> Sent: Wednesday, March 22, 2017 1:43 AM
> To: Long, Qin;
Laszlo,
Thanks for validations.
And, I knew CRLF issue is really annoying here. Just keep this in 1.0.2xx
series for consistency, and we will remove the patch totally in next 1.1.0xx.
:-)
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-
Reviewed-by: Qin Long
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Saturday, February 25, 2017 12:05 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Ye, Ting; Long, Qin
> Subject: [edk2] [PATCH v3 2
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, February 25, 2017 7:29 AM
> To: Long, Qin ; edk2-devel@lists.01.org de...@ml01.01.org>
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: Re: [Patch] CryptoPkg/OpensslLib: Upgrade OpenSS
ards & Thanks,
LONG, Qin
> -Original Message-----
> From: Long, Qin
> Sent: Friday, February 24, 2017 9:39 PM
> To: edk2-devel@lists.01.org; Long, Qin
> Cc: Ye, Ting ; Wu, Jiaxin ;
> ler...@redhat.com
> Subject: [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, February 24, 2017 7:01 PM
> To: edk2-devel-01
> Cc: Ni, Ruiyu ; Ard Biesheuvel
Yes, these two items were missed before.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, February 24, 2017 7:01 PM
> To: edk2-devel-01
> Cc: Ard Biesheuvel ; Gary Lin ;
&g
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, February 24, 2017 6:25 AM
> To: Laszlo Ersek
> Cc: edk2-devel-01; Gary Lin; Wu, Jiaxin; Justen, Jordan L; Long, Qin; Ni,
> Ruiyu;
> Ye, Ting; Tomas Hoger
> Subject: R
Hi, Lubo,
Please use "mSha256OidValue", instead of "mHash256OidValue", to identify the
SHA-256 cipher name.
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Lubo
> Sent: Thursday, February 16, 2017 11:05 PM
&
measurement,
e.g. iteration numbers in PBKDF2.
Anyway, it is good thought here to use this SlowCompareMem function with a
fixed CPU time cost. Just remember to add some ASSERT operations as the comment
states.
Best Regards & Thanks,
LONG, Qin
From: Yao, Jiewen
Sent: Wednesday, February 8, 2017
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Zhang, Chao B
>
> Subject: [PATCH V2 6/6] SecurityPkg/dsc: add Passwor
Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Zhang, Chao B
>
> Subject: [PATCH V2 5/6] SecurityPkg/Password: Add Password based
> User
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Zhang, Chao B
>
> Subject: [PATCH V2 4/6] SecurityPkg/Pla
Reviewed-by: Qin Long
Please correct one typo: accroding --> according in the comment.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Zhan
Reviewed-by: Qin Long
Please also check the typo: passowrd --> password.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Zhang, Chao B
>
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
> Subject: [PATCH V2 1/6] CryptoPkg:SmmCryptLib: Add real Pkcs5Pbkdf
Please check the "Digests" and "Digest" in HDR definition, as my previous
comment.
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Saturday, February 04, 2017 9:33 AM
> To: edk2-devel@lists
Hi, Chao,
Please use "Digests", instead of "Digest" in TCG_PCR_EVENT2 definition for spec
alignment.
Other looks good to me.
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Saturday, February
Series reviewed by: Long Qin
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Tuesday, January 17, 2017 12:52 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [P
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Friday, January 06, 2017 9:33 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: TcgPei: Sync TCG PP lifetime lock state
>
> Sync TCG l
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Wednesday, January 04, 2017 3:19 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Yao, Jiewen; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Tcg2ConfigDxe: Display TPM2 HID in
> Tcg2Config
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Wednesday, January 04, 2017 11:12 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Yao, Jiewen; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Tcg2Smm: Update HID patch logic
>
> Update
Reviewed-by: Qin Long
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, December 22, 2016 1:00 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B; Long, Qin
> Subject: [PATCH 2/2] SignedCapsulePkg/SystemCapsuleLib: Add ASSERT
> check for PCD
>
>
Reviewed-by: Qin Long
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, December 22, 2016 1:00 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B; Long, Qin
> Subject: [PATCH 1/2] SecurityPkg/FmpAuthLib: Add PublicKeyDataLength
> check
>
> Add Publ
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 14, 2016 3:34 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Ni, Ruiyu; Ye, Ting; Fu, Siyuan; Zhang, Lubo; Thomas Palmer;
> Wu, Jiaxin
&
Reviewed-by: Qin Long
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 14, 2016 4:05 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Ni, Ruiyu; Ye, Ting; Fu, Siyuan; Zhang, Lubo; Thomas Palmer;
> Yao, Jiewen; Wu, Jiaxin
> Subject: [PATCH v2 1
Reviewed-by: Qin Long
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 14, 2016 3:34 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Ye, Ting; Fu, Siyuan; Zhang, Lubo; Gao, Liming; Kinney, Michael
> D; Thomas Palmer; Wu, Jiaxin
> Subject: [Patch
Reviewed-by: Qin Long
Please correct some typos later:
EFI_TLS_EXTENDION --> EFI_TLS_EXTENSION
TLS/SSLhandshake --> TLS/SSL handshake
cerfificate --> certificate
cypher --> cipher
binaryX.509 --> binary X.509
PEMencoded --> PEM-encoded
Best Regards & Thanks,
LONG, Qin
&
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, November 10, 2016 5:09 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2]
Dandan,
Could you help to correct the comments in BaseCryptLib.h, which also used the
unaligned parameter name?
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, November 10, 2016 3:40 PM
> To: edk2-devel@lists.01.org
> Cc:
Looks good to me.
Reviewed-by: Qin Long
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiewen Yao
> Sent: Thursday, November 03, 2016 4:25 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D; Gao, Liming; Long, Qi
uot;Step by step to
generate sample X.509 certificate chain and sign data with PKCS7 structure".
"How to generate PKCS7 certificate chain via OPENSSL" --> "How to generate
X.509 certificate chain via OPENSSL"
The other steps looks good to me.
Reviewed-by: Qin
Yes, it's better to update to use MD4_DIGEST_SIZE, instead of MD5_DIGEST_SIZE
there.
For #2, it was specifically designed for IPF platform before, I may clean-up
them in future. So will just keep as-is now.
Will send the V2 for updates.
Best Regards & Thanks,
LONG, Qin
> -
Thanks.
Reviewed-by: Qin Long to CryptoPkg fixes.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Wednesday, October 19, 2016 3:01 PM
> To: edk2-devel@lists.01.org
&g
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Friday, October 21, 2016 1:25 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Long, Qin ;
> Zhang, Chao B
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style
&g
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Monday, October 10, 2016 4:45 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Gao, Liming; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build
> fai
Copy that. Thanks, Laszlo.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, September 30, 2016 3:27 AM
> To: Long, Qin
> Cc: Ye, Ting ; edk2-de...@ml01.01.org; Woodhouse,
> David
> Subject: Re: [edk2] [Patch] CryptoPkg/Openss
The update looks good to me.
Reviewed-by: Qin Long
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Friday, September 30, 2016 2:48 AM
> To: Peter Jones ; edk2-de...@ml01.01.org; Zhang,
> Chao B ; Kinney, Michael
> -Original Message-
> From: Woodhouse, David
> Sent: Thursday, September 29, 2016 5:19 PM
> To: Long, Qin ; edk2-devel@lists.01.org
> Cc: Ye, Ting
> Subject: Re: [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to
> 1.0.2j
>
> On Thu, 2016-09-29 at
Sure, refer to https://github.com/qloong/edk2/tree/dev-openssl-1.0.2j
Thanks, Laszlo.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, September 29, 2016 5:23 PM
To: Long, Qin
Cc: edk2-de...@ml01.01.org; Ye,
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Tuesday, September 27, 2016 9:53 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Tcg2: Fix TCG2 PP issues
>
> Several issues ex
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Monday, September 26, 2016 10:39 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Tcg: New field for User Confirmation Status
>
-generator-drng-software-implementation-guide
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Saturday, September 17, 2016 3:19 PM
To: Palmer, Thomas
Cc: edk2-devel@lists.01.org; Gibbons,
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Zhang, Chao B
Sent: Wednesday, August 31, 2016 9:47 AM
To: edk2-devel@lists.01.org
Cc: Long, Qin ; Yao, Jiewen ; Zhang,
Chao B
Subject: [PATCH] SecurityPkg: TPM12CommandLib: Add Response returnCode C
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Wednesday, August 10, 2016 8:24 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
&g
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Thomas Huth [mailto:th...@redhat.com]
> Sent: Saturday, August 6, 2016 5:00 AM
> To: edk2-de...@ml01.01.org
> Cc: Long, Qin ; Ye, Ting
> Subject: [PATCH] CryptoPkg: Fix "res
Exactly. Thanks.
Reviewed-by: Qin Long
> -Original Message-
> From: Thomas Huth [mailto:th...@redhat.com]
> Sent: Saturday, August 6, 2016 4:51 AM
> To: edk2-de...@ml01.01.org
> Cc: Long, Qin ; Ye, Ting
> Subject: [PATCH] CryptoPkg: Fix capitalization of path name
Reviewed-by: Qin Long
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, August 05, 2016 8:53 AM
> To: edk2-devel@lists.01.org; Gao, Liming
> Cc: Wu, Hao A; Long, Qin; Ye, Ting
> Subject: [PATCH 17/17] CryptoPkg DSC: Add build option to disable
> depreca
e can add other cipher supports according to the real requirements. It's OK to
remove those unsupported cipher suite for this phase.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, August 02, 2016 10:03 AM
> To: Palmer, Tho
Disabling weak ciphers is the
recommendation for hardening SSL communications.
For other ciphers (idea, dsa, etc), we can enable them step-by-step depending
on the real requirements.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday,
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Wednesday, July 20, 2016 1:01 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting; Long, Qin
>
Thanks again for your validations, and the reminder on Install.sh (which was
really one issue. I made several mistakes on this CRLF/LF usage before).
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, Ju
this update, I would not introduce one big patch to
fix this, and just keep the same style with 1.0.2g.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, July 15, 2016 6:47 PM
> To: Long, Qin ; edk2-de...@m
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, July 11, 2016 1:43 PM
> To: edk2-devel@lists.01.org
> Cc: Palmer Thomas; Samer El-Haj-Mahmoud; Long, Qin; Ye, Ting
> Subject: [staging/HTTPS-TLS][PATCH
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Sunday, July 10, 2016 9:34 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Ye, Ting; Long
CryptoPkg:
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Mudusuru, Giri P
> Sent: Friday, July 08, 2016 2:21 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Ye, Ting
> Subject: [edk2] [PATCH v2 05/14] CryptoPkg:
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Friday, July 08, 2016 12:30 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Ye, Ting; Fu, Siyua
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Mudusuru, Giri P
> Sent: Thursday, July 07, 2016 3:48 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Ye, Ting
> Subject: [edk2] [PATCH 05/16] CryptoPkg: Series of patches to fix
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, July 06, 2016 3:57 PM
> To: David Woodhouse
> Cc: Ye, Ting; edk2-devel@lists.01.org; Cohen, Eugene;
> leif.lindh...@linaro.org; Long, Qin
Will check this.
I didn't validate RVCT build before. I am curious if this is one new link
issue?
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cohen, Eugene
> Sent: Wednesday,
Yes, this unset issue was already fixed in OpenSSL HEAD.
The patch is OK for me to ignore the warning for current 1.0.2 version. Or we
can backport some cleanups into our 1.0.2xx patch.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Sunday, June 12, 2016 10:26 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Tcg2Smm: Enhance T
The patch looks good.
And one typo was in original comment:
// Check the reponse data header (tag,parasize and returncode )
--> response
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel
Personally, I prefer to use the second option for this kind of sync-up.
Of cause, we need to have good senses about which updates will impact this
staging feature.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, May 19, 2016
This looks good to me.
Reviewed-by: Qin Long
Best Regards & Thanks
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, May 03, 2016 8:43 AM
> To: Wu, Jiaxin; edk2-devel@lists.01.org
> Cc: Samer El-Haj-Mahmoud; Long, Qin
> Subject: RE: [edk2] [st
right here.
Not sure if any other issues for the wrong result, e.g. data order, key auth
data, etc. I just ever validated some other TPM 1.2 commands with auth
requirements before.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-
This looks good to me. Thanks Kevin for creating the ref #.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Friday, April 15, 2016 8:40 AM
> To: Kevin Davis
> Cc: edk2-de...@ml01.01.org; Laszlo Ersek; Long, Qin; Peter Jones
&
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Wednesday, April 13, 2016 4:29 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wron
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao,
> Liming
> Sent: Friday, April 8, 2016 9:43 AM
> To: Cinnamon Shia ; edk2-devel@lists.01.org
> Subj
Hi, James,
Do we have final conclusion against the Pkcs7 protocol updates?
Will the VerifySignature interface be deprecated or re-enabled for signed-image
verification?
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.
l to keep "/Oi" here for the possible intrinsic
detections, since it's really not recommended in EDKII code base to write those
code pieces which may be swapped by the Visual Studio for an intrinsic
memset/memcpy/etc.
Best Regards & Thanks,
LONG, Qin
> -Original Me
Looks great. It's really helpful.
We can follow this for step-by-step integration & fixes. :-)
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Friday, March 11, 2016 9:24 AM
> To: edk2-de...@ml
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Friday, March 11, 2016 1:00 AM
> To: Wu, Jiaxin ; edk2-de...@ml01.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Long, Qin
>
> Subject: Re: [edk2] [Patch 2/6] CryptoPkg: Add OpensslTl
101 - 200 of 248 matches
Mail list logo
