> -----Original Message----- > From: David Woodhouse [mailto:[email protected]] > Sent: Friday, March 11, 2016 1:00 AM > To: Wu, Jiaxin <[email protected]>; [email protected] > Cc: Ye, Ting <[email protected]>; Fu, Siyuan <[email protected]>; Long, Qin > <[email protected]> > Subject: Re: [edk2] [Patch 2/6] CryptoPkg: Add OpensslTlsLib module to enable > 'openssl\ssl' > > On Wed, 2016-02-24 at 16:15 +0800, Jiaxin Wu wrote: > > --- a/CryptoPkg/CryptoPkg.dsc > > +++ b/CryptoPkg/CryptoPkg.dsc > > @@ -48,10 +48,11 @@ > > > > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf > > > > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf > > > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + OpensslTlsLib|CryptoPkg/Library/OpensslLib/OpensslTlsLib.inf > > One more thing... does this *need* to be a separate library? > > It looks like the libraries are built into an archive and then linked > statically. So only those objects which are *referenced* are actually > pulled into the build. Which means that if we just *add* the ssl/ > directory to the OpensslLib build, it will only be pulled in if > something *uses* it. Doesn't it? >
Yes, it's feasible to archive two libraries into one, and only referenced symbols will be included. The current design (separated libraries) is try to keep the original openssl layout (libcrypto and libssl). Different library serve as different scopes. Of cause, the name of OpensslLib.inf looks confusing, which should be one crypto library only. I agree the proposal looks also valuable. We should ever discuss this internally. Let me try and get some size data for evaluations (I think the total symbols / functions in image still highly depend on the capabilities of the compiler / linker). > -- > David Woodhouse Open Source Technology Centre > [email protected] Intel Corporation > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
