On 1/31/2019 10:48 AM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the support to enlarge a LockBox when using the
LockBoxLib API UpdateLockBox().
Please note that the new support will ONLY work for LockBox with attribute
On 1/31/2019 10:48 AM, Hao Wu wrote:
This commit is out of the scope for BZ-1409. It is a refinement for the
PEI library instance within SmmLockBoxLib.
For the below ASSERT statement within function RestoreLockBox():
Status = SmmCommunicationPpi->Communicate (
On 1/31/2019 10:48 AM, Hao Wu wrote:
This commit is out of the scope for BZ-1409. It is a coding style
refinement for the SmmLockBoxLib.
More specifically, the commit will remove all the debug message display
level macros starting with 'EFI_D_' and replace them with macros starting
with
On 1/31/2019 10:48 AM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the AHCI mode ATA device support in the PEI phase.
More specifically, the newly add AhciPei driver will consume the ATA AHCI
host controller PPI for ATA controllers working under
On 1/31/2019 10:34 AM, Chen A Chen wrote:
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482
UEFI Spec define this definition to support Capsule-on-Disk.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhang Chao B
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A
Comments in below.
On 1/30/2019 2:28 PM, Shenglei Zhang wrote:
From: Mike Turner
Introduce public functions Base64Encode and Base64Decode.
https://bugzilla.tianocore.org/show_bug.cgi?id=1370
v2:1.Remove some white space.
2.Add unit test with test vectors in RFC 4648.
On 1/30/2019 2:34 PM, Shenglei Zhang wrote:
Introduce public functions CharToUpper and AsciiCharToUpper.
Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper.
v2: Update the title and commit message of 1/3.
v3: 1.Add a patch to remove AsciiToUpper in
On 12/25/2018 4:17 PM, Shenglei Zhang wrote:
Introduce two public functions CharToUpper and AsciiToUpper.
They have the same functions as InternalCharToUpper and
InternalBaseLibAsciiToUpper.Considering the internal functions will
be removed,so directly I change their function names to the public
On 1/29/2019 2:53 PM, Shenglei Zhang wrote:
From: Mike Turner
Introduce public functions Base64Encode and Base64Decode.
https://bugzilla.tianocore.org/show_bug.cgi?id=1370
v2:1.Remove some white space.
2.Add unit test with test vectors in RFC 4648.
On 1/8/2019 1:25 PM, Eric Dong wrote:
AP should not use PeiServices. The patch serial fix one issue related to this.
This serial also include one patch used to refine the debug message.
Cc: Ruiyu Ni
Eric Dong (2):
UefiCpuPkg/RegisterCpuFeaturesLib: Enhance debug message.
On 12/25/2018 3:50 PM, Gao, Liming wrote:
Hi, all
On Python3 migration https://bugzilla.tianocore.org/show_bug.cgi?id=55, we
update Edk2 BaseTools python source code with the compatible syntax to support
Python2 and Python3 both. Here is code
https://github.com/lgao4/edk2/tree/Python3 for
On 1/7/2019 9:05 AM, Eric Dong wrote:
Enhance debug message format to let them easy to read.
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
.../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 17 +++--
1 file changed, 11
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Thursday, December 20, 2018 9:37 PM
> To: Gerd Hoffmann ; Laszlo Ersek
> Cc: Ni, Ruiyu ; Justen, Jordan L
> ; Ard Biesheuvel ;
> Anthony Perard ; Julien Grall
> ; edk2-devel@list
Yao, Jiewen ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid
> AP calls PeiService.
>
>
> Agreed, Maybe it's time to add a new API like
> AcquireSpinLockWithoutTimeOut?
>
> Thanks,
> Er
Nice cleanup.
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, December 20, 2018 9:16 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, December 17, 2018 5:54 PM
> To: Ni, Ruiyu ; Justen, Jordan L
> ; Ard Biesheuvel ;
> Anthony Perard ; Julien Grall
>
> Cc: edk2-devel@lists.01.org; Kevin O'Connor ; Gerd
> Hoffmann ; David Woodhouse
Hi OvmfPkg maintainers and reviewers,
I am working on removing IntelFrameworkModulePkg and IntelFrameworkPkg. The
biggest dependency now I see is the CSM components that OVMF depends on.
So I'd like to know your opinion about how to handle this. I see two options
here:
1. Drop CSM support in
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Monday, December 3, 2018 2:30 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [Patch 0/2] Update CPUID related definition.
>
> Update CPUID definiti
On 12/6/2018 11:11 AM, Shenglei Zhang wrote:
-DuetPkg
-W:https://github.com/tianocore/tianocore.github.io/wiki/DuetPkg
-M: Ruiyu Ni
-M: Hao Wu
Reviewed-by: Ruiyu Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, December 3, 2018 10:18 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Wu, Hao A ; Zhu,
> Yonghong ; Gao, Liming
> Subject: [PATCH v4 0/2] Remove DuetPkg and unus
,
Ray
> -Original Message-
> From: Felix Polyudov [mailto:fel...@ami.com]
> Sent: Friday, November 30, 2018 8:36 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ruiyu ;
> ler...@redhat.com
> Subject: [Patch] UefiCpuPkg/MpLib: Fix PEI Services Table pointer on AP
Krishna,
The reason there are applications inside MdeModulePkg/Application is that the
shell protocol was in ShellPkg when the app was developed and MdeModulePkg
cannot depend on ShellPkg (rule).
Now since shell protocol is moved to MdePkg, any apps can depend on shell
protocol. (In fact they
Mike,
It's a great idea to have another edk2-apps repo.
I have a question not quite related to this new repo but related to
edk2-platforms repo.
There are many platforms in edk2 repo as well, like Ovmf, Emulator,
Vlv2TbltDevicePkg.
What's your opinion/plan about these platforms?
>
On 11/28/2018 3:31 PM, Liming Gao wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
Maintainers.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 91a4657adc..d75bbe278d 100644
---
On 11/23/2018 5:19 PM, Laszlo Ersek wrote:
On 11/23/18 07:27, prabin ca wrote:
Hi Team,
I’m new to UEFI and display interface in UEFI. I would like to have deep dive
into how display is working in UEFI (display architecture) and how display is
have been bring up (porting of display panel in
Siyuan,
Can you merge all the dsc.inc together like below content?
[Defines]
...
[LIbraryClasses]
...
...
Through this way, platform only needs include once in DSC.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Fu
> Siyuan
> Sent: Thursday, November 22, 2018 1:22 PM
>
On 11/21/2018 7:21 AM, Kinney, Michael D wrote:
Ray,
One additional note. There are some tools in
BaseTools that are only used by Duet. We should
remove those tools too.
Good points. Thanks for the reminding.
Mike
--
Thanks,
Ray
___
All,
DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was invented
in the era when UEFI environment is hard to find. Since now UEFI is very
popular in PC area, we could stop the official support of this package and
remove it from the master.
Anyone who wants to use it still can
On 11/13/2018 4:35 PM, Shenglei Zhang wrote:
All INFs of unused Library instances in IntelFrameworkPkg
are removed as they are not actually used.
https://bugzilla.tianocore.org/show_bug.cgi?id=1190
Cc: Liming Gao
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
All Tianocore stewards,
I'd like to include the below patch (a revert patch) in this stable tag release.
It's to fix a potential security hole when platform mis-configures the
PcdCpuFeaturesUserConfiguration.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Ruiyu Ni
>
On 11/9/2018 3:54 PM, Shenglei Zhang wrote:
The PcdShellFile is not used so it is removed from DSC
in Nt32Pkg and EmulatorPkg.
https://bugzilla.tianocore.org/show_bug.cgi?id=1298
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jordan Justen
Cc: Andrew Fish
Contributed-under: TianoCore Contribution Agreement
Does it mean the current master code is good enough?
Sent from small device
> 在 2018年11月10日，上午1:23，Kinney, Michael D 写道：
>
> Laszlo,
>
> Given that the compatibility issue has been present
> for several months, I would prefer this change be
> deferred until after the stable tag.
>
> We can
Eric,
Thanks for fixing the new found issues.
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric
> Dong
> Sent: Friday, November 9, 2018 1:21 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszl
Eric,
Similar comments suggestion to this patch.
Reviewed-by: Ruiyu Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Eric,
Patch is good.
Reviewed-by: Ruiyu Ni
Some modification to commit message to help understanding the changes.
Please rewording if you think some of them is not proper.
You can push the changes if no concerns about the new commit message.
-
In current implementation, core and package
On 11/8/2018 10:28 AM, Shenglei Zhang wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=1298
The change is based on the change below:
https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ruiyu Ni
Contributed-under: TianoCore
On 11/8/2018 11:15 AM, BobCF wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=1288
This patch is one of build tool performance improvement
series patches.
This patch is going to use python list to store the parser data
instead of using sqlite database.
The replacement solution is as
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, November 7, 2018 4:26 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Ni, Ruiyu
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.
>
> In current code lo
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, November 7, 2018 10:46 PM
> To: Laszlo Ersek
> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael D
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg/BaseSyn
I agree my 1st version commit message is too general.
Because I don't know if RAS can be mentioned:)
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, November 7, 2018 10:46 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Yao, Jiew
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, November 7, 2018 10:42 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: R
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, November 7, 2018 10:32 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Philippe Mathieu-Daudé ;
> Andrew Fish
> Sub
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, November 6, 2018 10:34 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Wu,
> Hao A ; Wang, Jian J ; Yao,
> Jiewen ; Leif Lindholm ;
> Ard Biesheuvel
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, November 7, 2018 10:31 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Ni, Ruiyu
> Subject: [PATCH] SourceLevelDebugPkg/Readme.txt: Update UDK Debugger
> Tool &
Sorry I just saw your mails.
So now you can successfully build EmulatorPkg using VS2015 and VS2017.
And the WinHost.exe can be launched successfully.
Correct?
I know that the EmulatorPkg may not be launched in certain Windows OSes.
The error message is: ERROR : Could not allocate
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, November 5, 2018 11:08 AM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Shenglei ; Ni, Ruiyu
>
> Subject: [PATCH v3 1/5] Nt32Pkg: Remove EdkShellBinPkg in FDF,DSC and
>
: edk2-devel@lists.01.org
> Cc: Zhang, Shenglei ; Justen, Jordan L
> ; Ni, Ruiyu ; Andrew Fish
>
> Subject: [PATCH v3 3/5] EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC
>
> From: shenglei
>
> Remove EdkShellBinPkg in EmulatorPkg.dec and EmulatorPkg.fdf.
> https://bugz
Pushed. Both patches.
Thanks/Ray
> -Original Message-
> From: jim.dai...@dell.com
> Sent: Wednesday, October 31, 2018 7:28 PM
> To: Ni, Ruiyu
> Cc: Carsey, Jaben ; edk2-devel@lists.01.org
> Subject: RE: [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to full
-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J ; Ni,
Ruiyu ; Wu, Jiaxin ; Ye, Ting
Subject: Plan to move all network components to NetworkPkg
Hi, All
The edk2 Bugzilla #1278 "Delete IPv4 only TCP/iSCSI/PXE drivers in
MdeModulePkg" has been confirmed to be included in edk2-stable2019
My fault! Thanks!
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, November 1, 2018 9:38 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: [edk2] [Patch] MdeModulePkg: Remove the
working directory of the file system.
//
if (InputPath == NULL) {
InputPath = L"";
}
If yes, I can remove it for you and push the patch.
Thanks/Ray
> -Original Message-
> From: jim.dai...@dell.com
> Sent: Tuesday, October 30, 2018 7:32 PM
> To:
Shenglei
> Sent: Wednesday, October 31, 2018 1:57 PM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L ; Ni, Ruiyu
> ; Andrew Fish
> Subject: [PATCH 2/5] EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC
>
> Remove EdkShellBinPkg in EmulatorPkg.dec and EmulatorPkg.fdf.
> htt
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, October 31, 2018 2:05 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Laszlo Ersek
>
> Subject: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and
>
SortLib depends on MemoryAllocationLib.
How can it be a BASE type library?
Can we do it in two options?
1. Change the SortLib API to accept a temporary buffer from caller. So the
MemoryAllocationlIb dependency can be removed.
2. Do not change SortLibAPI but uses a fixed-size temporary buffer
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Fu
> Siyuan
> Sent: Tuesday, October 30, 2018 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Justen, Jordan L
>
> Subject: [edk2] [PATCH v1 2/7] EmulatorPkg: R
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Fu
> Siyuan
> Sent: Tuesday, October 30, 2018 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Wu, Hao A
> Subject: [edk2] [PATCH v1 1/7] Nt32Pkg: Replace obsoleted networ
> -Original Message-
> From: jim.dai...@dell.com
> Sent: Tuesday, October 30, 2018 5:15 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to fully-qualify
> paths
>
> +CHAR16*
&g
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Tuesday, October 30, 2018 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Ni, Ruiyu
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
>
> Bui
On 10/26/2018 8:40 PM, Jian J Wang wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1281
This optimization has two purpose:
1. fix BZ#1281 which caused by flushing TLB for AP
2. improve performance for SMM heap guard
The code change is simple: just flush TLB for current
On 10/26/2018 9:41 PM, Star Zeng wrote:
V3: Thanks for Hao's feedback.
1. Match function parameter name and description between
XhciSched.c and XhciSched.h, EhciSched.c and EhciSched.h.
2. Call XhcFreeUrb after XhcCreateTransferTrb fails in XhcCreateTrb.
V2: Thanks for Ray's feedback.
1. Add
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, EhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, XhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new EhciInsertAsyncIntTransfer function from
EhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, October 25, 2018 2:50 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Support combo CPU
> feature style.
>
&g
On 10/25/2018 10:25 AM, Eric Dong wrote:
Fixed ECC issues caused by change serial from d5aa2078 to d28daadd.
Eric Dong (6):
UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure for VS2012 and
GCC49.
UefiCpuPkg/CpuCommonFeaturesLib: Remove white space at line end.
On 10/25/2018 10:26 AM, Eric Dong wrote:
Remove useless code after change 93324390.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +-
...@dell.com
Sent: Wednesday, October 24, 2018 9:36 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Carsey, Jaben
Subject: [edk2] [PATCH 2/2] ShellPkg-Shell App: Provide fully-qualified path
to shell scripts
Importance: High
Section 3.6.2 of version 2.2 of the shell specification requires that
the first
On 10/25/2018 12:35 AM, jim.dai...@dell.com wrote:
Add a function to return the fully-qualified version of some path.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jim Dailey
---
ShellPkg/Include/Library/ShellLib.h | 40 +
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
> jim.dai...@dell.com
> Sent: Saturday, October 6, 2018 3:15 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH] MdePkg-BaseLib: Fix
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 24, 2018 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen ;
> Ni, Ruiyu ; Zeng, Star
> Subject: [PATCH v2 3/3] MdeModulePkg/NvmExpressDxe: Refin
On 10/12/2018 10:18 AM, Dandan Bi wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=1243
This pacth series is mainly to do the enahncement for
Sata/Usbxx/AcpiExp device path to handle the cases when some
optional paremeter is not specified in the text device path.
Cc: Ruiyu Ni
Cc: Michael
On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
Hello,
Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest adding
some debug comments in the area it was removed. Thanks.
debug message or comments?
I guess you'd like to have some comments to say "SMRR is enabled by CPU
SMM
On 10/22/2018 10:30 PM, Laszlo Ersek wrote:
On 10/22/18 11:03, Ruiyu Ni wrote:
Today's PiSmmIpl implementation initially sets SMRAM to WB to speed
up the SMM core/modules loading before SMM CPU driver runs.
When SMM CPU driver runs, PiSmmIpl resets the SMRAM to UC. It's done
in
On 10/18/2018 2:41 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1142
According to the the NVM Express spec Revision 1.1, for some commands
(like Get/Set Feature Command, Figure 89 & 90 of the spec), the Memory
Buffer maybe optional although the command opcode indicates
On 10/18/2018 2:41 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1259
According to the the NVM Express spec Revision 1.1, for some commands,
command-related information will be stored in the Dword 0 of the
completion queue entry.
One case is for the Get Features Command
On 10/18/2018 2:42 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1260
For the PassThru() service of NVM Express Pass Through Protocol, the
current implementation (function NvmExpressPassThru()) will only use the
IO Completion/Submission queues created internally by this
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Sunday, October 21, 2018 12:24 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Wu,
> Hao A ; Wang, Jian J
> Subject: [PATCH 2/2] MdeModulePkg Xhci: Handle value
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Sunday, October 21, 2018 12:24 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ni, Ruiyu ; Wu,
> Hao A ; Wang, Jian J
> Subject: [PATCH 1/2] MdeModulePkg XhciDxe: Assign Usb2H
On 10/18/2018 3:34 PM, Eric Dong wrote:
V3 changes:
1. Use global variable instead of internal function to return string for
register type
and dependence type.
2. Add comments for some complicated logic.
V1 changes:
Because this driver needs to set MSRs saved in normal boot phase, sync
On 10/18/2018 3:34 PM, Eric Dong wrote:
V3 changes include:
1. Use global variable instead of internal function to return string for
register type
and dependence type.
2. Add comments for some complicated logic.
V2 changes include:
1. Add more description for the code part which need easy
On 10/18/2018 3:34 PM, Eric Dong wrote:
v3 changes:
1. Move CPU_FEATURE_DEPENDENCE_TYPE definition to AcpiCpuData.h.
2. Add comments for CPU_FEATURE_BEFORE/CPU_FEATURE_AFTER.
v1 changes:
Add new core/package dependence types which consumed by different MSRs.
Cc: Ruiyu Ni
Cc: Laszlo
On 10/18/2018 3:34 PM, Eric Dong wrote:
v3 changes:
1. Move CPU_FEATURE_DEPENDENCE_TYPE definition here from
RegisterCpuFeaturesLib.h file.
2. Add Invalid type for REGISTER_TYPE which will be used in code.
v2 changes:
1. Add more description about why we do this change.
2. Change structure
On 10/17/2018 10:16 AM, Eric Dong wrote:
Because MSR has scope attribute, driver has no needs to set
MSR for all APs if MSR scope is core or package type. This patch
updates code to base on the MSR scope value to add MSR to the register
table.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under:
On 10/17/2018 10:16 AM, Eric Dong wrote:
AcpiCpuData add new fields, keep these fields if old data already existed.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 2 ++
1 file
On 10/17/2018 10:16 AM, Eric Dong wrote:
Because this driver needs to set MSRs saved in normal boot phase, sync semaphore
logic from RegisterCpuFeaturesLib code which used for normal boot phase.
Detail see below change for RegisterCpuFeaturesLib:
UefiCpuPkg/RegisterCpuFeaturesLib: Add logic
On 10/17/2018 10:16 AM, Eric Dong wrote:
V2 changes include:
1. Add more description for the code part which need easy to understand.
2. Refine some code base on feedback for V1 changes.
V1 changes include:
In a system which has multiple cores, current set register value task costs
huge times.
On 10/17/2018 10:16 AM, Eric Dong wrote:
Add new core/package dependence types which consumed by different MSRs.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
.../Include/Library/RegisterCpuFeaturesLib.h | 25
On 10/17/2018 10:16 AM, Eric Dong wrote:
v2 changes:
1. Add more description about why we do this change.
2. Change structure field type from pointer to EFI_PHYSICAL_ADDRESS because it
will
be share between PEI and DXE.
In order to support semaphore related logic, add new definition for
Thanks for the detailed comments.
Very minor comments in below.
On 10/17/2018 10:16 AM, Eric Dong wrote:
v2 changes:
1. Add more description about why we do this change.
2. Change structure field type from pointer to EFI_PHYSICAL_ADDRESS because it
will
be share between PEI and DXE.
In
Eric,
Can you post your changes to github yours mirror repo?
I found #3/6 cannot be applied to my code properly.
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, October 17, 2018 10:16 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
&g
On 10/18/2018 1:57 AM, Laszlo Ersek wrote:
Hi Jian,
On 10/17/18 10:34, Jian J Wang wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1237
Sometimes the memory will be contaminated by random data left in last
boot (warm reset). The code should not assume the allocated memory is
On 9/30/2018 6:23 AM, Laszlo Ersek wrote:
The "GccInline.c" files have some inconsistent whitespace, and missing (or
incorrect) operand comments. Fix and unify them.
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Michael D Kinney
Ref:
On 10/11/2018 9:05 PM, jim.dai...@dell.com wrote:
Is the line:
Size = gST->Hdr.HeaderSize;
possibly a better way of handling this? Either way:
Reviewed-by: Jim Dailey
Thanks! I will stick to use sizeof().
-Original Message-
From: edk2-devel
On 10/16/2018 3:11 PM, shenglei wrote:
Remove FatBinPkg and modify Maintainers.txt.
https://bugzilla.tianocore.org/show_bug.cgi?id=1105
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
FatBinPkg/EnhancedFatDxe/AArch64/Fat.efi | Bin 26752
On 10/16/2018 11:19 AM, Zeng, Star wrote:
On 2018/10/15 14:38, Ruiyu Ni wrote:
UsbBootReadWriteBlocks() and UsbBootReadWriteBlocks16() use a UINT16
local variable to hold the value of
USB_BOOT_MAX_CARRY_SIZE (=0x1) / BlockSize.
When BlockSize is 1, the UINT16 local variable is set to
On 10/15/2018 10:49 AM, Eric Dong wrote:
Because this driver needs to set MSRs saved in normal boot phase, sync semaphore
logic from RegisterCpuFeaturesLib code which used for normal boot phase.
Detail see change SHA-1: dcdf1774212d87e2d7feb36286a408ea7475fd7b for
RegisterCpuFeaturesLib.
Cc:
On 10/15/2018 10:49 AM, Eric Dong wrote:
In a system which has multiple cores, current set register value task costs
huge times.
After investigation, current set MSR task costs most of the times. Current
logic uses
SpinLock to let set MSR task as an single thread task for all cores. Because
On 10/15/2018 10:49 AM, Eric Dong wrote:
In order to support semaphore related logic, add new definition for it.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Include/AcpiCpuData.h | 23 ++-
On 10/12/2018 11:33 PM, Ard Biesheuvel wrote:
On 12 October 2018 at 17:06, Sami Mujawar wrote:
Hi Ard,
I believe you are referring to
MdeModulePkg\Library\BaseSerialPortLib16550\BaseSerialPortLib16550.inf
I have tried using this Serial Port Library. However, this has a dependency on
PciLib
1 - 100 of 1080 matches
Mail list logo
