Re: [edk2] [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT

Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Ye Ting [mailto:ting...@intel.com] Sent: Thursday, September 29, 2016 11:29 AM To: edk2-devel@lists.01.org Cc: Subramanian@domain.invalid; Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe

Re: [edk2] [patch 0/3] TcpDriver use EFI_D_NET for DEBUG maessage

Series Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, September 23, 2016 11:10 AM To: edk2-devel@lists.01.org Subject: [edk2] [patch 0/3] TcpDriver use EFI_D_NET for

Re: [edk2] [Patch 0/2] Clean the previous address since the policy changed

Series Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Wednesday, September 21, 2016 12:53 PM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P <nagaraj-p.he...@hpe.com>; Subramanian, Sriram (EG Servers

Re: [edk2] [Patch] NetworkPkg: Correct the DNS token return status by RCODE

Jiaxin, - Status = EFI_ABORTED; - goto ON_EXIT; +// +// The domain name referenced in the query does not exist. +// +if (DnsHeader->Flags.Bits.RCode == DNS_FLAGS_RCODE_NAME_ERROR) { + Status = EFI_NOT_FOUND; +} else { + Status = EFI_DEVICE_ERROR; +} +

Re: [edk2] [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Tuesday, September 13, 2016 7:56 AM To: edk2-devel@lists.01.org Cc: Zhang Lubo ; Wu Jiaxin

Re: [edk2] Question on iBFT for iSCSI

Any feedback anyone? Is it reasonable to make the change to publish the configured/DHCP provided target IP address rather than the redirected IP to iBFT? Thanks, Sriram. -Original Message- From: Subramanian, Sriram (EG Servers Platform SW) Sent: Tuesday, August 23, 2016 7:01 PM

[edk2] Question on iBFT for iSCSI

All, The IScsiDxe implementation in EDK2 publishes the iBFT with the target IP address to which it connected to, and not the configured IP. These IPs will be the same if there is no iSCSI redirection. However, if the configured target redirects the initiator to another target (as part of iSCSI

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, August 19, 2016 1:23 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ; Wu

Re: [edk2] [PATCH v1 1/1] ShellPkg:Ping: Ping command hangs with intermittent packet losses

Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Hegde, Nagaraj P Sent: Thursday, July 7, 2016 12:59 PM To: edk2-devel@lists.01.org Cc: jiaxin...@intel.com; jaben.car...@intel.com; ruiyu...@intel.com; Subramanian, Sriram (EG Servers Platform SW)

Re: [edk2] [patch] ShellPkg: Update the error prompt for ping6 command.

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, July 1, 2016 11:43 AM To: edk2-devel@lists.01.org Cc: Fu Siyuan ; Wu Jiaxin

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

Sounds good! -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Friday, June 17, 2016 1:09 PM To: Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.c

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

? Thanks, Sriram. -Original Message- From: Zhang, Lubo [mailto:lubo.zh...@intel.com] Sent: Friday, June 17, 2016 12:43 PM To: Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.c

Re: [edk2] [patch 3/3] MdePkg: Refine codes related to Dhcpv4 and Dhcpv6 configuration.

Hi Lubo, For these: +/// Processor Architecture Types +/// These identifiers are defined by IETF: +/// http://www.ietf.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml +/// +#define DHCP6_ARCH_IA320x000F/// x86 uefi boot from http +#define DHCP6_ARCH_X64 0x0010

Re: [edk2] [PATCH v1 1/1] MdePkg: MTftp6: Correct #define value in Mtfp6.h

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Thursday, June 16, 2016 10:21 AM To: edk2-devel@lists.01.org Cc: ting...@intel.com; siyuan...@intel.com; jiaxin...@intel.com

Re: [edk2] [Patch 0/2] Stop-the-timer-before-clean-IP-service

Serials Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Thursday, May 26, 2016 6:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2]

Re: [edk2] [Patch] NetworkPkg: Fix issue in Ip6Dxe SetData

Thanks Jiaxin for the quick fix. Code looks fine. Reviewed-by: Sriram Subramanian We'll also test it and let you know. Thanks, Sriram. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Wednesday, April 13, 2016

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Add new macros and refine codes

org Cc: Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; Fu Siyuan <siyuan...@intel.com>; Ye Ting <ting...@intel.com>; Wu Jiaxin <jiaxin...@intel.com> Subject: [PATCH v2 2/2] NetworkPkg: Add new macros and refine codes v2: *refine some codes Ad

Re: [edk2] [patch 1/2] NetworkPkg: Add new macros and refine codes

Sriram. -Original Message- From: Subramanian, Sriram (EG Servers Platform SW) Sent: Tuesday, April 5, 2016 7:23 PM To: 'Zhang Lubo' <lubo.zh...@intel.com>; edk2-devel@lists.01.org Cc: Fu Siyuan <siyuan...@intel.com>; Ye Ting <ting...@intel.com>; Wu Jiaxin <jiaxin...@int

Re: [edk2] [patch 2/2] MdeModulePkg: Add new macros and refine codes

Thanks Lubo. Please address this if you agree. Reviewed-by: Sriram Subramanian <srira...@hpe.com> Thanks, Sriram. -Original Message- From: Zhang, Lubo [mailto:lubo.zh...@intel.com] Sent: Wednesday, April 6, 2016 7:37 AM To: Subramanian, Sriram (EG Servers Platform SW) <srira..

Re: [edk2] [patch 1/2] NetworkPkg: Add new macros and refine codes

Ok - I agree. Thanks Siyuan. From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, April 6, 2016 8:07 AM To: Palmer, Thomas <thomas.pal...@hpe.com>; Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; Zhang, Lubo <lubo.zh...@intel.com>; edk2-devel@lists.0

Re: [edk2] [patch 2/2] MdeModulePkg: Add new macros and refine codes

To: edk2-devel@lists.01.org Cc: Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; Fu Siyuan <siyuan...@intel.com>; Ye Ting <ting...@intel.com>; Wu Jiaxin <jiaxin...@intel.com> Subject: [patch 2/2] MdeModulePkg: Add new macros and refine codes Add 2 macros i

Re: [edk2] [patch 1/2] NetworkPkg: Add new macros and refine codes

e value of 128, however to be consistent with the RFC should it allow the Prefix of 128? Thanks, Sriram. -Original Message----- From: Zhang Lubo [mailto:lubo.zh...@intel.com] Sent: Tuesday, April 5, 2016 2:18 PM To: edk2-devel@lists.01.org Cc: Subramanian, Sriram (EG Servers Platform SW) <srir

Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

Sunday, April 3, 2016 3:04 PM To: Fu Siyuan <siyuan...@intel.com> Cc: Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Ye Ting <ting...@intel.com>; Wu Jiaxin <jiaxin...@intel.com> Subject: Re: [edk2] [Patch 1

Re: [edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

an...@intel.com>; Jiaxin Wu <jiaxin...@intel.com>; Ting Ye <ting...@intel.com>; Subramanian, Sriram (EG Servers Platform SW) <srira...@hpe.com> Subject: [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception Commit 1b31acb66c02 ("MdeModuleP

Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

Thanks Siyuan. With this change, looks ok. Reviewed-by: Sriram Subramanian <srira...@hpe.com> Thanks, Sriram. -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Friday, April 1, 2016 6:20 AM To: Subramanian, Sriram (EG Servers Platform SW); edk2-devel@lists.

Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

f the DNS response is malformed (TotalSize == sizeof (DNS_HEADER)? QueryName, QuerySection for example will point to beyond the buffer... Thanks, Sriram. -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Monday, March 28, 2016 8:47 AM To: edk2-devel@lists.01.org Cc: Ye Ting;

Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

Looks good. Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Monday, March 28, 2016 8:47 AM To: edk2-devel@lists.01.org Cc: Ye Ting; Wu Jiaxin; Subramanian, Sriram (EG Servers Platform SW) Subject: [Pat

Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation

Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Wednesday, March 02, 2016 1:33 PM To: edk2-devel@lists.01.org Cc: Ye Ting; Fu Siyuan; Carsey Jaben; El-Haj-Mahmoud, Samer; Subramanian, Sriram (EG Servers Platf

Re: [edk2] [Patch 1/4] MdeModulePkg: Change the default IPv4 config policy

Reviewed-by: Subramanian Sriram <srira...@hpe.com> -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, February 25, 2016 9:52 AM To: edk2-devel@lists.01.org Cc: Subramanian, Sriram (EG Servers Platform SW); El-Haj-Mahmoud, Samer; Ye Ting; Fu Siyuan S

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

I would prefer to keep it simple and so go with solution2. Thanks, Sriram. -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Wednesday, February 24, 2016 7:06 AM To: Subramanian, Sriram (EG Servers Platform SW); El-Haj-Mahmoud, Samer; Kinney, Michael D Cc: Zimmer

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

ould agree to this if this doesn't go against the spec and is okay with others in the forum. Thanks, Sriram. From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, February 23, 2016 1:14 PM To: El-Haj-Mahmoud, Samer; Kinney, Michael D Cc: Subramanian, Sriram (EG Servers Platform SW); Fu, Siyuan; Hegde,

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

selectively change it by calling the set policy API. Thanks, Sriram. -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, February 18, 2016 5:48 AM To: El-Haj-Mahmoud, Samer; Wu, Jiaxin; Subramanian, Sriram (EG Servers Platform SW); Hegde, Nagaraj

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

Hi Jiaxin, No objections. Thanks, Sriram. -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Tuesday, February 16, 2016 9:07 AM To: Subramanian, Sriram (EG Servers Platform SW); El-Haj-Mahmoud, Samer; Hegde, Nagaraj P; Zimmer, Vincent; Kinney, Michael D; Li, Ruth

Re: [edk2] [Patch 0/2] Minor fixes in SnpDxe

Series Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Friday, February 05, 2016 7:51 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2] Minor fixes in SnpDxe Fu Siyuan

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

iyuan...@intel.com] Sent: Tuesday, February 02, 2016 1:56 PM To: Laszlo Ersek; Subramanian, Sriram (EG Servers Platform SW) Cc: edk2-de...@ml01.01.org; Ye, Ting; Wu, Jiaxin; El-Haj-Mahmoud, Samer; Li, Ruth; Hsiung, Harry L Subject: RE: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP

Re: [edk2] [Patch v2 0/3] Fix several issues related to TX buffer recycle

Series Reviewed-by: Sriram Subramanian <srira...@hpe.com> -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, February 03, 2016 9:17 AM To: edk2-de...@ml01.01.org Cc: ting...@intel.com; jiaxin...@intel.com; ler...@redhat.com; Subramanian, Sriram (EG S

Re: [edk2] [Patch v2 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

om: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, February 03, 2016 9:17 AM To: edk2-de...@ml01.01.org Cc: ting...@intel.com; jiaxin...@intel.com; ler...@redhat.com; Subramanian, Sriram (EG Servers Platform SW) Subject: [Patch v2 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

Thanks Siyuan, I reviewed the series, looks good. Sriram. -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, February 03, 2016 9:19 AM To: Laszlo Ersek; Subramanian, Sriram (EG Servers Platform SW) Cc: edk2-de...@ml01.01.org; Ye, Ting; Wu, Jiaxin; El-Haj