Re: [edk2] Does ARM platform produce MP protocol?

2019-03-07 Thread Achin Gupta
On Wed, Mar 06, 2019 at 02:22:25PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 13:41, Achin Gupta wrote: > > > > On Wed, Mar 06, 2019 at 10:37:58AM +0100, Ard Biesheuvel wrote: > > > (adding Achin and Charles) > > > > > > O

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-07 Thread Achin Gupta
On Thu, Mar 07, 2019 at 11:09:35AM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:37, Achin Gupta wrote: > > > > On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > > > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > > >

Re: [edk2] [PATCH 09/10] StandaloneMmPkg/Core: remove legacy boot support

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:47PM +0100, Ard Biesheuvel wrote: > Remove the support for booting 'legacy' (i.e., non-UEFI boot) OSes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:48PM +0100, Ard Biesheuvel wrote: > PI defines a few architected events that have significance in the MM > context as well as in the non-secure DXE context. So register notify > handlers for these events, and relay them into the

Re: [edk2] [PATCH 08/10] StandaloneMmPkg/Core: drop support for dispatching FVs into MM

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:46PM +0100, Ard Biesheuvel wrote: > Remove the support that permits calls into the MM context to dispatch > firmware volumes that are not part of the initial standalone MM firmware > volume. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 07/10] StandaloneMmPkg/Core: dispatch all drivers at init time

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:45PM +0100, Ard Biesheuvel wrote: > Instead of deferring dispatch of the remaining MM drivers once the > CPU driver has been dispatched, proceed and dispatch all drivers. > This makes sense for standalone MM, since all dispatchable

Re: [edk2] [PATCH 06/10] StandaloneMmPkg/Core: permit encapsulated firmware volumes

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:44PM +0100, Ard Biesheuvel wrote: > Standalone MM requires 4 KB section alignment for all images, so that > strict permissions can be applied. Unfortunately, this results in a > lot of wasted space, which is usually costly in the

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

2019-03-06 Thread Achin Gupta
On Wed, Mar 06, 2019 at 05:41:30PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 17:35, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:43PM +0100, Ard Biesheuvel wrote: > > > Sending DEBUG output to the serial port should o

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

2019-03-06 Thread Achin Gupta
Hi Ard, On Tue, Mar 05, 2019 at 02:32:43PM +0100, Ard Biesheuvel wrote: > Sending DEBUG output to the serial port should only be done via > DebugLib calls, which is in charge of initializing the serial > port when appropriate. So drop the explicit SerialPortInitialize () > invocation, and rely on

Re: [edk2] [PATCH 03/10] StandaloneMmPkg: switch to NULL DebugLib resolution

2019-03-06 Thread Achin Gupta
Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:41PM +0100, Ard Biesheuvel wrote: > Building StandaloneMmPkg from its .DSC is mainly intended for build > coverage, and so platform specific configuration such as UART addresses > don't belong here. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-06 Thread Achin Gupta
On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > The PCD PcdStandaloneMmEnable is unused, and shou

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

2019-03-06 Thread Achin Gupta
Hi Ard, On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > first place since the value is implied by the context (it is never > valid to set it to FALSE for standalone MM or TRUE for traditional > MM). So drop

Re: [edk2] Does ARM platform produce MP protocol?

2019-03-06 Thread Achin Gupta
On Wed, Mar 06, 2019 at 10:37:58AM +0100, Ard Biesheuvel wrote: > (adding Achin and Charles) > > On Wed, 6 Mar 2019 at 10:16, Ni, Ray wrote: > > > > > -Original Message- > > > From: edk2-devel On Behalf Of Ard > > > Biesheuvel > > > Sent: Wednesday, March 6, 2019 3:38 PM > > > To: Ni,

Re: [edk2] [PATCH v2 00/11] StandaloneMmPkg: assorted fixes and improvements

2019-01-18 Thread Achin Gupta
Hi Ard, For all the patches... Reviewed-by: Achin Gupta Jiewen. There are changes to the generic Standalone MM code in this series. Do you want to have a look as well? cheers, Achin From: Ard Biesheuvel Sent: 16 January 2019 20:22 To: edk2-devel

Re: [edk2] [PATCH v2 04/11] MdePkg/Include: Add StandaloneMmServicesTableLib library

2019-01-07 Thread Achin Gupta
On Mon, Jan 07, 2019 at 07:55:36PM +0100, Ard Biesheuvel wrote: > On Mon, 7 Jan 2019 at 19:50, Achin Gupta wrote: > > > > On Mon, Jan 07, 2019 at 06:33:26PM +0100, Ard Biesheuvel wrote: > > > On Mon, 7 Jan 2019 at 16:28, Laszlo Ersek wrote: > > > > > > &

Re: [edk2] [PATCH v2 04/11] MdePkg/Include: Add StandaloneMmServicesTableLib library

2019-01-07 Thread Achin Gupta
On Mon, Jan 07, 2019 at 06:33:26PM +0100, Ard Biesheuvel wrote: > On Mon, 7 Jan 2019 at 16:28, Laszlo Ersek wrote: > > > > On 01/04/19 12:57, Ard Biesheuvel wrote: > > > On Thu, 3 Jan 2019 at 17:14, Laszlo Ersek wrote: > > >> > > >> On 01/03/19 12:03, Ard Biesheuvel wrote: > > >>> On Wed, 2 Jan

Re: [edk2] [edk2-platforms PATCH v2 0/2] *** Enable Standalone Management Mode Core Interface on AARCH64 FVP ***

2018-12-23 Thread Achin Gupta
Hi Ard, Sorry for the delay. I have posted these now. cheers, Achin From: Ard Biesheuvel Sent: 12 December 2018 22:04 To: Achin Gupta Cc: Supreeth Venkatesh; Leif Lindholm; edk2-devel@lists.01.org; nd Subject: Re: [edk2-platforms PATCH v2 0/2

[edk2] [edk2-platforms PATCH v3 2/2] Platform/VExpressPkg: Enable MM communication driver.

2018-12-23 Thread Achin Gupta
From: Supreeth Venkatesh This patch enables MmCommunicationDxe on AArch64 Fixed Virtual Platform (FVP) by defining required PCDs and driver inf file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh ---

[edk2] [edk2-platforms PATCH v3 1/2] VExpressPkg: Add dsc and fdf files for generating Standalone MM Image.

2018-12-23 Thread Achin Gupta
From: Supreeth Venkatesh This patch adds description file and firmware device file to generate secure world Standalone Management Mode (MM) image on AArch64 FVP. The secure world Standalone Management Mode (MM) image generated on AArch64 FVP feeds into the fiptool as BL32 image. These files

[edk2] [edk2-platforms PATCH v3 0/2] *** Enable Standalone Management Mode Core Interface on AARCH64 FVP ***

2018-12-23 Thread Achin Gupta
*** PI Specification v1.5 "Volume 4: Management Mode Core Interface" introduces the concept of MM Standalone Mode. This patchset enables Standalone Management Mode Core Interface on AARCH64 FVP. *** Supreeth Venkatesh (2): VExpressPkg: Add dsc and fdf files for generating Standalone MM Image.

Re: [edk2] [edk2-platforms PATCH v2 0/2] *** Enable Standalone Management Mode Core Interface on AARCH64 FVP ***

2018-12-09 Thread Achin Gupta
Hi Leif,Ard, These patches are the last bits to complete support for Standalone MM on the FVP. All other patches have been merged now. Could you please review these? cheers, Achin On Fri, May 04, 2018 at 09:44:34PM +0100, Supreeth Venkatesh wrote: > *** > PI Specification v1.5 "Volume 4:

Re: [edk2] [PATCH v3 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-12-09 Thread Achin Gupta
> create mode 100644 > StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64/StandaloneMmPeCoffExtraActionLib.c > > -- > 2.7.4 > > Reviewed-by: Achin Gupta Pushed as 34b1d7eafee0..f7f94ffe8828 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/5] StandaloneMmPkg: Miscellaneous fixes

2018-12-09 Thread Achin Gupta
Hi Sughosh, On Mon, Dec 03, 2018 at 12:50:51PM +0530, Sughosh Ganu wrote: > Miscellaneous fixes in StandaloneMmPkg code. > > This patcheset is to be applied on top of the following patchset > "StandaloneMM: Update permissions for Standalone MM drivers memory area"

Re: [edk2] [PATCH v2 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-12-01 Thread Achin Gupta
Hi Sughosh, On Sat, Dec 01, 2018 at 09:56:52AM +0530, Sughosh Ganu wrote: > hi Achin, > > On Sat Dec 01, 2018 at 05:08:50AM +0530, Achin Gupta wrote: > > Hi Sughosh, > > > > +Jiewen > > > > I took the patches for a spin and it looks like the FVP port is b

Re: [edk2] [PATCH v2 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-11-30 Thread Achin Gupta
Hi Sughosh, +Jiewen I took the patches for a spin and it looks like the FVP port is broken. Some reasons are: 1. The build breaks due to a reference to ArmMmuLib in StandaloneMmPkg.dsc 2. There is a broken dependency on PL011UartClockLib in StandaloneMmPkg.dsc 3. GCC flags to enforce strict

Re: [edk2] [PATCH v2 7/7] ArmPkg: Extra action to update permissions for S-ELO MM Image

2018-11-09 Thread Achin Gupta
1384.html On Wed, Oct 24, 2018 at 08:05:22AM -0300, Ard Biesheuvel wrote: > On 24 October 2018 at 05:22, Achin Gupta wrote: > > Hi Ard, > > > > Please see CIL.. > > > > FYI I will be on leave until 5th of November, so I will get to this > once I get back. >

Re: [edk2] [PATCH v2 7/7] ArmPkg: Extra action to update permissions for S-ELO MM Image

2018-10-24 Thread Achin Gupta
21 at 20:06 +0900, Ard Biesheuvel wrote: > >> > On 20 July 2018 at 21:38, Sughosh Ganu wrote: > >> > > > >> > > From: Achin Gupta > >> > > > >> > > The Standalone MM drivers runs in S-EL0 in AArch64 on ARM Standard > >> >

Re: [edk2] Missing Library in StandaloneMmPkg

2018-10-15 Thread Achin Gupta
> >Thanks, > > >Eugene > > >From: Supreeth Venkatesh >Sent: Monday, October 15, 2018 1:49 PM >To: Cohen, Eugene ; edk2-devel@lists.01.org; Achin Gupta >; Jiewen Yao ; Sughosh Ganu > >Cc: Dong Wei >Subject: RE: Missin

Re: [edk2] [PATCH v2 7/7] ArmPkg: Extra action to update permissions for S-ELO MM Image

2018-08-28 Thread Achin Gupta
On Sat, 2018-07-21 at 20:06 +0900, Ard Biesheuvel wrote: > >> > On 20 July 2018 at 21:38, Sughosh Ganu wrote: > >> > > > >> > > From: Achin Gupta > >> > > > >> > > The Standalone MM drivers runs in S-EL0 in AArch64 on ARM Standard

Re: [edk2] [PATCH 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-08-28 Thread Achin Gupta
Hi Sumit, Apologies for not replying sooner. Some questions and thoughts inline. On Mon, Aug 27, 2018 at 03:28:52PM +0530, Sumit Garg wrote: > On Fri, 24 Aug 2018 at 23:33, Matteo Carlini wrote: > > > > +Achin > > > > SPD (for OP-TEE and other Trusted-OSes payloads running at S-EL1) and SPM >

Re: [edk2] [PATCH v2 09/10] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.

2018-07-19 Thread Achin Gupta
Thanks Sughosh. Reviewed-by: Achin Gupta On Fri, Jul 13, 2018 at 08:35:29PM +0530, Sughosh Ganu wrote: > From: Supreeth Venkatesh > > This patch adds a simple CPU driver that exports the > EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone > MM Foundat

Re: [edk2] [PATCH v2 08/10] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-07-19 Thread Achin Gupta
Thanks Sughosh. Reviewed-by: Achin Gupta On Fri, Jul 13, 2018 at 08:35:28PM +0530, Sughosh Ganu wrote: > From: Supreeth Venkatesh > > The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard > Platforms and is initialised during the SEC phase. ARM Trusted firmw

Re: [edk2] [PATCH 09/10] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.

2018-07-09 Thread Achin Gupta
t; mechanism for the configuration protocol. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Cc: Jiewen Yao > Cc: Achin Gupta > --- > .../Drivers/Standalo

Re: [edk2] [PATCH 08/10] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-07-09 Thread Achin Gupta
an entry point module that ARM Trusted Firmware > jumps to in S-EL0. It then performs the above actions before calling the > Standalone MM Foundation entry point and handling subsequent MM events. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin G

Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

2018-06-19 Thread Achin Gupta
Hi Jiewen, On Mon, Jun 18, 2018 at 03:12:46PM +, Yao, Jiewen wrote: > Yes. I think so. > > However, I found the V3 just contains partial of the patch. It is hard to > find some V2 and some V3. > Also this series includes multiple package. We need different package > maintainer to push

Re: [edk2] [PATCH v1 17/18] StandaloneMmPkg: Add application to test MM communication protocol.

2018-04-30 Thread Achin Gupta
o pass a copy of the UEFI system table to > the MM environment in the secure world. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> >

Re: [edk2] [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules.

2018-04-30 Thread Achin Gupta
EM_TABLE2 to > EFI_MM_SYSTEM_TABLE. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> -Achin & +Jiewen if possible! Acked-by: Achin Gupta <achin.gu...@arm.com> cheers, Achin > Signed-off-by: Supree

Re: [edk2] [PATCH v1 15/18] ArmPkg: Extra action to update permissions for S-ELO MM Image.

2018-04-30 Thread Achin Gupta
section parsing, this patch implements extra action > "UpdatePeCoffPermissions" to request the privileged firmware in EL3 to > update the permissions. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > S

Re: [edk2] [PATCH v1 14/18] StandaloneMmPkg: Describe the declaration, definition and fdf files.

2018-04-30 Thread Achin Gupta
nder: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > StandaloneMmPkg/StandaloneMmPkg.dec | 47 + > StandaloneMmPkg/StandaloneMmPkg.dsc | 132 +++

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

2018-04-30 Thread Achin Gupta
rts the > EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone > MM Foundation entry point. It preserves the existing notification > mechanism for the configuration protocol. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com>

Re: [edk2] [PATCH v1 11/18] StandaloneMmPkg: MM driver entry point library.

2018-04-30 Thread Achin Gupta
Hi Supreeth, Some of the DXE references will have to be removed and copyright years need to be updated. If that sounds reasonable then.. Acked-by: Achin Gupta <achin.gu...@arm.com> cheers, Achin On Fri, Apr 06, 2018 at 03:42:16PM +0100, Supreeth Venkatesh wrote: > This patch implemen

Re: [edk2] [PATCH v1 10/18] StandaloneMmPkg/HobLib: Add AARCH64 Specific HOB Library for management mode.

2018-04-25 Thread Achin Gupta
core need to be removed and the copyright years needs to be updated. I think it is worth getting this hoblib reviewed by the ArmPkg maintainers. Acked-by: Achin Gupta <achin.gu...@arm.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin G

Re: [edk2] [PATCH v1 09/18] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.

2018-04-25 Thread Achin Gupta
ise. On Arm, the gEfiMmPeiMmramMemoryReserveGuid HOB is used to convey the MMRAM ranges. It seems x86 uses gMmCoreDataHobGuid HOB. So it worth getting this reviewed by Jiewen. The copyright years in the files need to be updated. With that in mind.. Acked-by: Achin Gupta <achin.gu...@arm.com> >

Re: [edk2] [PATCH v1 08/18] StandaloneMmPkg/MemLib: AARCH64 Specific instance of memory check library.

2018-04-25 Thread Achin Gupta
the case then only the generic library will be required minus this function. cheers, Achin > > Thank you > Yao Jiewen > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Achin > > Gupta > > Sent: Monday, Apr

Re: [edk2] [PATCH v1 08/18] StandaloneMmPkg/MemLib: AARCH64 Specific instance of memory check library.

2018-04-16 Thread Achin Gupta
and valid. It also provides functions for copy data > from MMRAM to non-MMRAM, from non-MMRAM to MMRAM, > from non-MMRAM to non-MMRAM, or set data in non-MMRAM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> >

Re: [edk2] [PATCH v1 07/18] StandaloneMmPkg/FvLib: Add a common FV Library for management mode.

2018-04-16 Thread Achin Gupta
1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> I have not contributed to this patch at all. Could you please remove me? Not being an expert, I will wait for Jiewen's feedback cycle to complete. cheers, Achin > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.co

Re: [edk2] [PATCH v1 06/18] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-04-16 Thread Achin Gupta
irmware > jumps to in S-EL0. It then performs the above actions before calling the > Standalone MM Foundation entry point and handling subsequent MM events. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> >

Re: [edk2] [PATCH v1 05/18] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.

2018-04-11 Thread Achin Gupta
initialization and hence defined as MM_CORE_STANDALONE Module. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > A

Re: [edk2] [PATCH v1 04/18] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-04-11 Thread Achin Gupta
rom higher exception levels. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuSecLib.c | 146 >

Re: [edk2] [PATCH v1 01/18] ArmPkg: Add PCDs needed for MM communication driver.

2018-04-11 Thread Achin Gupta
ution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > ArmPkg/ArmPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec >

Re: [edk2] [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return codes.

2018-04-11 Thread Achin Gupta
artitions too. cheers, Achin > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++

Re: [edk2] [PATCH v1 02/18] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-04-11 Thread Achin Gupta
M environment in the secure world. > > This patch also adds the MM Communication driver (.inf) file to > define entry point for this driver and other compile > related information the driver needs. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by

[edk2] [edk2 PATCH v2 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

2018-02-15 Thread achin . gupta
From: Achin Gupta <achin.gu...@arm.com> This patch adds maintainers, reviewer and directory for the StandaloneMmPkg. This package will host an implementation of Standalone Management Mode as specified in the Platform Initialization (PI) Specification, Volume 4: Management Mode Core Int

[edk2] [edk2 PATCH v2 0/1] *** Add StandaloneMmPkg and maintainers ***

2018-02-15 Thread achin . gupta
From: Achin Gupta <achin.gu...@arm.com> PI Specification v1.5 "Volume 4: Management Mode Core Interface" introduces the concept of MM Standalone Mode. The StandaloneMmPkg will host an implementation of this feature. Development of this package was done in edk2-staging [1]

[edk2] [edk2 PATCH v1 1/1] Maintainers.txt: Add StandaloneMmPkg and maintainers

2018-02-15 Thread achin . gupta
From: Achin Gupta <achin.gu...@arm.com> This patch adds maintainers, reviewer and directory for the StandaloneMmPkg. This package will host an implementation of Standalone Management Mode as specified in the Platform Initialization (PI) Specification, Volume 4: Management Mode Core Int

[edk2] [edk2 PATCH v1 0/1] *** Add StandaloneMmPkg and maintainers ***

2018-02-15 Thread achin . gupta
From: Achin Gupta <achin.gu...@arm.com> PI Specification v1.5 "Volume 4: Management Mode Core Interface" introduces the concept of MM Standalone Mode. The StandaloneMmPkg will host an implementation of this feature. Development of this package was done in edk2-staging [1]

[edk2] Creation of StandaloneMmPkg

2018-01-29 Thread Achin Gupta
Hi All, SOme of you might be aware that me and Supreeth have been working on adding support for Standalone MM on AArch64. The work is based on Jiewen's patches for x86 and was being tracked in this edk2-staging branch [1]. This work looked good enough to post on edk2-devel late last year and

Re: [edk2] [PATCH v2 2/3] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2017-10-26 Thread Achin Gupta
Interface_Specification.pdf > to communicate with the standalone MM environment in the secure world. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat.

Re: [edk2] [PATCH v1 0/3] *** EFI_MM_COMMUNICATION_PROTOCOL ***

2017-10-12 Thread Achin Gupta
On Thu, Oct 12, 2017 at 12:43:13PM -0500, Supreeth Venkatesh wrote: > On Thu, 2017-10-12 at 18:38 +0100, Achin Gupta wrote: > > Hi Supreeth, > > > > Could you acknowledge me as a contributor in the relevant patches and > > repost? > Can sure do as done in previous pa

Re: [edk2] [PATCH v1 0/3] *** EFI_MM_COMMUNICATION_PROTOCOL ***

2017-10-12 Thread Achin Gupta
Hi Supreeth, Could you acknowledge me as a contributor in the relevant patches and repost? cheers, Achin On Thu, Oct 12, 2017 at 06:13:49PM +0100, Supreeth Venkatesh wrote: > *** > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL.

Re: [edk2] [PATCH 1/1] ArmPkg/Include: Update MM interface return codes to match specification.

2017-10-12 Thread Achin Gupta
Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Arm

Re: [edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

2017-10-09 Thread Achin Gupta
yways, lets take this offline. For the time being, the code should match the spec. cheers, Achin > > Thanks, > Supreeth > -Original Message- > From: Achin Gupta > Sent: Monday, October 9, 2017 3:52 AM > To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Supreeth

Re: [edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

2017-10-09 Thread Achin Gupta
on(s) available to the normal world: > > 1. Request services from the secure MM environment using MM_COMMUNICATE. > > > > It also defines MM return codes. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta <achin.gu...@a

Re: [edk2] [PATCH 1/1] ArmPkg/Include: Add standard SMC and SVC function IDs for MM interface.

2017-09-22 Thread Achin Gupta
chin > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > --- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 46 >

[edk2] [staging/apei]: New branch request for APEI work

2017-05-25 Thread Achin Gupta
Error Interfaces (APEI) on ARMv8-A standard platforms. The branch owners: Achin Gupta <achin.gu...@arm.com>, James Morse <james.mo...@arm.com> # Feature Introduction The ACPI specification describes APEI which provide a mechanism for the firmware to convey error information to OSPM.

Re: [edk2] [PATCH] kvm: pass the virtual SEI syndrome to guest OS

2017-03-29 Thread Achin Gupta
> > > On 2017/3/28 21:40, James Morse wrote: > > Hi gengdongjiu, > > > > On 28/03/17 13:16, gengdongjiu wrote: > >> On 2017/3/28 19:54, Achin Gupta wrote: > >>> On Tue, Mar 28, 2017 at 01:23:28PM +0200, Christoffer Dall wrote: > >>>> O

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressPkg: Fix memory attributes for NOR Flash

2017-01-20 Thread Achin Gupta
Hi Ard, On Thu, Jan 19, 2017 at 10:01:07PM +, Ard Biesheuvel wrote: > On 19 January 2017 at 21:57, Achin Gupta <achin.gu...@arm.com> wrote: > > Hi Ard, > > > > On Thu, Jan 19, 2017 at 06:16:00PM +, Ard Biesheuvel wrote: > >> On 19 January 2017 at 12:

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressPkg: Fix memory attributes for NOR Flash

2017-01-19 Thread Achin Gupta
Hi Ard, On Thu, Jan 19, 2017 at 06:16:00PM +, Ard Biesheuvel wrote: > On 19 January 2017 at 12:31, Achin Gupta <achin.gu...@arm.com> wrote: > > Hi Leif/Ard, > > > > On Wed, Jan 18, 2017 at 10:05:00PM +, Leif Lindholm wrote: > >> Hi Achin, > >>

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressPkg: Fix memory attributes for NOR Flash

2017-01-19 Thread Achin Gupta
Hi Leif/Ard, On Wed, Jan 18, 2017 at 10:05:00PM +, Leif Lindholm wrote: > Hi Achin, > > On Wed, Jan 18, 2017 at 08:24:06PM +, achin.gu...@arm.com wrote: > > From: Achin Gupta <achin.gu...@arm.com> > > > > The NOR flash banks were being mapped in the tran

Re: [edk2] Relocation fixup during AARCH64 SEC PE-COFF generation?

2016-09-13 Thread Achin Gupta
On Tue, Sep 13, 2016 at 04:25:32PM +0100, Ard Biesheuvel wrote: > On 13 September 2016 at 16:16, Achin Gupta <achin.gu...@arm.com> wrote: > > On Tue, Sep 13, 2016 at 03:43:41PM +0100, Ard Biesheuvel wrote: > >> On 13 September 2016 at 15:12, Ard Biesheuvel <ard.biesheu

Re: [edk2] Relocation fixup during AARCH64 SEC PE-COFF generation?

2016-09-13 Thread Achin Gupta
On Tue, Sep 13, 2016 at 03:43:41PM +0100, Ard Biesheuvel wrote: > On 13 September 2016 at 15:12, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: > > On 13 September 2016 at 15:03, Achin Gupta <achin.gu...@arm.com> wrote: > >> Hi All, > >> > >

[edk2] Relocation fixup during AARCH64 SEC PE-COFF generation?

2016-09-13 Thread Achin Gupta
Hi All, Upon entry into UEFI, the ArmPlatformPkg/PrePi/PeiUniCore.inf SEC module executes directly from within the firmware volume. The FV would typically be loaded in DRAM by ARM Trusted Firmware. The rule in ArmJuno.fdf for SEC file types converts a PE-COFF module into a stripped Terse

Re: [edk2] Adding a memory region to GCD on AARCH64?

2016-06-27 Thread Achin Gupta
Hi Laszlo, On Thu, Jun 23, 2016 at 04:38:03PM +0200, Laszlo Ersek wrote: > On 06/23/16 16:19, Achin Gupta wrote: > > Hi Laszlo, > > > > On Wed, Jun 22, 2016 at 09:56:11PM +0200, Laszlo Ersek wrote: > >> On 06/22/16 20:53, Achin Gupta wrote: > >>> Hi All

Re: [edk2] Adding a memory region to GCD on AARCH64?

2016-06-23 Thread Achin Gupta
Hi Laszlo, On Wed, Jun 22, 2016 at 09:56:11PM +0200, Laszlo Ersek wrote: > On 06/22/16 20:53, Achin Gupta wrote: > > Hi All, > > > > I having some trouble trying an experiment on the AARCH64 Base FVP with > > UEFI and > > ARM Trusted Firmware. There is a buffe

[edk2] Adding a memory region to GCD on AARCH64?

2016-06-22 Thread Achin Gupta
Hi All, I having some trouble trying an experiment on the AARCH64 Base FVP with UEFI and ARM Trusted Firmware. There is a buffer that is allocated by the latter in DRAM with TZC-400 attributes that allow non-secure access. Its extents are made available to a UEFI DXE driver through an SMC. AFAIU,

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Achin Gupta
On Wed, May 11, 2016 at 12:07:51PM +0200, Ard Biesheuvel wrote: > On 11 May 2016 at 11:35, Achin Gupta <achin.gu...@arm.com> wrote: > > Hi Ard, > > > > Some comments inline! > > > > On Wed, May 11, 2016 at 10:41:57AM +0200, Ard Biesheuvel wrote: > >&g

Re: [edk2] [PATCH] ArmPkg/ArmLib: don't invalidate entire I-cache on range operation

2016-05-11 Thread Achin Gupta
Hi Ard, Some comments inline! On Wed, May 11, 2016 at 10:41:57AM +0200, Ard Biesheuvel wrote: > Instead of cleaning the data cache to the PoU by virtual address and > subsequently invalidating the entire I-cache, invalidate only the > range that we just cleaned. This way, we don't invalidate

Re: [edk2] I$ maintenance in ArmCacheMaintenanceLib.c

2016-05-10 Thread Achin Gupta
by MVA to PoU DSB; Ensure completion of the invalidations ISB; Synchronize fetched instruction stream thanks, Achin On Tue, May 10, 2016 at 09:46:03AM +0100, Achin Gupta wrote: > Thanks Eugene! Thought as much but wanted to be sure

[edk2] Building a SMM_CORE module as an XIP image

2016-04-06 Thread Achin Gupta
Hi All, I am prototyping the proposal made in ECR #1390 (MM in Standalone mode etc) on the Juno and FVP ARM development platforms. The prototype mainly has a module of type SMM_CORE that contains: a. The MM Foundation code in Standalone mode. Lets call the entry point of this module