Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-12 Thread Bjorge, Erik C
, October 9, 2015 11:11 AM To: Laszlo Ersek <ler...@redhat.com>; Bjorge, Erik C <erik.c.bjo...@intel.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script On 2015-10-09 10:57:40, Laszlo Ersek wrote

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-10 Thread Leif Lindholm
On Sat, Oct 10, 2015 at 08:45:19AM -0700, Jordan Justen wrote: > On 2015-10-10 04:07:22, Leif Lindholm wrote: > > On Wed, Oct 07, 2015 at 07:53:18PM -0700, Jordan Justen wrote: > > > This script can be used to check some expected rules for EDK II > > > patches. It only works on git formatted

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-09 Thread Laszlo Ersek
On 10/09/15 19:13, Bjorge, Erik C wrote: > The patch has some trailing white spaces Apparently, Jordan forgot to run the script on the patch that adds the script! ;) Laszlo > but other than that it works fine. > > Reviewed-by: Erik Bjorge > > -Original

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-09 Thread Jordan Justen
On 2015-10-08 15:22:08, Laszlo Ersek wrote: > On 10/08/15 04:53, Jordan Justen wrote: > > This script can be used to check some expected rules for EDK II > > patches. It only works on git formatted patches. > > > > It checks both the commit message and the lines that are added in the > > patch

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-08 Thread Laszlo Ersek
On 10/08/15 04:53, Jordan Justen wrote: > This script can be used to check some expected rules for EDK II > patches. It only works on git formatted patches. > > It checks both the commit message and the lines that are added in the > patch diff. > > In the commit message it verifies line lengths,

[edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-07 Thread Jordan Justen
This script can be used to check some expected rules for EDK II patches. It only works on git formatted patches. It checks both the commit message and the lines that are added in the patch diff. In the commit message it verifies line lengths, signature formats, and the Contributed-under tag. In