Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Vladimir Olovyannikov
devel@lists.01.org; Laszlo Ersek > Subject: Re: [edk2] [PATCH] GPT Shell Application/Library > > 1. Create this new shared library in MdeModulePkg. > 2. For parameters: Other than standard parameters defined in Shell > specification I would suggest to follow single character flag wher

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Laszlo Ersek
Shala; edk2-devel@lists.01.org >> Subject: Re: [edk2] [PATCH] GPT Shell Application/Library >> >> On 10/18/16 18:58, Vladimir Olovyannikov wrote: >>> Thank you all for comments, >>> >>> So to summarize the discussion: >>> >>> 1. I will

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Shah, Tapan
gt;; Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [edk2] [PATCH] GPT Shell Application/Library For the standards, I would try to use the UEFI Shell Spec for some parameters. For Example: -v for verbose -h for help -sfo for standard format output > -Original Message- > Fr

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Vladimir Olovyannikov
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: October-18-16 10:24 AM > To: Vladimir Olovyannikov; Shah, Tapan; Carsey, Jaben; Michael Zimmermann > Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] GPT Shell A

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Laszlo Ersek
-18-16 6:59 AM > To: Carsey, Jaben; Vladimir Olovyannikov; Michael Zimmermann > Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org; Laszlo Ersek > Subject: Re: [edk2] [PATCH] GPT Shell Application/Library > > Thanks for the contribution Vladimir! > > Few comments: > 1. It's

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Carsey, Jaben
devel@lists.01.org <edk2-de...@ml01.01.org>; Laszlo Ersek > <ler...@redhat.com> > Subject: Re: [edk2] [PATCH] GPT Shell Application/Library > Importance: High > > Thank you all for comments, > > So to summarize the discussion: > > 1. I will create a Shell library

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-18 Thread Vladimir Olovyannikov
...@lists.01.org] On Behalf Of Shah, Tapan Sent: October-18-16 6:59 AM To: Carsey, Jaben; Vladimir Olovyannikov; Michael Zimmermann Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org; Laszlo Ersek Subject: Re: [edk2] [PATCH] GPT Shell Application/Library Thanks for the contribution Vladimir! Few

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Carsey, Jaben
devel@lists.01.org <edk2-de...@ml01.01.org> Subject: RE: [edk2] [PATCH] GPT Shell Application/Library Importance: High Hi Michael, I am absolutely agree with your proposal. In the gpt Shell library/application I had to “borrow” some stuff from PartitionDxe.c to not reinvent a wheel. If the

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Vladimir Olovyannikov
partition) from within the Shell. What do you think? Thank you, Vladimir *From:* Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] *Sent:* October-17-16 12:25 AM *To:* Vladimir Olovyannikov *Cc:* Laszlo Ersek; Jaben Carsey; Ni, Ruiyu; edk2-devel@lists.01.org *Subject:* Re: [edk2] [PATCH] GPT

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Carsey, Jaben
Sent: Monday, October 17, 2016 2:44 AM > To: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org> > Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Laszlo Ersek
On 10/17/16 08:49, Vladimir Olovyannikov wrote: > Thank you Laszlo, > > Sorry, I missed the fields; it is my first contribution, I will add the > required lines, review the source according to your comments and will > resubmit the patch. > So do you think the command should be _gpt instead of

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Michael Zimmermann
Hi, wouldn't it be better to make a generic gpt parsing library which is independent of the shell so both the shell and PartitionDxe can use it? It may also be useful for other applications which need additional information like the gpt partition names. Thanks Michael On Mon, Oct 17, 2016 at

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-17 Thread Vladimir Olovyannikov
Thank you Laszlo, Sorry, I missed the fields; it is my first contribution, I will add the required lines, review the source according to your comments and will resubmit the patch. So do you think the command should be _gpt instead of gpt? I was following TFTP and SF commands as a template. Thank

Re: [edk2] [PATCH] GPT Shell Application/Library

2016-10-16 Thread Laszlo Ersek
On 10/16/16 07:23, Vladimir Olovyannikov wrote: > This allows managing (create, delete, modify, fat format) of GPT > partitions from within UEFI Shell. > Syntax: > gpt [device_mapped_name] [parameters...] > See usage examples in the .uni file > --- >