Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-11 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 02:48, Wu, Hao A wrote: > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Saturday, December 08, 2018 6:25 PM > > To: edk2-devel@lists.01.org > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Ard Biesheuvel > > Subject: [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-10 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Saturday, December 08, 2018 6:25 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Ard Biesheuvel > Subject: [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for > progra

Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-10 Thread Leif Lindholm
26 PM > > To: Ard Biesheuvel > > Cc: Wu, Hao A ; Ni, Ruiyu ; > > edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed > > struct for program data > > > > On Sat, Dec 08, 2018 at 11:24:31AM +0100, Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-10 Thread Gao, Liming
Sent: Monday, December 10, 2018 8:26 PM > To: Ard Biesheuvel > Cc: Wu, Hao A ; Ni, Ruiyu ; > edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct > for program data > > On Sat, Dec 08, 2018 at 11:24:31AM +0100, Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-10 Thread Leif Lindholm
On Sat, Dec 08, 2018 at 11:24:31AM +0100, Ard Biesheuvel wrote: > Struct packing is only necessary for data structures whose in-memory > representation is covered by the PI or UEFI specs, and may deviate > from the ordinary C rules for alignment. > > So in case of FileExplorerLib, this applies to

[edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-08 Thread Ard Biesheuvel
Struct packing is only necessary for data structures whose in-memory representation is covered by the PI or UEFI specs, and may deviate from the ordinary C rules for alignment. So in case of FileExplorerLib, this applies to the device path struct only, and other structures used to carry program da