Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-23 Thread Zeng, Star
rom: Ni, Ruiyu Sent: Thursday, October 19, 2017 11:03 AM To: Laszlo Ersek ; Julien Grall ; Zeng, Star ; Dong, Eric ; pankaj.ban...@nxp.com; leif.lindh...@linaro.org Cc: edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not suppor

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-23 Thread Julien Grall
Hi Laszlo, On 18/10/17 13:11, Laszlo Ersek wrote: On 10/18/17 12:19, Julien Grall wrote: After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change serial attributes", serial is initialized using the reset method that will call SetAttributes. However, SetAttributes may not be supp

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-18 Thread Ni, Ruiyu
> To: Julien Grall ; Zeng, Star ; > Dong, Eric ; pankaj.ban...@nxp.com; > leif.lindh...@linaro.org > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset > when SetAttributes is not supported > > On 10/18/17 12:19, Julien Gral

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-18 Thread Laszlo Ersek
On 10/18/17 12:19, Julien Grall wrote: > After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change > serial attributes", serial is initialized using the reset method that > will call SetAttributes. > > However, SetAttributes may not be supported by the driver and will > return an err

[edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

2017-10-18 Thread Julien Grall
After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change serial attributes", serial is initialized using the reset method that will call SetAttributes. However, SetAttributes may not be supported by the driver and will return an error (i.e RETURN_UNSUPPORTED) that will be propagate