[edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Star Zeng
PcdSet## has no error status returned, then the caller has no idea about whether the set operation is successful or not. PcdSet##S were added to return error status and PcdSet## APIs were put in ifndef DISABLE_NEW_DEPRECATED_INTERFACES condition. To adopt PcdSet##S and further code development

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Yao, Jiewen
Looks good. -Original Message- From: Zeng, Star Sent: Thursday, October 08, 2015 3:40 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Gao, Liming Subject: [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64 PcdSet## has no error status returned, then the

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Andrew Fish
> On Oct 8, 2015, at 3:11 PM, Laszlo Ersek wrote: > > On 10/08/15 09:39, Star Zeng wrote: >> PcdSet## has no error status returned, then the caller has no idea about >> whether the set operation is successful or not. >> PcdSet##S were added to return error status and

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Laszlo Ersek
On 10/08/15 09:39, Star Zeng wrote: > PcdSet## has no error status returned, then the caller has no idea about > whether the set operation is successful or not. > PcdSet##S were added to return error status and PcdSet## APIs were put in > ifndef DISABLE_NEW_DEPRECATED_INTERFACES condition. > To

Re: [edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use PcdSet64S to instead of PcdSet64

2015-10-08 Thread Zeng, Star
On 2015/10/9 6:33, Andrew Fish wrote: On Oct 8, 2015, at 3:11 PM, Laszlo Ersek wrote: On 10/08/15 09:39, Star Zeng wrote: PcdSet## has no error status returned, then the caller has no idea about whether the set operation is successful or not. PcdSet##S were added to