Re: [edk2] [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__

2017-12-07 Thread Leif Lindholm
On Thu, Dec 07, 2017 at 03:09:17AM +, Gao, Liming wrote: > Reviewed-by: Liming Gao Thanks! Pushed as 5b8766bb92. > >-Original Message- > >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > >Sent: Thursday, December 07, 2017 1:08 AM > >To:

Re: [edk2] [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__

2017-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, December 07, 2017 1:08 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >;

Re: [edk2] [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__

2017-12-06 Thread Ard Biesheuvel
On 6 December 2017 at 17:07, Leif Lindholm wrote: > clang, when used as a preprocessor for dtc, does not discard #pragma > statements although -x assembler-with-cpp is specified. This causes dtc > to barf at a #pragma pack() statement that is already filtered out for >

[edk2] [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__

2017-12-06 Thread Leif Lindholm
clang, when used as a preprocessor for dtc, does not discard #pragma statements although -x assembler-with-cpp is specified. This causes dtc to barf at a #pragma pack() statement that is already filtered out for __GNUC__. So add a check to also filter this out if __ASSEMBLER__. Contributed-under: