Re: [edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

2017-11-28 Thread Laszlo Ersek
On 11/28/17 11:14, Gao, Liming wrote: > This is VS CL issue. It preprocesses below FixedPcdGet32() to the fixed > value, but lost '\'. So, it will cause nasm compiler failure. To avoid it, we > need to make sure FixedPcdGet32 (PcdInitValueInTempStack) at one line. > > FixedPcdGet32 (

Re: [edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

2017-11-28 Thread Gao, Liming
This is VS CL issue. It preprocesses below FixedPcdGet32() to the fixed value, but lost '\'. So, it will cause nasm compiler failure. To avoid it, we need to make sure FixedPcdGet32 (PcdInitValueInTempStack) at one line. FixedPcdGet32 (\

Re: [edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

2017-11-27 Thread Laszlo Ersek
Hi Ray, adding Ard, Jordan, Liming and Yonghong: On 11/27/17 02:38, Ruiyu Ni wrote: > Original code breaks a single assembly code to multiple lines. > But build tool doesn't support such usage in Windows OS environment. > > Changing the multiple lines to one line to resolve the build failure. >

[edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

2017-11-26 Thread Ruiyu Ni
Original code breaks a single assembly code to multiple lines. But build tool doesn't support such usage in Windows OS environment. Changing the multiple lines to one line to resolve the build failure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni