Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread zhengxiang (A)
Hi Maxime, On 2018/1/11 22:46, Maxime Coquelin wrote: > > > On 01/11/2018 02:23 PM, Maxime Coquelin wrote: >> Hi Xiang, >> >> On 12/14/2017 02:25 PM, zhengxiang (A) wrote: >>> >>> >>> On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: > Hello Laszlo

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread Maxime Coquelin
On 01/11/2018 02:23 PM, Maxime Coquelin wrote: Hi Xiang, On 12/14/2017 02:25 PM, zhengxiang (A) wrote: On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: Hello Laszlo and Paolo, Thanks for your review! On 2017/12/13 19:16, Laszlo Ersek wrote: On

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2018-01-11 Thread Maxime Coquelin
Hi Xiang, On 12/14/2017 02:25 PM, zhengxiang (A) wrote: On 2017/12/14 17:06, Paolo Bonzini wrote: On 14/12/2017 07:55, zhengxiang (A) wrote: Hello Laszlo and Paolo, Thanks for your review! On 2017/12/13 19:16, Laszlo Ersek wrote: On 12/13/17 10:29, Paolo Bonzini wrote: On 13/12/2017

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-14 Thread zhengxiang (A)
On 2017/12/14 17:06, Paolo Bonzini wrote: > On 14/12/2017 07:55, zhengxiang (A) wrote: >> Hello Laszlo and Paolo, >> >> Thanks for your review! >> >> On 2017/12/13 19:16, Laszlo Ersek wrote: >>> On 12/13/17 10:29, Paolo Bonzini wrote: On 13/12/2017 09:35, Laszlo Ersek wrote: > Perhaps

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 07:55, zhengxiang (A) wrote: > Hello Laszlo and Paolo, > > Thanks for your review! > > On 2017/12/13 19:16, Laszlo Ersek wrote: >> On 12/13/17 10:29, Paolo Bonzini wrote: >>> On 13/12/2017 09:35, Laszlo Ersek wrote: Perhaps you can update vhost-scsi similarly to the last patch

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-13 Thread zhengxiang (A)
Hello Laszlo and Paolo, Thanks for your review! On 2017/12/13 19:16, Laszlo Ersek wrote: > On 12/13/17 10:29, Paolo Bonzini wrote: >> On 13/12/2017 09:35, Laszlo Ersek wrote: >>> I consider the lack of a "VIRTIO_SCSI_F_MQ" feature bit an issue with >>> the virtio specification (and consequently

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-13 Thread Laszlo Ersek
On 12/13/17 10:29, Paolo Bonzini wrote: > On 13/12/2017 09:35, Laszlo Ersek wrote: >> I consider the lack of a "VIRTIO_SCSI_F_MQ" feature bit an issue with >> the virtio specification (and consequently with vhost-scsi), not with >> the guest driver(s). > > VIRTIO_SCSI_F_MQ does not exist because

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-13 Thread Laszlo Ersek
On 12/13/17 10:29, Paolo Bonzini wrote: > On 13/12/2017 09:35, Laszlo Ersek wrote: >> I consider the lack of a "VIRTIO_SCSI_F_MQ" feature bit an issue with >> the virtio specification (and consequently with vhost-scsi), not with >> the guest driver(s). > > VIRTIO_SCSI_F_MQ does not exist because

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-13 Thread Paolo Bonzini
On 13/12/2017 09:35, Laszlo Ersek wrote: > I consider the lack of a "VIRTIO_SCSI_F_MQ" feature bit an issue with > the virtio specification (and consequently with vhost-scsi), not with > the guest driver(s). VIRTIO_SCSI_F_MQ does not exist because virtio-scsi has _always_ supported multiqueue and

Re: [edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-13 Thread Laszlo Ersek
Hello Zheng Xiang, I'm adding Maxime for DPDK / vhost-scsi expertise, and Paolo for general virtio-scsi expertise: On 12/13/17 04:16, Zheng Xiang wrote: > VirtioScsiInit() allocate only one request queue which causes the > address of the other vrings to be 0. In AARCH64 virtual machines, > the

[edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

2017-12-12 Thread Zheng Xiang
VirtioScsiInit() allocate only one request queue which causes the address of the other vrings to be 0. In AARCH64 virtual machines, the address of system memory starts at 0x4000 and the address of rom starts at 0. This causes an error when QEMU translates the guest physical memory of