Re: [edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Ni, Ruiyu
Sorry about the failure and thank you all for the quick fix. Sent from a small-screen device 在 2017年9月22日，下午10:53，Laszlo Ersek > 写道： On 09/22/17 16:00, Carsey, Jaben wrote: Reviewed-by: Jaben Carsey

Re: [edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Laszlo Ersek
On 09/22/17 16:00, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey Thank you both; pushed as commit ba30d5f05121. Laszlo >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Friday, September 22, 2017 6:44 AM >> To: Laszlo

Re: [edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, September 22, 2017 6:44 AM > To: Laszlo Ersek > Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Ni, >

Re: [edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Ard Biesheuvel
On 22 Sep 2017, at 06:34, Laszlo Ersek wrote: >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: error: >> passing argument 2 of 'gEfiShellProtocol->GetGuidName' from incompatible >> pointer type [-Werror=incompatible-pointer-types] >> >> Status =

[edk2] [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure

2017-09-22 Thread Laszlo Ersek
> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: error: > passing argument 2 of 'gEfiShellProtocol->GetGuidName' from incompatible > pointer type [-Werror=incompatible-pointer-types] > > Status = gEfiShellProtocol->GetGuidName(, ); >