Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

2017-12-07 Thread Laszlo Ersek
On 12/07/17 02:49, Star Zeng wrote: > Only DumpCpuContext in error case, otherwise there will be too many > debug messages from DumpCpuContext() when SmmProfile feature is enabled > by setting PcdCpuSmmProfileEnable to TRUE. Those debug messages are not > needed for SmmProfile feature as it will

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

2017-12-06 Thread Zeng, Star
That will be in another patch. :) Thanks, Star -Original Message- From: Yao, Jiewen Sent: Thursday, December 7, 2017 11:03 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Dong, Eric ; Laszlo Ersek ; Ni, Ruiyu

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

2017-12-06 Thread Yao, Jiewen
Good enhancement. Reviewed-by: jiewen@intel.com BTW: I think we should also ASSERT(FALSE) if StaticPage and Smmprofile are both TRUE > -Original Message- > From: Zeng, Star > Sent: Thursday, December 7, 2017 9:49 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

2017-12-06 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Zeng, Star Sent: Thursday, December 7, 2017 9:49 AM To: edk2-devel@lists.01.org Cc: Zeng, Star; Yao, Jiewen; Dong, Eric; Laszlo Ersek; Ni, Ruiyu Subject: [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error

[edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

2017-12-06 Thread Star Zeng
Only DumpCpuContext in error case, otherwise there will be too many debug messages from DumpCpuContext() when SmmProfile feature is enabled by setting PcdCpuSmmProfileEnable to TRUE. Those debug messages are not needed for SmmProfile feature as it will record those information to buffer for