Re: [edk2] [PATCH 0/2] Add two public functions

2018-12-13 Thread Zhang, Shenglei
g; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [PATCH 0/2] Add two public functions > > Please let the subject line give some sort of hint of what is being > done, and to what. "Add two functions" is not substantially more > descriptive than "add 572 char

Re: [edk2] [PATCH 0/2] Add two public functions

2018-12-13 Thread Leif Lindholm
Please let the subject line give some sort of hint of what is being done, and to what. "Add two functions" is not substantially more descriptive than "add 572 characters". In this case, your're moving previously internal string helper functions to BaseLib. On Thu, Dec 13, 2018 at 04:34:37PM +0800

[edk2] [PATCH 0/2] Add two public functions

2018-12-13 Thread Shenglei Zhang
Add two public functions,CharToUpper and AsciiToUpper,and remove the same functional functions,InternalCharToUpper and InternalBaseLibAsciiToUpper. Cc: Michael D Kinney Cc: Liming Gao Cc: Bob Feng Cc: Yonghong Zhu Shenglei Zhang (2): MdePkg/BaseLib: Add two public functions BaseTools/Commo