Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 11:09:32AM -0800, Ard Biesheuvel wrote: > > > @@ -121,11 +124,12 @@ NorFlashCreateInstance ( > > >Instance->Size = NorFlashSize; > > > > > >Instance->BlockIoProtocol.Media = >Media; > > > - Instance->Media.MediaId = MediaId; > > > + Instance->Media.MediaId =

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Laszlo Ersek
On 11/17/18 01:45, Ard Biesheuvel wrote: > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > has its own VendorHw GUID, and instances of NorFlashPlatformLib > describe each bank to the driver, along with the GUID for each. > > This works ok for bare metal platforms, but it

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:05, Leif Lindholm wrote: > > On Fri, Nov 16, 2018 at 04:45:23PM -0800, Ard Biesheuvel wrote: > > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > > has its own VendorHw GUID, and instances of NorFlashPlatformLib > > describe each bank to the driver,

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 04:45:23PM -0800, Ard Biesheuvel wrote: > Currently, each flash bank controlled by ArmPlatformPkg/NorFlashDxe > has its own VendorHw GUID, and instances of NorFlashPlatformLib > describe each bank to the driver, along with the GUID for each. > > This works ok for bare