Re: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-10 Thread Zeng, Star
Sorry, I meant 'called'. -Original Message- From: Zeng, Star Sent: Thursday, August 9, 2018 6:25 PM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star Subject: RE: [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function There is a typo in commit log.

Re: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-09 Thread Laszlo Ersek
On 08/08/18 10:47, shenglei wrote: > The function UnicodeFiFoGetKeyCount that is never calld > has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 > > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- >

Re: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-09 Thread Zeng, Star
There is a typo in commit log. 'calld' should be 'callled'. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Zhang, Shenglei Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH 21/26]

Re: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-08 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a &g

[edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function

2018-08-08 Thread shenglei
The function UnicodeFiFoGetKeyCount that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- .../Universal/Console/TerminalDxe/Terminal.h | 12