Re: [edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-10-11 Thread Evan Lloyd
Thanks, Leif. Some interesting points, and I agree and will strive to comply. I only point out that there MAY be a general pressure to not bother "tidying" where trivia are observed. That is, of course, difficult to prove or quantify. Regards, Evan >-Original Message- >From: Leif

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-10-11 Thread Laszlo Ersek
On 10/11/16 12:23, Evan Lloyd wrote: > Hi Leif. > Please feel free to fix the space change as you see fit and proper, > as it was just incidental tidying up. I would simply drop that hunk for now. While I personally prefer the no-space form, and stick with it consistently in all code I write,

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-10-11 Thread Leif Lindholm
On Tue, Oct 11, 2016 at 10:23:12AM +, Evan Lloyd wrote: > Please feel free to fix the space change as you see fit and proper, > as it was just incidental tidying up. Thanks. > It would be good to have a discussion about the general position, > though. > There are, I am sure, sound reasons

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-10-11 Thread Evan Lloyd
Hi Leif. Please feel free to fix the space change as you see fit and proper, as it was just incidental tidying up. It would be good to have a discussion about the general position, though. There are, I am sure, sound reasons for not rolling these things together (and I knew that, and shouldn't

Re: [edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-10-10 Thread Leif Lindholm
On Wed, Sep 21, 2016 at 09:33:15PM +0100, evan.ll...@arm.com wrote: > From: Alexei > > SerialPortInitialize() set the BaudRate variable (type UINT64) as: > BaudRate = (UINTN)FixedPcdGet64 (PcdUartDefaultBaudRate); > > This commit fixes a potential problem on ARM 32-bit

[edk2] [PATCH 3/3] ArmPlatformPkg: Remove UINTN cast when setting BaudRate.

2016-09-21 Thread evan . lloyd
From: Alexei SerialPortInitialize() set the BaudRate variable (type UINT64) as: BaudRate = (UINTN)FixedPcdGet64 (PcdUartDefaultBaudRate); This commit fixes a potential problem on ARM 32-bit builds, where the UINTN type is defined as UINT32, by removing the cast: