Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Laszlo Ersek
On 03/07/18 16:35, Zhang, Chao B wrote: > Star: >Why do we need to add HashInterfaceHob->SupportedHashMask = 0? > HashInterfaceHob is internally maintained and accessed by HashLibRouterPei. > There is no impact to leave the value after module has been re-shadowed. There seems to be no

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Zeng, Star
018 10:56 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewen@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob Hi On W

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Marc-André Lureau
Hi On Wed, Mar 7, 2018 at 12:24 PM, wrote: > From: Marc-André Lureau > > The ZeroMem() call goes beyond the HashInterfaceHob structure, causing > HOB list corruption. The intent was to clear all but the Identifier, > that is starting

[edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread marcandre . lureau
From: Marc-André Lureau The ZeroMem() call goes beyond the HashInterfaceHob structure, causing HOB list corruption. The intent was to clear all but the Identifier, that is starting from HashInterfaceCount. Quoting Laszlo Ersek: Therefore I think the *first*