Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-05-04 Thread Leif Lindholm
On Fri, May 04, 2018 at 11:29:33AM +0800, Haojian Zhuang wrote: > On 2 May 2018 at 23:14, Leif Lindholm wrote: > >> + { 0xe8a0b000, 0, 8 },// GPIO0 > > > > It would not improve readability to request all of these live-coded > > values to be replaced by #defines, but

Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-05-03 Thread Haojian Zhuang
On 2 May 2018 at 23:14, Leif Lindholm wrote: > On Thu, Mar 08, 2018 at 09:29:50PM +0800, Haojian Zhuang wrote: >> Add gpio platform driver to enable GPIO in HiKey960 platform. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-05-02 Thread Leif Lindholm
On Thu, Mar 08, 2018 at 09:29:50PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey960 platform. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-03-08 Thread Haojian Zhuang
Add gpio platform driver to enable GPIO in HiKey960 platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---

[edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

2018-03-08 Thread Haojian Zhuang
Add gpio platform driver to enable GPIO in HiKey960 platform. Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang ---