Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-19 Thread Jordan Justen
On 2015-11-04 17:04:34, Laszlo Ersek wrote: > On 11/04/15 22:35, Kinney, Michael D wrote: > > Laszlo, > > > > Yes. They are compatible. And I do recommend switching to > > BaseXApicX2ApicLib unconditionally. > > Thanks everyone for the feedback, I'll update the patch. With that change:

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-05 Thread Paolo Bonzini
On 05/11/2015 02:04, Laszlo Ersek wrote: > On 11/04/15 22:35, Kinney, Michael D wrote: >> Laszlo, >> >> Yes. They are compatible. And I do recommend switching to >> BaseXApicX2ApicLib unconditionally. > > Thanks everyone for the feedback, I'll update the patch. > > Paolo, in case this turns

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Brian J. Johnson
mber 04, 2015 2:41 AM To: Paolo Bonzini; edk2-de...@ml01.01.org; Kinney, Michael D; Fan, Jeff; Justen, Jordan L Subject: Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE On 11/04/15 09:48, Paolo Bonzini wrote: On 03/11/2015 22:00, La

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Paolo Bonzini
On 04/11/2015 21:08, Laszlo Ersek wrote: > On 11/04/15 17:55, Kinney, Michael D wrote: >> Laszlo, >> >> BaseXApicX2ApicLib is intended to be used by platforms that support more >> >=256 CPUs. >> >> If the current system configuration is < 256 CPUs, then the platform will >> typically stay in

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
nney, Michael D; Paolo Bonzini; edk2-de...@ml01.01.org; Fan, Jeff; >Justen, Jordan L >Subject: Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance >with x2apic support if SMM_REQUIRE > >On 11/04/15 17:55, Kinney, Michael D wrote: >> Laszlo, >> >> BaseXA

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Kinney, Michael D
th >= 256 VCPUs? Thanks, Mike >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, November 04, 2015 2:41 AM >To: Paolo Bonzini; edk2-de...@ml01.01.org; Kinney, Michael D; Fan, Jeff; >Justen, Jordan L >Subject: Re: [edk2] [PATCH v4 18/41

Re: [edk2] [PATCH v4 18/41] OvmfPkg: select LocalApicLib instance with x2apic support if SMM_REQUIRE

2015-11-04 Thread Laszlo Ersek
On 11/04/15 09:48, Paolo Bonzini wrote: > > > On 03/11/2015 22:00, Laszlo Ersek wrote: >> + >> +!if $(SMM_REQUIRE) == TRUE >> + LocalApicLib|UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf >> +!else >>LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf >> +!endif >> +