Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Ni, Ruiyu
#x27;m *slightly* leaning against this change. If the end- >> user regression >> had really been painful, this workaround would have >> been implemented >> very soon after "edk2-stable201808", not in a last >> minute rush before >> "edk2-stable201811&q

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Kinney, Michael D
, Chao B ; Leif > Lindholm > Cc: Kinney, Michael D ; > edk2-devel@lists.01.org; Yao, Jiewen > > Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device > compatibility issue > > On 11/09/18 15:46, Zhang, Chao B wrote: > > Hi Leif: > >The NTC1310 can wor

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
meta: On 11/09/18 16:55, Leif Lindholm wrote: > On Fri, Nov 09, 2018 at 02:46:40PM +, Zhang, Chao B wrote: >> Hi Leif: >>The NTC1310 can work well with previous EDK2 stable version >>(UDK2018). Interface Cache is a new feature introduced after >>UDK2018. >> So far as we see, it cau

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
> To: Laszlo Ersek > Cc: Kinney, Michael D ; edk2-devel@lists.01.org; > Yao, Jiewen ; Zhang, Chao B > Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue > > On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: >> On 11/09/18 07:02, Zh

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Leif Lindholm
> To: Laszlo Ersek > Cc: Kinney, Michael D ; edk2-devel@lists.01.org; > Yao, Jiewen ; Zhang, Chao B > Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue > > On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: > > On 11/09/18 07:02, Zha

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
, November 9, 2018 7:13 PM To: Laszlo Ersek Cc: Kinney, Michael D ; edk2-devel@lists.01.org; Yao, Jiewen ; Zhang, Chao B Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: > On 11/09/18 07:02, Zhang, Chao B wr

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
Hi All: Let me introduce more background. We enabled Interface type Cache feature because it complies with TCG PTP 1.03 spec (also earlier PTP 00.43) and reduces traffic to communicate with TPM. It by chance addresses defect within some TPM2.0 device that frequent touching InterfaceID regis

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: > On 11/09/18 07:02, Zhang, Chao B wrote: > > Issue Statement: > > TPM InterfaceId cache feature is introduced by > > f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 > > to improve TPM transmission performance and

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
On 11/09/18 07:02, Zhang, Chao B wrote: > Issue Statement: > TPM InterfaceId cache feature is introduced by > f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 > to improve TPM transmission performance and also addresses defects in some > TPM2.0 devices. But some other TPM dev

[edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-08 Thread Zhang, Chao B
Issue Statement: TPM InterfaceId cache feature is introduced by f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 to improve TPM transmission performance and also addresses defects in some TPM2.0 devices. But some other TPM devices like NTC1310 SPI TPM is found function abnorm