Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.

2018-10-29 Thread Dong, Eric
n ; Gao, Liming > > Subject: Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC > build failure. > > Hi Eric, > > This has already been pushed, but for future similar fixes, please add a > commit message specifying: > - What failed. > - Why it failed. >

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.

2018-10-29 Thread Leif Lindholm
Hi Eric, This has already been pushed, but for future similar fixes, please add a commit message specifying: - What failed. - Why it failed. - For which targets. - Versions of toolchain where the failure has been observed. (This does not need to be exhaustive, just mention where the failure has

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.

2018-10-27 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Dong, Eric > Sent: Saturday, October 27, 2018 5:09 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Bi, Dandan > Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. > > Cc: Liming Gao > Cc: Dandan Bi > Con

[edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure.

2018-10-27 Thread Eric Dong
Cc: Liming Gao Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h| 2 +- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- 2 files changed, 2 insertions(+