Re: [edk2] [Patch 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-07 Thread Dong, Eric
Hi Laszlo, Thanks for your detail check, sorry for this mistake. I will send V4 changes and only Cc Ray. I based on do the minimal change rule to create v2 change, so some code may seems ugly. I based on do the clean code rule to create V3 change, so the change may seems big. Thanks, Eric

Re: [edk2] [Patch 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-07 Thread Laszlo Ersek
On 01/07/19 09:24, Ni, Ray wrote: > 1. > How about defining a union for MpService. > typedef union { > EFI_MP_SERVICES_PROTOCOL *Protocol; > EFI_PEI_MP_SERVICES_PPI *Ppi; > } MP_SERVICES; > So a new field as below can be added here: > > MP_SERVICES MpService; > > GetMpService()

[edk2] [Patch 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2019-01-06 Thread Eric Dong
V2: 1. Initialize CpuFeaturesData->MpService in CpuInitDataInitialize and make this function been called at the begin of the initialization. 2. let all other functions use CpuFeaturesData->MpService install of locate the protocol itself. V1: GetProcessorIndex function calls GetMpPpi to