Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-07 Thread Yao, Jiewen
Agree. We should not break Window7. Let’s see the result. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, September 7, 2017 6:58 PM To: Yao, Jiewen ; Wang, Jian J ; Justen, Jordan L Cc:

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-07 Thread Laszlo Ersek
On 09/07/17 03:28, Yao, Jiewen wrote: > OK. Got you. > > I think we can move the zero memory to DxeIpl. > The DxeIpl can check if the 0 is allocated in MemoryAllocationHob, and zero > it if it is not allocated. Regarding the zeroing out of page 0, this solution seems good to me as well. (I

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Yao, Jiewen
OK. Got you. I think we can move the zero memory to DxeIpl. The DxeIpl can check if the 0 is allocated in MemoryAllocationHob, and zero it if it is not allocated. Thank you Yao Jiewen From: Wang, Jian J Sent: Thursday, September 7, 2017 8:41 AM To: Yao, Jiewen ; Laszlo

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Yao, Jiewen
intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] ASSERT in QemuVideoDxe driver during reset On 09/06/17 17:06, Yao, Jiewen wrote: > HI Laszlo > Would you please clarify Window 7

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Wang, Jian J
Hi Jiewen and Laszlo, According to both of your comments: 1. VBE SHIM must be installed to avoid boot failure of Windows 7. 2. Enabling NULL detection should not break existing platforms. Let me clarify a few things in advance. I think there’s a little misunderstanding on this

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Yao, Jiewen
ntel.com>; Wang, Jian J <jian.j.w...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] ASSERT in QemuVideoDxe driver during reset On 09/06/17 13:16, Yao, Jiewen wrote: > HI >

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Gao, Liming
Yao, Jiewen <jiewen@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Justen, Jordan L <jordan.l.jus...@intel.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] ASSERT in QemuVideoDxe driver during reset >

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Laszlo Ersek
On 09/06/17 13:16, Yao, Jiewen wrote: > HI > I think the NULL detection feature should *never* break any existing platform. > No real function should be skipped for PcdNullDetection. > > If InstallVbeShim () is needed for CSM, we should always call > InstallVbeShim() for CSM. Wait a second

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Yao, Jiewen
HI I think the NULL detection feature should *never* break any existing platform. No real function should be skipped for PcdNullDetection. If InstallVbeShim () is needed for CSM, we should always call InstallVbeShim() for CSM. I suggest below options: 1) In OVMF, if CSM is enabled,

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Laszlo Ersek
On 09/06/17 10:15, Wang, Jian J wrote: > Hi guys, > > I found an ASSERT issue in function InstallVbeShim() in QemuVideoDxe > driver during reset. The assert statement is like below. > > ASSERT (Int0x10->Segment == 0x); > ASSERT (Int0x10->Offset == 0x); > > This happened after I

[edk2] ASSERT in QemuVideoDxe driver during reset

2017-09-06 Thread Wang, Jian J
Hi guys, I found an ASSERT issue in function InstallVbeShim() in QemuVideoDxe driver during reset. The assert statement is like below. ASSERT (Int0x10->Segment == 0x); ASSERT (Int0x10->Offset == 0x); This happened after I have enabled NULL pointer access detection feature, in