Re: [edk2] portability of ShellPkg

2018-09-06 Thread Andrew Fish
Mike, More possible ideas I think from a 10,000 foot level the issue is the Public definition of the HOB lib calls out the ASSERT behavior 5) Make the ASSERT() conditional via a PCD and update the HOB lib definition. For platforms that make HOBs options GetHobList() must be called 1st, and

Re: [edk2] portability of ShellPkg

2018-09-06 Thread Kinney, Michael D
Ray, I have a few ideas here. 1) Add a new UefiHobLib instance that is only for use by UEFI Drivers and UEFI Applications. It fails gracefully if the HOB List is not in the UEFI System Configuration Table. BootMode if HobList is not present can be BOOT_WITH_FULL_CONFIGURATION. 2)

Re: [edk2] portability of ShellPkg

2018-09-06 Thread Laszlo Ersek
On 09/06/18 04:34, Ni, Ruiyu wrote: > On 9/6/2018 3:47 AM, Andrew Fish wrote: >> >> Laszlo, >> >> gEfiMemoryTypeInformationGuid is an edk2/MdeModulePkg concept used to >> give the DXE Core hints on how to reduce fragmentation in the memory >> map. Typically there is code in PEI that creates a HOB

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Ni, Ruiyu
On 9/6/2018 3:47 AM, Andrew Fish wrote: Laszlo, gEfiMemoryTypeInformationGuid is an edk2/MdeModulePkg concept used to give the DXE Core hints on how to reduce fragmentation in the memory map. Typically there is code in PEI that creates a HOB and may consume a variable written by the BDS.

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Carsey, Jaben
September 05, 2018 11:33 AM > To: Carsey, Jaben > Cc: Ni, Ruiyu ; Heinrich Schuchardt > ; edk2-devel@lists.01.org; Alexander Graf > ; AKASHI Takahiro ; Kinney, > Michael D ; Laszlo Ersek > > Subject: Re: [edk2] portability of ShellPkg > Importance: High > > Jaben, >

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Laszlo Ersek
On 09/05/18 19:25, Leif Lindholm wrote: > Hi all, > > (This is partly a summary of discussions that have been held on IRC > and offline, with Alex Graf and Mike Kinney.) > > The UEFI Shell, as produced by the contents of ShellPkg, is needed for > running the UEFI SCT. This has never been

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Andrew Fish
Jaben, Sorry to test compile a library just list the library in the [Components] section of the DSC file. MdePkg/MdePkg.dsc is an example of this. Thanks, Andrew Fish > On Sep 5, 2018, at 11:23 AM, Carsey, Jaben wrote: > > Aha. So that is very different from a non NULL library when listed

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Carsey, Jaben
Aha. So that is very different from a non NULL library when listed in the components section. The goal is to test compile the library but not use I think. Is there any way to do that? Jaben On Sep 5, 2018, at 11:21 AM, Andrew Fish mailto:af...@apple.com>> wrote: On Sep 5, 2018, at 11:05

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Andrew Fish
> On Sep 5, 2018, at 11:05 AM, Carsey, Jaben wrote: > > But a NULL lib listed in components section shouldn’t be linked in to > anything... > Jaben, A NULL library class means force it to be linked in. ShellPkg/ShellPkg.dsc:70: # [LibraryClasses.ARM] and NULL mean link this library

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Carsey, Jaben
But a NULL lib listed in components section shouldn’t be linked in to anything... Unless is listed below with the shell INF also, it just test compiles it... Or so I thought. On Sep 5, 2018, at 11:04 AM, Andrew Fish mailto:af...@apple.com>> wrote: On Sep 5, 2018, at 10:30 AM, Carsey, Jaben

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Andrew Fish
> On Sep 5, 2018, at 10:30 AM, Carsey, Jaben wrote: > > How does removing a lib from the components section affect the shell binary > output? > > Is the asset at compile time? Jaben, The issue is likely with the HOB lib constructor in the Shell iASSERTing. Leif's example platform

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Leif Lindholm
On Wed, Sep 05, 2018 at 05:30:23PM +, Carsey, Jaben wrote: > How does removing a lib from the components section affect the shell binary > output? Maybe it doesn't and I'm barking up the wrong tree? Unfortunately, the only thing that means is we don't have a trivial workaround. / Leif

Re: [edk2] portability of ShellPkg

2018-09-05 Thread Carsey, Jaben
How does removing a lib from the components section affect the shell binary output? Is the asset at compile time? Jaben > On Sep 5, 2018, at 10:26 AM, Leif Lindholm wrote: > > Hi all, > > (This is partly a summary of discussions that have been held on IRC > and offline, with Alex Graf and

[edk2] portability of ShellPkg

2018-09-05 Thread Leif Lindholm
Hi all, (This is partly a summary of discussions that have been held on IRC and offline, with Alex Graf and Mike Kinney.) The UEFI Shell, as produced by the contents of ShellPkg, is needed for running the UEFI SCT. This has never been problematic before - but now we are starting to run SCT on