Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

2016-09-28 Thread Zeng, Star
Jiewen, Thanks for the Rb, I just send the V2 patch that follows Laszlo's suggestion to use IoBitFieldRead32 (Port, 0, 23), could you help review the patch again? Star -Original Message- From: Yao, Jiewen Sent: Wednesday, September 28, 2016 7:59 PM To: Zeng, Star ; edk2-devel@lists.01.o

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

2016-09-28 Thread Zeng, Star
] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32() Star, On 09/28/16 12:17, Star Zeng wrote: > Clear bits [31:24] when reading ACPI timer count by IoRead32(), also > add comments "Note: The library only supports 24Bits ACPI timer" in INF. > >

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

2016-09-28 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 28, 2016 6:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Gao, Liming > Subject: [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after > reading by IoRead

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

2016-09-28 Thread Laszlo Ersek
Star, On 09/28/16 12:17, Star Zeng wrote: > Clear bits [31:24] when reading ACPI timer count by IoRead32(), > also add comments "Note: The library only supports 24Bits ACPI timer" in INF. > > Cc: Jiewen Yao > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-