Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Thomas Abraham
On Tue, Nov 20, 2018 at 7:48 PM Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 07:31:34PM +0530, Thomas Abraham wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > > wrote: > > > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > > wrote: > > > > > > > > Hmm, a follow-up question

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Leif Lindholm
On Tue, Nov 20, 2018 at 07:31:34PM +0530, Thomas Abraham wrote: > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Ard Biesheuvel
On Tue, 20 Nov 2018 at 15:01, Thomas Abraham wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm > > wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually generated

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-20 Thread Thomas Abraham
On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel wrote: > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm wrote: > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > We still keep the manually generated GUIDs in > > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > >

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Ard Biesheuvel
On Mon, 19 Nov 2018 at 11:30, Leif Lindholm wrote: > > Hmm, a follow-up question (which does not affect my r-b): > > We still keep the manually generated GUIDs in > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, >

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Leif Lindholm
Hmm, a follow-up question (which does not affect my r-b): We still keep the manually generated GUIDs in ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c,

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash

2018-11-19 Thread Leif Lindholm
On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote: > The ArmPlatformPkg NOR flash driver has been updated to use device paths > consisting of a fixed GUID and a numeric index rather than a separate GUID > for each flash bank on a given system. This means all explicit device path >