Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 10:59, Ni, Ruiyu wrote: > On 10/9/2018 4:25 PM, Laszlo Ersek wrote: >> - for clarity, please use ~(UINTN)BIT31 as mask (even though it makes no >>    practical difference). > Actually we could use IA32_CR0 structure to avoid BIT31 usage. That's a great idea. I wish I had known about

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Ni, Ruiyu
On 10/9/2018 4:25 PM, Laszlo Ersek wrote: On 10/09/18 08:01, Eric Dong wrote: V3 changes: No need to change inf file. Also update commit message to include regression info. V2 changes: Only disable paging in 32 bit mode, no matter it is enable or not. V1 changes: PEI Stack Guard needs to

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Laszlo Ersek
On 10/09/18 08:01, Eric Dong wrote: > V3 changes: > No need to change inf file. Also update commit message to include regression > info. > > V2 changes: > Only disable paging in 32 bit mode, no matter it is enable or not. > > V1 changes: > PEI Stack Guard needs to enable paging. This might

Re: [edk2] [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-09 Thread Ni, Ruiyu
On 10/9/2018 2:01 PM, Eric Dong wrote: V3 changes: No need to change inf file. Also update commit message to include regression info. V2 changes: Only disable paging in 32 bit mode, no matter it is enable or not. V1 changes: PEI Stack Guard needs to enable paging. This might cause #GP if code