Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Zeng, Star
: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled On 06/28/18 08:16, Zeng, Star wrote: > 1) My understanding is Variable Driver is managing the variable region in > flash although the flash read/write/erase operations are done in flash > driver

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Brijesh Singh
On 06/28/2018 07:57 AM, Laszlo Ersek wrote: [...] --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c @@ -847,7 +847,7 @@ MarkMemoryRangeForRuntimeAccess (    );    Status = gDS->AddMemorySpace ( -

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Laszlo Ersek
On 06/28/18 14:57, Laszlo Ersek wrote: > On 06/27/18 19:49, Brijesh Singh wrote: >> >> >> On 06/27/2018 11:59 AM, Laszlo Ersek wrote: >>> On 06/27/18 18:34, Brijesh Singh wrote: On 06/27/2018 07:54 AM, Laszlo Ersek wrote: > On 06/26/18 21:46, Brijesh Singh wrote: >>> >> After that,

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Laszlo Ersek
On 06/28/18 08:25, Zeng, Star wrote: > My understanding is MMIO is not managed by UEFI memory services, but GCD > services. > PI spec says " If the memory range specified by BaseAddress and Length is of > type EfiGcdMemoryTypeSystemMemory or EfiGcdMemoryTypeMoreReliable, then the > memory range

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Laszlo Ersek
lo > Ersek > Sent: Wednesday, June 27, 2018 8:54 PM > To: Brijesh Singh ; edk2-devel@lists.01.org > Cc: Tom Lendacky ; Dong, Eric ; > Zeng, Star ; Justen, Jordan L > Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable > access when SEV is

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Laszlo Ersek
On 06/27/18 19:49, Brijesh Singh wrote: > > > On 06/27/2018 11:59 AM, Laszlo Ersek wrote: >> On 06/27/18 18:34, Brijesh Singh wrote: >>> On 06/27/2018 07:54 AM, Laszlo Ersek wrote: On 06/26/18 21:46, Brijesh Singh wrote: >> > After that, any access > to the flash will end up going

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Zeng, Star
2018 1:50 AM To: Laszlo Ersek ; edk2-devel@lists.01.org Cc: Tom Lendacky ; brijesh.si...@amd.com; Dong, Eric ; Zeng, Star ; Justen, Jordan L Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled On 06/27/2018 11:59 AM, Laszlo Ersek wrote: > O

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-28 Thread Zeng, Star
] On Behalf Of Laszlo Ersek Sent: Wednesday, June 27, 2018 8:54 PM To: Brijesh Singh ; edk2-devel@lists.01.org Cc: Tom Lendacky ; Dong, Eric ; Zeng, Star ; Justen, Jordan L Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled On 06/26/18 21:46

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-27 Thread Brijesh Singh
On 06/27/2018 11:59 AM, Laszlo Ersek wrote: On 06/27/18 18:34, Brijesh Singh wrote: On 06/27/2018 07:54 AM, Laszlo Ersek wrote: On 06/26/18 21:46, Brijesh Singh wrote: After that, any access to the flash will end up going through the encryption engine. I did try hacking EDK2 to restore

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-27 Thread Laszlo Ersek
On 06/27/18 18:34, Brijesh Singh wrote: > On 06/27/2018 07:54 AM, Laszlo Ersek wrote: >> On 06/26/18 21:46, Brijesh Singh wrote: >>> After that, any access >>> to the flash will end up going through the encryption engine. I did try >>> hacking EDK2 to restore the C-bit >> >> (I continue to be

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-27 Thread Brijesh Singh
On 06/27/2018 11:34 AM, Brijesh Singh wrote: I think (2) will solve the complete issue, we still need to figure how I meant to say (2) will *not* solve the complete issue ! ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-27 Thread Brijesh Singh
Thanks for the quick feedback Laszlo ! On 06/27/2018 07:54 AM, Laszlo Ersek wrote: On 06/26/18 21:46, Brijesh Singh wrote: Problem statement: -- Fedora-28 contains 4.16 kernel -- which has all the required support to run as an SEV guest. When the installer is launched from

Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable access when SEV is enabled

2018-06-27 Thread Laszlo Ersek
On 06/26/18 21:46, Brijesh Singh wrote: > Problem statement: > -- > Fedora-28 contains 4.16 kernel -- which has all the required support to > run as an SEV guest. When the installer is launched from SEV guest then > it fails to install the bootloader. The installer was failing to