Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-13 Thread Marcin Wojtas
Hi Leif, 2018-06-13 0:48 GMT+02:00 Leif Lindholm : > So, I've made all the comments I was going to be making on this set. > > Patches 3,5-7,13,20-21 are fine as long as you drop pre-existing > Signed-off-by and Reviewed-by, so if you get rid of those you can add > Reviewed-by: Leif Lindholm >

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-12 Thread Leif Lindholm
So, I've made all the comments I was going to be making on this set. Patches 3,5-7,13,20-21 are fine as long as you drop pre-existing Signed-off-by and Reviewed-by, so if you get rid of those you can add Reviewed-by: Leif Lindholm when reposting. (If any patch apart from the above didn't

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Marcin Wojtas
Hi Ard, 2018-06-11 14:01 GMT+02:00 Ard Biesheuvel : > On 11 June 2018 at 13:49, Marcin Wojtas wrote: >> Hi Ard, >> >> 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : >>> Marcin, >>> >>> I am a bit reluctant to review another huge set of Armada patches >>> while we are still waiting for MacchiatoBin

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Ard Biesheuvel
On 11 June 2018 at 13:49, Marcin Wojtas wrote: > Hi Ard, > > 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : >> Marcin, >> >> I am a bit reluctant to review another huge set of Armada patches >> while we are still waiting for MacchiatoBin support to land. The only >> hardware i have access to is

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Marcin Wojtas
Hi Ard, 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : > Marcin, > > I am a bit reluctant to review another huge set of Armada patches > while we are still waiting for MacchiatoBin support to land. The only > hardware i have access to is MacchiatoBin, and it has been well over a > year now that

Re: [edk2] [platforms PATCH 00/25] Armada herdware description rework

2018-06-11 Thread Ard Biesheuvel
Marcin, I am a bit reluctant to review another huge set of Armada patches while we are still waiting for MacchiatoBin support to land. The only hardware i have access to is MacchiatoBin, and it has been well over a year now that MacchiatoBin support has been between 'under construction' and