Re: [edk2] [PATCH v3] MdeModulePkg: Add HTTP 1.1 industry standard definitions

Can someone please help in reviewing this? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Wednesday, December 16, 2015 4:13 PM To: edk2-devel@lists.01.org Cc: Siyuan Fu ; feng.t...@intel.com; El-Haj-Mahmoud, Samer ;

[edk2] [PATCH] SecurityPkg : Add DEBUG messages in image verification

Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image verification failures Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c| 9 + 1

[edk2] [PATCH] ShellPkg: Add AIP IPv6 UNDI support to Shell dh

Update Shell DH command to decode and print the value of gEfiAdapterInfoUndiIpv6SupportGuid AIP instance Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../UefiHandleParsingLib/UefiHandleParsingLib.c | 21 +++--

Re: [edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Anbazhagan, Baraneedharan Sent: Tuesday, December 22, 2015 12:27 AM To: edk2-devel@lists.01.org; Tian, Feng Subject: [edk2] [PATCH] MdeModulePkg/XhciPei:

[edk2] [PATCH] NetworkPkg : Remove unused local variables to fix gcc build errors

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- NetworkPkg/HttpDxe/HttpProto.c | 4 1 file changed, 4 deletions(-) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 85f8401..7e959d5 100644 ---

[edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH v3] MdeModulePkg: Add HTTP 1.1 industry standard definitions

Hi, Samer The patch is good, I will commit it later. Reviewed-by: Fu Siyuan -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] Sent: Thursday, December 17, 2015 5:13 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan

Re: [edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

What's the benefit of this change? It's not bad, but I don't know why its important... Jaben > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday , December 21, 2015 4:29 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin

[edk2] [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision

Rename TisTpmCommand to Tpm2TisTpmCommand to naming collision with similar function name in other libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Tis.c | 6 +++--- 1 file changed,

Re: [edk2] [PATCH] MdeModulePkg: Add error DEBUG statements in Ata bus driver

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Tuesday, December 22, 2015 5:45 AM To: edk2-devel@lists.01.org Cc: Samer El-Haj-Mahmoud; Tian, Feng Subject: [edk2] [PATCH]

[edk2] [PATCH] MdePkg : Update SPCR to use ACPI5 definition

Update BaseAddress in the SPCR structure to use EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 3 ++- 1 file changed, 2

[edk2] [PATCH 1/3] MdeModulePkg ScsiDiskDxe: Set block I/O media of SCSI CDROM to read-only

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c

[edk2] [PATCH 2/3] MdeModulePkg ScsiDiskDxe: Modify FlushBlocksEx() to follow UEFI spec

The function ScsiDiskFlushBlocksEx() in ScsiDiskDxe/ScsiDisk.c originally always returns EFI_SUCCESS, which is not aligned with the UEFI spec. This commit adds addtional checks to see if the media in the device is changed or removed. Check for whether the device can be written is also added.

[edk2] [PATCH 3/3] MdeModulePkg ScsiDiskDxe: Modify WriteBlocks(Ex)() to follow UEFI spec

The functions ScsiDiskWriteBlocks(Ex) in ScsiDiskDxe/ScsiDisk.c do not check whether the device is allow to be written originally. This commit will add read-only check to follow the UEFI spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 0/3] ScsiDiskDxe: Modify BlockIo(2) APIs to follow spec

Right now, SCSI CD-ROM devices only support read operations, so the block I/O media of those devices should be set to read-only. For FlushBlocksEx() function, checks for media change, removal and write write protection are added. For WriteBlocks(Ex)() functions, check for media write protection

Re: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure

Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, December 21, 2015 4:41 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure VS2015

Re: [edk2] [PATCH v2 0/5] ArmVirtPkg: add ARM support to ArmVirtXen

On Wed, 16 Dec 2015, Ard Biesheuvel wrote: > By special request, this implements ARM support to the ArmVirtXen > platform. This time, I managed to test it myself under Xen on actual > AArch64 hardware, after I figured out that 64-bit supports 32-bit guests > as well. > > Changes since v1: > - two

[edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Fix async request retry times info lost issue

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 24 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 8 2 files changed, 32 insertions(+) diff --git

Re: [edk2] [PATCH] SecurityPkg : Add DEBUG messages in image verification

Samer: 1. Please add DxeImageVerificationLib as Prefix in debug message 2. @@ -2409,6 +2415,7 @@ DxeImageVerificationHandler ( if (IsForbiddenByDbx (AuthData, AuthDataSize, FALSE, NULL, NULL)) { Action = EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED; VerifyStatus = EFI_ACCESS_DENIED;

Re: [edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

Jaben, Using UEFI_APPLICATION for all Shell app and libraries allows the use of different compiler flags for the Shell application itself and also for any other applications that are built separately and that use Shell libraries. It looks like the ShellPkg INFs use a mix of UEFI_APPLICATION

Re: [edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Fix async request retry times info lost issue

Looks good to me. Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 21, 2015 17:35 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeModulePkg

Re: [edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

On 2015/12/21 22:53, Ruiyu Ni wrote: The patch updates the Century value in CMOS location specified by FADT.Century to avoid UEFI Win7 hang during booting. Per the ACPI spec if the FADT.Century is zero, it's not needed to store the century value in CMOS. But UEFI Win7 treats the Century storage

Re: [edk2] [Patch] NetworkPkg: Update NetworkPkg.uni to UTF-8 file format

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye Ting Sent: Tuesday, December 22, 2015 11:02 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] NetworkPkg: Update NetworkPkg.uni to UTF-8 file

Re: [edk2] [PATCH v2 2/4] ShellPkg: Refine the code logic of 'command history'.

Can you make this into a PCD? That would be cleaner. I would like patchable be one option. > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben >

Re: [edk2] [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision

Samer: Please also update debug log in Line 480 DEBUG_CODE ( DEBUG ((EFI_D_VERBOSE, "TisTpmCommand ReceiveHeader - ")); for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEADER); Index++) { DEBUG ((EFI_D_VERBOSE, "%02x ", BufferOut[Index])); } DEBUG ((EFI_D_VERBOSE,

Re: [edk2] [PATCH 0/3] ScsiDiskDxe: Modify BlockIo(2) APIs to follow spec

Looks good to me. Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Monday, December 21, 2015 17:06 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH 0/3] ScsiDiskDxe: Modify BlockIo(2) APIs to follow spec Right now, SCSI CD-ROM

Re: [edk2] [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL definition

Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, Siyuan Sent: Monday, December 21, 2015 11:03 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Ye, Ting

Re: [edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > ; Ni, Ruiyu > Subject:

Re: [edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Add retry scheme for async SCSI I/O command

Looks good to me Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Tuesday, December 22, 2015 00:18 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH] MdeModulePkg ScsiDiskDxe: Add retry scheme for async SCSI I/O command Some

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, December 21, 2015 4:45 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch] MdeModulePkg:Make HII

Re: [edk2] [PATCH v2 1/4] ShellPkg: Fix memory leak in SimpleTextOutput on file.

Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > ; Ni, Ruiyu > Subject:

Re: [edk2] [PATCH 0/3] Not signal caller event when async SCSI I/O cmd fails

Looks good to me Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Monday, December 21, 2015 17:33 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH 0/3] Not signal caller event when async SCSI I/O cmd fails When a BlockIO2

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Yes, all the Hii database data will be export. Also the ConfigResp string for all HII drivers. -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, December 22, 2015 9:25 AM To: Dong, Eric; Bi, Dandan; edk2-devel@lists.01.org Cc: Gao,

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Does this also export all string packages? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric Sent: Monday, December 21, 2015 8:22 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Gao, Liming

Re: [edk2] [PATCH] SecurityPkg : Add DEBUG messages in image verification

On Dec 21, 2015 9:02 PM, "Samer El-Haj-Mahmoud" < samer.el-haj-mahm...@hpe.com> wrote: > > Add DEBUG messages in DxeImageerificationLib to help debug > Secure Boot image verification failures > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud

Re: [edk2] [PATCH] MdeModulePkg DiskIoDxe: Check for MediaPresent in DiskIo2ReadWriteDisk()

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 21, 2015 17:08 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeModulePkg DiskIoDxe: Check

Re: [edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

Seems I didn't have the 'MdePkg: Disable VS2015 warning C4701 & C4703' change in my local copy. Please disregard the patch. Thanks. -Baranee > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, December 21, 2015 8:56 PM > To: Anbazhagan, Baraneedharan

Re: [edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

Star, Thanks for the suggestion. I agree that only starting to listen AcpiTable change event after ReadyToBoot can reduce the ACPI table parsing times. But the ACPI table parsing just walks through n * 4 or n * 8 bytes where n is at most 20 or more. Comparing to the performance the change gains, I

Re: [edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

On 2015/12/22 14:14, Ni, Ruiyu wrote: Star, Thanks for the suggestion. I agree that only starting to listen AcpiTable change event after ReadyToBoot can reduce the ACPI table parsing times. But the ACPI table parsing just walks through n * 4 or n * 8 bytes where n is at most 20 or more.

[edk2] [PATCH 3/3] ShellPkg: Fix memory leak in ShellProtocol.

1. Close unused file handles. 2. Free the local allocated buffer before function is returned. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin ---

[edk2] [PATCH 1/3] ShellPkg: Fix memory leak in SimpleTextOutput on file.

Free 'SimpleTextOut->Mode' buffer before 'SimpleTextOut' is free. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/ConsoleWrappers.c

Re: [edk2] [Patch] BaseTools: Update Scripts to support VS2015 env

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, December 21, 2015 5:09 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools:

[edk2] [PATCH 2/3] MdePkg UefiScsiLib: Close event when SCSI command fails

The ScsiExecuteSCSICommand() function in ScsiBusDxe driver will not signal the event passed from UefiScsiLib when error occurs. In this case, UefiScsiLib should close the event passing to ScsiExecuteSCSICommand(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 0/3] Not signal caller event when async SCSI I/O cmd fails

When a BlockIO2 request is sent to a SCSI device, the callstack can be shown as the following diagram: |---| Create |---| | BlockIO2 |->| BlockIO2 Event | |---| |---| |

[edk2] [PATCH 1/3] MdeModulePkg ScsiBusDxe: Only signal caller event when PassThru() succeeds

In ScsiExecuteSCSICommand(), when SCSI devices do not support non-blocking I/O but an event is passed from caller (UefiScsiLib), the function will execute the SCSI I/O command in a blocking manner and signal the caller event when the command completes. Originally, caller event from UefiScsiLib

[edk2] [PATCH 3/3] MdeModulePkg ScsiDiskDxe: Close event when SCSI command fails

The functions ScsiRead10CommandEx(), ScsiWrite10CommandEx(), ScsiRead16CommandEx() and ScsiWrite16CommandEx() in UefiScsiLib will not signal the event passed from ScsiDiskDxe when error occurs. In this case, ScsiDiskDxe should close the event passing to these APIs in UefiScsiLib.

Re: [edk2] [patch] MdeModulePkg:Update Boot Manager form when enter it.

Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 5:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Update Boot Manager form when enter it. Currently BootManager is an

Re: [edk2] [patch] MdeModulePkg:Clear the screen before booting the boot option

Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Friday, December 18, 2015 1:50 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Clear the screen before booting the boot option When do UiApp remodeling

[edk2] [PATCH 0/3] ShellPkg: Fix memory leak issues in Shell.

Qiu Shumin (3): ShellPkg: Fix memory leak in SimpleTextOutput on file. ShellPkg: Refine the code logic of 'command history'. ShellPkg: Fix memory leak in ShellProtocol. ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++- ShellPkg/Application/Shell/Shell.c | 24

[edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure

VS2015 separates vcruntime.lib and ucrt.lib from msvcrt.lib. Per MSDN notes, If you link with the /nodefaultlib option, you will need to link several extra libraries when you link. For example, whereas you previously might have just linked msvcrt.lib in order to use the CRT DLL, you will now also

[edk2] [PATCH] MdeModulePkg DiskIoDxe: Check for MediaPresent in DiskIo2ReadWriteDisk()

Add check to see if there is a media in the disk device. If not return EFI_NO_MEDIA directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIo.c | 4 1 file changed, 4 insertions(+) diff

Re: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak issues in Shell.

Reviewed-by: Ruiyu Ni -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Monday, December 21, 2015 4:43 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin Subject: [edk2] [PATCH 0/3]

[edk2] [Patch] BaseTools: Update Scripts to support VS2015 env

edk2 Edk2Setup.bat depends on those scripts to configure VS env. Update them to support VS2015. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Scripts/SetVisualStudio.bat | 5 + BaseTools/Scripts/ShowEnvironment.bat |

Re: [edk2] [PATCH] ShellPkg: Add AIP IPv6 UNDI support to Shell dh

Reviewed-by: Jaben Carsey > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 21, 2015 4:22 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin >

Re: [edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

I am fine with the change. I just wanted to know what the goal was... if the library could be used by a DXE, then shouldn't we just all EFI_APPLICATION as another of the supported build types? > -Original Message- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] >

Re: [edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

Hi, When I build this module with VS2015, no warning message will report. In fact, we disable VS2015 warning C4701 & C4703 in MdePkg/Include/Ia32/ProcessorBind.h and MdePkg/Include/X64/ProcessorBind.h. They should not be reported in build time. So, could you let me know how you meet VS2015

[edk2] [Patch] NetworkPkg: Update NetworkPkg.uni to UTF-8 file format

Patch "NetworkPkg: Update iSCSI driver to check existing AIP instances" updates NetworkPkg.uni to UTF-16LE wrongly. The patch uses BaseTools\Scripts\ConvertUni.py to change it back to UTF-8 file format. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ye Ting

Re: [edk2] [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL definition

Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, December 22, 2015 11:56 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan Subject: [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL

Re: [edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O

Thanks for the feedback. I will update the codes before committing the patches. Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, December 22, 2015 3:06 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng > Subject: RE: [edk2] [PATCH 0/4]

Re: [edk2] [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL definition

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Tuesday, December 22, 2015 11:56 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: [Patch] NetworkPkg: Remove unused EFI_HTTP_PROTOCOL definition This patch is used to remove unused

Re: [edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O

I think as you raise notify event from callback to notify you have to protect critical data, mainly the transfer queue, by raising TPL to NOTIFY at accessing code as well. Others look good to me. Reviewed-by: Feng Tian -Original Message- From: edk2-devel

[edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

Initialize EvTrb local variable Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Baraneedharan Anbazhagan --- MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c

[edk2] [PATCH v2 4/4] ShellPkg: Use Internal function to get environment variable to avoid memory leak.

Caller don't need to free the buffer returned from 'EfiShellGetEnv'. So for Shell internal code if it used 'EfiShellGetEnv' to get variable the unfreed buffer may cause memory leak. So this patch add a 'InternalShellGetEnv' to get environment variable to avoid this issue. Cc: Jaben Carsey

[edk2] [PATCH v2 0/4] ShellPkg: fix memory leak issues.

Qiu Shumin (4): ShellPkg: Fix memory leak in SimpleTextOutput on file. ShellPkg: Refine the code logic of 'command history'. ShellPkg: Fix memory leak in ShellProtocol. ShellPkg: Use Internal function to get environment variable to avoid memory leak.

[edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

1. Close unused file handle. 2. Free the local allocated buffer function returned. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Ruiyu Ni

[edk2] [PATCH v2 1/4] ShellPkg: Fix memory leak in SimpleTextOutput on file.

Free 'SimpleTextOut->Mode' buffer before 'SimpleTextOut' is free. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Ruiyu Ni ---

[edk2] [PATCH v2 2/4] ShellPkg: Refine the code logic of 'command history'.

Add the macro MAX_HISTORY_COMMANDS_COUNT to indicate the max count of history commands. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Ruiyu Ni

[edk2] [PATCH 3/4] MdeModulePkg ScsiBusDxe: Raise the Tpl of async IO callback to TPL_NOTIFY

Raise the Tpl of async SCSI I/O callback function to TPL_NOTIFY to match the behavior in ScsiDiskDxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [PATCH 2/4] MdePkg UefiScsiLib: Raise the Tpl of async IO callback to TPL_NOTIFY

Raise the Tpl of async SCSI I/O callback function to TPL_NOTIFY to match the behavior in ScsiDiskDxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 8 1 file changed, 4

[edk2] [PATCH 4/4] MdeModulePkg UfsPassThruDxe: Raise to TPL_NOTIFY when dealing async task

This commit will raise the Tpl to TPL_NOTIFY when adding non-blocking SCSI I/O requests to the asynchronous task list. This commit will also raise the Tpl of asynchronous task polling timer to TPL_NOTIFY. These changes are made to match the behavior in ScsiDiskDxe driver. Contributed-under:

[edk2] [PATCH 1/4] MdeModulePkg ScsiDiskDxe: Raise the Tpl of async IO callback to TPL_NOTIFY

When reading data from non-blockingly from a CD-ROM logic partition, the procedure can be shown by the following call stack: (The write process is similar) |---| | DiskIoDxe (logic) |<---Raise Tpl to TPL_CALLBACK |---| | | Sub-task 1 (UnderRun) succeeds | |

[edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O

When reading data from non-blockingly from a CD-ROM logic partition, the procedure can be shown by the following call stack: (The write process is similar) |---| | DiskIoDxe (logic) |<---Raise Tpl to TPL_CALLBACK |---| | | Sub-task 1 (UnderRun) succeeds | |

[edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

The patch updates the Century value in CMOS location specified by FADT.Century to avoid UEFI Win7 hang during booting. Per the ACPI spec if the FADT.Century is zero, it's not needed to store the century value in CMOS. But UEFI Win7 treats the Century storage is optional only when FADT.Century is

[edk2] [PATCH] MdeModulePkg ScsiDiskDxe: Add retry scheme for async SCSI I/O command

Some SCSI devices will return EFI_DEVICE_ERROR or EFI_TIMEOUT when the data length of a SCSI I/O command is too large. This commit will repeatedly retry sending the SCSI command with a data length half of its previous value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: